mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Improve reaction types

Browse source
This commit is contained in:
Evan Hahn 2021-10-13 11:29:15 -05:00 • committed by GitHub
parent 35a54cdc02
commit 21c00f51bd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ts/messageModifiers/Reactions.ts
View file

@ -13,7 +13,7 @@ export class ReactionModel extends Model<ReactionAttributesType> {}
let singleton: Reactions | undefined; let singleton: Reactions | undefined;
export class Reactions extends Collection { export class Reactions extends Collection<ReactionModel> {
static getSingleton(): Reactions { static getSingleton(): Reactions {
if (!singleton) { if (!singleton) {
singleton = new Reactions(); singleton = new Reactions();

2
ts/model-types.d.ts vendored
View file

@ -373,7 +373,7 @@ export type ReactionAttributesType = {
remove?: boolean; remove?: boolean;
targetAuthorUuid: string; targetAuthorUuid: string;
targetTimestamp: number; targetTimestamp: number;
fromId?: string; fromId: string;
timestamp: number; timestamp: number;
fromSync?: boolean; fromSync?: boolean;
}; };

2
ts/models/conversations.ts
View file

@ -4870,7 +4870,7 @@ export class ConversationModel extends window.Backbone
async notify( async notify(
message: Readonly<MessageModel>, message: Readonly<MessageModel>,
reaction?: WhatIsThis reaction?: Readonly<ReactionModel>
): Promise<void> { ): Promise<void> {
// As a performance optimization don't perform any work if notifications are // As a performance optimization don't perform any work if notifications are
// disabled. // disabled.

4
ts/models/messages.ts
View file

@ -108,7 +108,7 @@ import {
MessageReceiptType, MessageReceiptType,
} from '../messageModifiers/MessageReceipts'; } from '../messageModifiers/MessageReceipts';
import { Deletes } from '../messageModifiers/Deletes'; import { Deletes } from '../messageModifiers/Deletes';
import { Reactions } from '../messageModifiers/Reactions'; import { Reactions, ReactionModel } from '../messageModifiers/Reactions';
import { ReadSyncs } from '../messageModifiers/ReadSyncs'; import { ReadSyncs } from '../messageModifiers/ReadSyncs';
import { ViewSyncs } from '../messageModifiers/ViewSyncs'; import { ViewSyncs } from '../messageModifiers/ViewSyncs';
import { ViewOnceOpenSyncs } from '../messageModifiers/ViewOnceOpenSyncs'; import { ViewOnceOpenSyncs } from '../messageModifiers/ViewOnceOpenSyncs';
@ -3167,7 +3167,7 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
} }
async handleReaction( async handleReaction(
reaction: typeof window.WhatIsThis, reaction: ReactionModel,
shouldPersist = true shouldPersist = true
): Promise<ReactionAttributesType | undefined> { ): Promise<ReactionAttributesType | undefined> {
const { attributes } = this; const { attributes } = this;