mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Log entry max to 2k, remove logging in hot codepaths (#1459)

Browse source 
On a recent trip through a CPU profile taken while Signal Desktop
churned through a large backlog of messages, it was clear that
console.log was a major source of time spent, primarily the sort
operation required after every new entry is added to the Backbone
collection. So, three different techniques to combat this:

1) Reduce the maximum number of entries in the collection from 5k to 2k
2) No more logging of add/update/remove queue in MessageReceiver
3) No more log entries in Message.handleDataMessage main codepath

FREEBIE
This commit is contained in:
Scott Nonnenberg 2017-09-12 09:34:49 -07:00 • committed by GitHub
parent 69af8d2651
commit 1e694fe8d7
4 changed files with 1 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

3
js/libtextsecure.js
View file

@ -38487,7 +38487,6 @@ MessageReceiver.prototype.extend({
},
addToCache: function(envelope, plaintext) {
var id = this.getEnvelopeId(envelope);
console.log('addToCache', id);
var data = {
id: id,
envelope: plaintext,
@ -38498,7 +38497,6 @@ MessageReceiver.prototype.extend({
},
updateCache: function(envelope, plaintext) {
var id = this.getEnvelopeId(envelope);
console.log('updateCache', id);
var data = {
decrypted: plaintext
};
@ -38506,7 +38504,6 @@ MessageReceiver.prototype.extend({
},
removeFromCache: function(envelope) {
var id = this.getEnvelopeId(envelope);
console.log('removeFromCache', id);
return textsecure.storage.unprocessed.remove(id);
},
queueDecryptedEnvelope: function(envelope, plaintext) {