mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Always use static/cached selectors in useSelector

Browse source
This commit is contained in:
Jamie Kyle 2024-03-15 07:38:26 -07:00 • committed by GitHub
parent d85a1d5074
commit 1e275a917c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 105 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

10
ts/state/smart/SafetyNumberModal.tsx
View file

@ -3,8 +3,7 @@
import React, { memo } from 'react';
import { useSelector } from 'react-redux';
import { SafetyNumberModal } from '../../components/SafetyNumberModal';
import type { StateType } from '../reducer';
import { getContactSafetyNumber } from '../selectors/safetyNumber';
import { getContactSafetyNumberSelector } from '../selectors/safetyNumber';
import { getConversationSelector } from '../selectors/conversations';
import { getIntl } from '../selectors/user';
import { useSafetyNumberActions } from '../ducks/safetyNumber';
@ -20,9 +19,10 @@ export const SmartSafetyNumberModal = memo(function SmartSafetyNumberModal({
const i18n = useSelector(getIntl);
const conversationSelector = useSelector(getConversationSelector);
const contact = conversationSelector(contactID);
const contactSafetyNumber = useSelector((state: StateType) => {
return getContactSafetyNumber(state, { contactID });
});
const contactSafetyNumberSelector = useSelector(
getContactSafetyNumberSelector
);
const contactSafetyNumber = contactSafetyNumberSelector(contactID);
const { generateSafetyNumber, toggleVerified } = useSafetyNumberActions();
const { toggleSafetyNumberModal } = useGlobalModalActions();
return (