mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Always use static/cached selectors in useSelector

Browse source
This commit is contained in:
Jamie Kyle 2024-03-15 07:38:26 -07:00 • committed by GitHub
parent d85a1d5074
commit 1e275a917c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 105 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

17
ts/state/smart/CompositionArea.tsx
View file

@ -15,7 +15,6 @@ import { getAddedByForOurPendingInvitation } from '../../util/getAddedByForOurPe
import { imageToBlurHash } from '../../util/imageToBlurHash';
import { isConversationSMSOnly } from '../../util/isConversationSMSOnly';
import { isSignalConversation } from '../../util/isSignalConversation';
import type { StateType } from '../reducer';
import {
getErrorDialogAudioRecorderType,
getRecordingState,
@ -163,15 +162,23 @@ export const SmartCompositionArea = memo(function SmartCompositionArea({
};
}
const quotedMessageProps = useSelector((state: StateType) => {
const ourConversationId = useSelector(getUserConversationId);
const defaultConversationColor = useSelector(getDefaultConversationColor);
const quotedMessageProps = useMemo(() => {
return quotedMessage
? getPropsForQuote(quotedMessage, {
conversationSelector,
ourConversationId: getUserConversationId(state),
defaultConversationColor: getDefaultConversationColor(state),
ourConversationId,
defaultConversationColor,
})
: undefined;
});
}, [
quotedMessage,
conversationSelector,
ourConversationId,
defaultConversationColor,
]);
const { putItem, removeItem } = useItemsActions();