mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Challenge: If no retry-after header on 428, don't start timer for retry

Browse source
This commit is contained in:
Scott Nonnenberg 2022-04-25 16:05:23 -07:00 • committed by GitHub
parent 9921a07a0b
commit 1d26424f22
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 58 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

17
ts/util/parseRetryAfter.ts
View file

@ -7,15 +7,24 @@ import { isNormalNumber } from './isNormalNumber';
const DEFAULT_RETRY_AFTER = MINUTE;
const MINIMAL_RETRY_AFTER = SECOND;
export function parseRetryAfter(value: unknown): number {
if (typeof value !== 'string') {
export function parseRetryAfterWithDefault(value: unknown): number {
const retryAfter = parseRetryAfter(value);
if (retryAfter === undefined) {
return DEFAULT_RETRY_AFTER;
}
return Math.max(retryAfter, MINIMAL_RETRY_AFTER);
}
export function parseRetryAfter(value: unknown): number | undefined {
if (typeof value !== 'string') {
return undefined;
}
const retryAfter = parseInt(value, 10);
if (!isNormalNumber(retryAfter) || retryAfter.toString() !== value) {
return DEFAULT_RETRY_AFTER;
return undefined;
}
return Math.max(retryAfter * SECOND, MINIMAL_RETRY_AFTER);
return retryAfter * SECOND;
}