mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Revert "optimize timeline scroll performance"

Browse source
This commit is contained in:
Jamie Kyle 2023-08-01 10:24:45 -07:00 committed by GitHub
parent 827dc66220
commit 1c9651f557
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
ts/components/conversation/Timeline.tsx
View file

@ -399,14 +399,12 @@ export class Timeline extends React.Component<
const newestBottomVisibleMessageId = const newestBottomVisibleMessageId =
getMessageIdFromElement(newestBottomVisible); getMessageIdFromElement(newestBottomVisible);
this.updatePartiallyVisibleMessageIds( this.setState({
oldestPartiallyVisibleMessageId, oldestPartiallyVisibleMessageId,
newestBottomVisibleMessageId newestBottomVisibleMessageId,
); });
if (this.props.isNearBottom !== newIsNearBottom) { setIsNearBottom(id, newIsNearBottom);
setIsNearBottom(id, newIsNearBottom);
}
if (newestBottomVisibleMessageId) { if (newestBottomVisibleMessageId) {
this.markNewestBottomVisibleMessageRead(); this.markNewestBottomVisibleMessageRead();
@ -463,19 +461,6 @@ export class Timeline extends React.Component<
this.intersectionObserver.observe(atBottomDetectorEl); this.intersectionObserver.observe(atBottomDetectorEl);
} }
private updatePartiallyVisibleMessageIds = throttle(
(
oldestPartiallyVisibleMessageId: string | undefined,
newestBottomVisibleMessageId: string | undefined
) => {
this.setState({
oldestPartiallyVisibleMessageId,
newestBottomVisibleMessageId,
});
},
100
);
private markNewestBottomVisibleMessageRead = throttle((): void => { private markNewestBottomVisibleMessageRead = throttle((): void => {
const { id, markMessageRead } = this.props; const { id, markMessageRead } = this.props;
const { newestBottomVisibleMessageId } = this.state; const { newestBottomVisibleMessageId } = this.state;