mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Save attachments with macOS quarantine attribute

Browse source 
* Attachments: Always save file to downloads directory, show toast
* Add new build:dev command for casual builds
This commit is contained in:
Scott Nonnenberg 2020-01-09 11:57:43 -08:00 • committed by Ken Powers
parent 65befde0fa
commit 1bf9ca7233
11 changed files with 202 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

42
ts/types/Attachment.ts
View file

@ -3,8 +3,6 @@ import moment from 'moment';
import { isNumber, padStart } from 'lodash';
import * as MIME from './MIME';
import { arrayBufferToObjectURL } from '../util/arrayBufferToObjectURL';
import { saveURLAsFile } from '../util/saveURLAsFile';
import { SignalService } from '../protobuf';
import {
isImageTypeSupported,
@ -326,31 +324,37 @@ export const isVoiceMessage = (attachment: Attachment): boolean => {
return false;
};
export const save = ({
export const save = async ({
attachment,
document,
index,
getAbsolutePath,
readAttachmentData,
writeToDownloads,
timestamp,
}: {
attachment: Attachment;
document: Document;
index: number;
getAbsolutePath: (relativePath: string) => string;
readAttachmentData: (relativePath: string) => Promise<ArrayBuffer>;
writeToDownloads: (options: {
data: ArrayBuffer;
name: string;
}) => Promise<{ name: string; fullPath: string }>;
timestamp?: number;
}): void => {
const isObjectURLRequired = is.undefined(attachment.path);
const url = !is.undefined(attachment.path)
? getAbsolutePath(attachment.path)
: arrayBufferToObjectURL({
data: attachment.data,
type: MIME.APPLICATION_OCTET_STREAM,
});
const filename = getSuggestedFilename({ attachment, timestamp, index });
saveURLAsFile({ url, filename, document });
if (isObjectURLRequired) {
URL.revokeObjectURL(url);
}): Promise<string> => {
if (!attachment.path && !attachment.data) {
throw new Error('Attachment had neither path nor data');
}
const data = attachment.path
? await readAttachmentData(attachment.path)
: attachment.data;
const name = getSuggestedFilename({ attachment, timestamp, index });
const { name: savedFilename } = await writeToDownloads({
data,
name,
});
return savedFilename;
};
export const getSuggestedFilename = ({