From 13fb40fdcc4c827665ec319e2a0b9f04592322ec Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Thu, 8 Jun 2017 15:36:05 -0700 Subject: [PATCH] Make spacing at top/bottom of last seen indicator consistent Sadly, that spacing now needs to be bigger because scrollIntoView doesn't honor margins which overlap each other to eliminate this kind of 'too much spacing' kind of problem. FREEBIE --- stylesheets/_conversation.scss | 9 ++++++--- stylesheets/manifest.css | 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/stylesheets/_conversation.scss b/stylesheets/_conversation.scss index 6ec567048303..a2b30bebb460 100644 --- a/stylesheets/_conversation.scss +++ b/stylesheets/_conversation.scss @@ -696,9 +696,12 @@ li.entry .error-icon-container { } .message-list .last-seen-indicator-view { - // We need this extra layer of DOM nodes because scrollIntoView() doesn't honor margins - padding-bottom: 2em; - padding-top: 2em; + // This padding is large so we clear the avatar circle extending into the conversation + // window.scrollIntoView() doesn't honor margins, so we're using padding + // padding-top is less to account for the 10px margin at the bottom of messages + padding-top: 25px; + padding-bottom: 35px; + .bar { display: flex; diff --git a/stylesheets/manifest.css b/stylesheets/manifest.css index 0d38da99a083..1b4c278759a2 100644 --- a/stylesheets/manifest.css +++ b/stylesheets/manifest.css @@ -1506,8 +1506,8 @@ li.entry .error-icon-container { border-radius: 5px; } .message-list .last-seen-indicator-view { - padding-bottom: 2em; - padding-top: 2em; } + padding-top: 25px; + padding-bottom: 35px; } .message-list .last-seen-indicator-view .bar { display: flex; flex-direction: column;