mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Make valid-i18n-keys rule strict and fix most exceptions

Browse source
This commit is contained in:
Jamie Kyle 2023-03-29 10:15:54 -07:00 • committed by GitHub
parent 18a6da310f
commit 11cfcb4e32
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
36 changed files with 796 additions and 687 deletions
Download patch file Download diff file Expand all files Collapse all files

20
ts/components/ConversationList.tsx
View file

@ -103,9 +103,17 @@ type MessageRowType = {
type HeaderRowType = {
type: RowType.Header;
i18nKey: string;
getHeaderText: (i18n: LocalizerType) => string;
};
// Exported for tests across multiple files
export function _testHeaderText(row: Row | void): string | null {
if (row?.type === RowType.Header) {
return row.getHeaderText(((key: string) => key) as LocalizerType);
}
return null;
}
type SearchResultsLoadingFakeHeaderType = {
type: RowType.SearchResultsLoadingFakeHeader;
};
@ -375,18 +383,18 @@ export function ConversationList({
/>
);
break;
case RowType.Header:
case RowType.Header: {
const headerText = row.getHeaderText(i18n);
result = (
<div
className="module-conversation-list__item--header"
// eslint-disable-next-line local-rules/valid-i18n-keys
aria-label={i18n(row.i18nKey)}
aria-label={headerText}
>
{/* eslint-disable-next-line local-rules/valid-i18n-keys */}
{i18n(row.i18nKey)}
{headerText}
</div>
);
break;
}
case RowType.MessageSearchResult:
result = <>{renderMessageSearchResult?.(row.messageId)}</>;
break;