mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Make MessageView.render() idempotent

Browse source 
Re-renders happen when we re-fetch messages from the database, and our
previous technique for loading attachments resulted in a new attachment
view added for every call to render()

This change ensures that a second call to render() does not add any more
attachment views.

FREEBIE
This commit is contained in:
Scott Nonnenberg 2017-05-31 11:32:17 -07:00
parent 25ebcc3131
commit 0e1b534d3c
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
js/views/message_view.js
View file

@ -261,6 +261,11 @@
this.$('.avatar').replaceWith(avatarView.render().$('.avatar')); this.$('.avatar').replaceWith(avatarView.render().$('.avatar'));
}, },
loadAttachments: function() { loadAttachments: function() {
if (this.loadedAttachments) {
return;
}
this.loadedAttachments = [];
this.model.get('attachments').forEach(function(attachment) { this.model.get('attachments').forEach(function(attachment) {
var view = new Whisper.AttachmentView({ var view = new Whisper.AttachmentView({
model: attachment, model: attachment,
@ -274,6 +279,7 @@
} }
}); });
view.render(); view.render();
this.loadedAttachments.push(view);
}.bind(this)); }.bind(this));
} }
}); });