mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Delete for Everyone: Don't allow unrestricted deletes in Note to Self

Browse source
This commit is contained in:
Scott Nonnenberg 2024-01-03 08:46:39 -08:00 • committed by GitHub
parent 677ab64335
commit 0cc6228ede
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 25 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

15
ts/test-electron/state/selectors/messages_test.ts
View file

@ -73,8 +73,9 @@ describe('state/selectors/messages', () => {
type: 'incoming' as const,
sent_at: Date.now() - 1000,
};
const isMe = false;
assert.isFalse(canDeleteForEveryone(message));
assert.isFalse(canDeleteForEveryone(message, isMe));
});
it('returns false for messages that were already deleted for everyone', () => {
@ -93,8 +94,9 @@ describe('state/selectors/messages', () => {
},
},
};
const isMe = false;
assert.isFalse(canDeleteForEveryone(message));
assert.isFalse(canDeleteForEveryone(message, isMe));
});
it('returns false for messages that were are too old to delete', () => {
@ -112,8 +114,9 @@ describe('state/selectors/messages', () => {
},
},
};
const isMe = false;
assert.isFalse(canDeleteForEveryone(message));
assert.isFalse(canDeleteForEveryone(message, isMe));
});
it("returns false for messages that haven't been sent to anyone", () => {
@ -131,8 +134,9 @@ describe('state/selectors/messages', () => {
},
},
};
const isMe = false;
assert.isFalse(canDeleteForEveryone(message));
assert.isFalse(canDeleteForEveryone(message, isMe));
});
it('returns true for messages that meet all criteria for deletion', () => {
@ -154,8 +158,9 @@ describe('state/selectors/messages', () => {
},
},
};
const isMe = false;
assert.isTrue(canDeleteForEveryone(message));
assert.isTrue(canDeleteForEveryone(message, isMe));
});
});