mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Improve message download performance

Browse source
This commit is contained in:
Scott Nonnenberg 2019-09-26 12:56:31 -07:00
parent 957f6f6474
commit 0c09f9620f
32 changed files with 906 additions and 633 deletions
Download patch file Download diff file Expand all files Collapse all files

29
js/read_syncs.js
View file

@ -41,23 +41,14 @@
const notificationForMessage = found
? Whisper.Notifications.findWhere({ messageId: found.id })
: null;
const removedNotification = Whisper.Notifications.remove(
notificationForMessage
);
const receiptSender = receipt.get('sender');
const receiptTimestamp = receipt.get('timestamp');
const wasMessageFound = Boolean(found);
const wasNotificationFound = Boolean(notificationForMessage);
const wasNotificationRemoved = Boolean(removedNotification);
window.log.info('Receive read sync:', {
receiptSender,
receiptTimestamp,
wasMessageFound,
wasNotificationFound,
wasNotificationRemoved,
});
Whisper.Notifications.remove(notificationForMessage);
if (!found) {
window.log.info(
'No message for read sync',
receipt.get('sender'),
receipt.get('timestamp')
);
return;
}
@ -68,7 +59,7 @@
// timer to the time specified by the read sync if it's earlier than
// the previous read time.
if (message.isUnread()) {
await message.markRead(readAt);
await message.markRead(readAt, { skipSave: true });
// onReadMessage may result in messages older than this one being
// marked read. We want those messages to have the same expire timer
@ -87,7 +78,7 @@
message.set({ expirationStartTimestamp });
const force = true;
await message.setToExpire(force);
await message.setToExpire(force, { skipSave: true });
const conversation = message.getConversation();
if (conversation) {
@ -95,6 +86,10 @@
}
}
await window.Signal.Data.saveMessage(message.attributes, {
Message: Whisper.Message,
});
this.remove(receipt);
} catch (error) {
window.log.error(