mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Add workaround for fullscreen debug log causing unresponsive app

Browse source
This commit is contained in:
Evan Hahn 2022-01-07 09:30:47 -06:00 • committed by GitHub
parent e741b7820a
commit 09af7eeece
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/main.ts
View file

@ -1186,6 +1186,11 @@ async function showDebugLogWindow() {
nativeWindowOpen: true, nativeWindowOpen: true,
}, },
parent: mainWindow, parent: mainWindow,
// Electron has [a macOS bug][0] that causes parent windows to become unresponsive if
// it's fullscreen and opens a fullscreen child window. Until that's fixed, we
// prevent the child window from being fullscreenable, which sidesteps the problem.
// [0]: https://github.com/electron/electron/issues/32374
fullscreenable: !OS.isMacOS(),
}; };
debugLogWindow = createBrowserWindow(options); debugLogWindow = createBrowserWindow(options);
@ -1203,6 +1208,9 @@ async function showDebugLogWindow() {
debugLogWindow.once('ready-to-show', () => { debugLogWindow.once('ready-to-show', () => {
if (debugLogWindow) { if (debugLogWindow) {
debugLogWindow.show(); debugLogWindow.show();
// Electron sometimes puts the window in a strange spot until it's shown.
debugLogWindow.center();
} }
}); });
} }