mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Migrate sessions table to BLOB column

Browse source 
Co-authored-by: Scott Nonnenberg <scott@signal.org>
This commit is contained in:
Fedor Indutny 2024-10-02 17:23:00 -07:00 • committed by GitHub
parent a4d8ba4899
commit 091580825a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 582 additions and 275 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ts/test-node/sql/helpers.ts
View file

@ -74,6 +74,10 @@ export function getTableData(db: ReadableDB, table: string): TableRows {
if (value == null) {
continue;
}
if (Buffer.isBuffer(value)) {
result[key] = value.toString('hex');
continue;
}
try {
if (typeof value !== 'string') {
throw new Error('skip');

153
ts/test-node/sql/migration_1220_test.ts Normal file
View file

@ -0,0 +1,153 @@
// Copyright 2024 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
import { assert } from 'chai';
import { type WritableDB } from '../../sql/Interface';
import {
sessionRecordToProtobuf,
sessionStructureToBytes,
} from '../../util/sessionTranslation';
import { createDB, updateToVersion, insertData, getTableData } from './helpers';
import { SESSION_V1_RECORD } from '../../test-both/util/sessionTranslation_test';
const MAPS = [
{
id: 'identityKeyMap',
json: {
id: 'identityKeyMap',
value: {
ourAci: {
privKey: 'AAAA',
pubKey: 'AAAA',
},
},
},
},
{
id: 'registrationIdMap',
json: {
id: 'registrationIdMap',
value: {
ourAci: 123,
},
},
},
];
const SESSION_V2 = {
id: 'ourAci:theirAci',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
json: {
id: 'ourAci:theirAci',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
version: 2,
deviceId: 3,
record: Buffer.from('abc').toString('base64'),
},
};
describe('SQL/updateToSchemaVersion1220', () => {
let db: WritableDB;
afterEach(() => {
db.close();
});
beforeEach(() => {
db = createDB();
updateToVersion(db, 1210);
});
it('drops sessions without identity key/registration id', () => {
insertData(db, 'sessions', [SESSION_V2]);
updateToVersion(db, 1220);
assert.deepStrictEqual(getTableData(db, 'sessions'), []);
});
it('migrates v1 session', () => {
insertData(db, 'items', MAPS);
insertData(db, 'sessions', [
{
id: 'ourAci:theirAci',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
json: {
id: 'ourAci:theirAci',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
version: 1,
deviceId: 3,
record: JSON.stringify(SESSION_V1_RECORD),
},
},
]);
updateToVersion(db, 1220);
const bytes = sessionStructureToBytes(
sessionRecordToProtobuf(SESSION_V1_RECORD, {
identityKeyPublic: Buffer.from('AAAA', 'base64'),
registrationId: 123,
})
);
assert.deepStrictEqual(getTableData(db, 'sessions'), [
{
id: 'ourAci:theirAci',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
deviceId: 3,
record: Buffer.from(bytes).toString('hex'),
},
]);
});
it('migrates v2 session', () => {
insertData(db, 'items', MAPS);
insertData(db, 'sessions', [SESSION_V2]);
updateToVersion(db, 1220);
assert.deepStrictEqual(getTableData(db, 'sessions'), [
{
id: 'ourAci:theirAci',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
deviceId: 3,
record: Buffer.from('abc').toString('hex'),
},
]);
});
it('drops invalid sessions', () => {
insertData(db, 'items', MAPS);
insertData(db, 'sessions', [
{
id: 'ourAci:theirAci',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
json: {
id: 'ourAci:theirAci2',
conversationId: 'cid',
ourServiceId: 'ourAci',
serviceId: 'theirAci',
version: 1,
deviceId: 3,
record: 'abc',
},
},
]);
updateToVersion(db, 1220);
assert.deepStrictEqual(getTableData(db, 'sessions'), []);
});
});