mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Attachment downloads: Use filename if we have it, ignore index = 1

Browse source
This commit is contained in:
Scott Nonnenberg 2022-07-08 16:10:16 -07:00 • committed by GitHub
parent 1dc27a6144
commit 0888b57744
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 43 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

37
ts/test-node/types/Attachment_test.ts
View file

@ -62,7 +62,25 @@ describe('Attachment', () => {
});
});
context('for attachment with index', () => {
it('should generate a filename based on timestamp', () => {
it('should use filename if provided', () => {
const attachment: Attachment.AttachmentType = fakeAttachment({
fileName: 'funny-cat.mov',
data: Bytes.fromString('foo'),
contentType: MIME.VIDEO_QUICKTIME,
});
const timestamp = new Date(
DAY + new Date(DAY).getTimezoneOffset() * 60 * 1000
);
const actual = Attachment.getSuggestedFilename({
attachment,
timestamp,
index: 3,
});
const expected = 'funny-cat.mov';
assert.strictEqual(actual, expected);
});
it('should use provided index if > 1 and filename not provided', () => {
const attachment: Attachment.AttachmentType = fakeAttachment({
data: Bytes.fromString('foo'),
contentType: MIME.VIDEO_QUICKTIME,
@ -78,6 +96,23 @@ describe('Attachment', () => {
const expected = 'signal-1970-01-02-000000_003.mov';
assert.strictEqual(actual, expected);
});
it('should not use provided index == 1 if filename not provided', () => {
const attachment: Attachment.AttachmentType = fakeAttachment({
data: Bytes.fromString('foo'),
contentType: MIME.VIDEO_QUICKTIME,
});
const timestamp = new Date(
DAY + new Date(DAY).getTimezoneOffset() * 60 * 1000
);
const actual = Attachment.getSuggestedFilename({
attachment,
timestamp,
index: 1,
});
const expected = 'signal-1970-01-02-000000.mov';
assert.strictEqual(actual, expected);
});
});
});