From 048e1e4cd705b5b7dba7e176ab97feac593072ee Mon Sep 17 00:00:00 2001
From: Josh Perez <60019601+josh-signal@users.noreply.github.com>
Date: Wed, 6 Oct 2021 16:27:14 -0400
Subject: [PATCH] Move the safety number viewer into modal

---
 _locales/en/messages.json                     |  6 ++-
 background.html                               | 10 -----
 js/views/key_verification_view.js             | 37 ---------------
 .../components/SafetyNumberViewer.scss        | 45 +++++++------------
 test/index.html                               | 11 -----
 ts/components/GlobalModalContainer.tsx        | 10 +++++
 ts/components/SafetyNumberModal.tsx           | 31 +++++++++++++
 ts/components/SafetyNumberViewer.stories.tsx  | 16 -------
 ts/components/SafetyNumberViewer.tsx          | 32 +++----------
 ts/state/ducks/globalModals.ts                | 27 ++++++++++-
 ts/state/smart/GlobalModalContainer.tsx       |  6 +++
 ts/state/smart/SafetyNumberModal.tsx          | 27 +++++++++++
 ts/util/lint/exceptions.json                  | 34 +-------------
 ts/views/conversation_view.ts                 |  7 ++-
 14 files changed, 132 insertions(+), 167 deletions(-)
 delete mode 100644 js/views/key_verification_view.js
 create mode 100644 ts/components/SafetyNumberModal.tsx
 create mode 100644 ts/state/smart/SafetyNumberModal.tsx

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index 2002fb526d5..d959ae6a593 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -1123,7 +1123,7 @@
     "description": "This is a menu item for viewing all media (images + video) in a conversation, using the imperative case, as in a command."
   },
   "verifyHelp": {
-    "message": "If you wish to verify the security of your end-to-end encryption with $name$, compare the numbers above with the numbers on their device.",
+    "message": "To verify the security of your end-to-end encryption with $name$, compare the numbers above with their device.",
     "placeholders": {
       "name": {
         "content": "$1",
@@ -2148,6 +2148,10 @@
       }
     }
   },
+  "SafetyNumberModal__title": {
+    "message": "Verify Safety Number",
+    "description": "Title for the modal for safety number verification"
+  },
   "safetyNumberChanged": {
     "message": "Safety Number has changed",
     "description": "A notification shown in the conversation when a contact reinstalls"
diff --git a/background.html b/background.html
index a4995ccb352..dec14ed2bdf 100644
--- a/background.html
+++ b/background.html
@@ -106,12 +106,6 @@
       </div>
     </script>
 
-    <script type="text/x-tmpl-mustache" id="key-verification">
-      <div class="container" tabindex="0">
-        <div class="key-verification-wrapper"></div>
-      </div>
-    </script>
-
     <script type="text/x-tmpl-mustache" id="link-flow-template">
       <div class='module-title-bar-drag-area'></div>
 
@@ -267,10 +261,6 @@
       type="text/javascript"
       src="js/views/react_wrapper_view.js"
     ></script>
-    <script
-      type="text/javascript"
-      src="js/views/key_verification_view.js"
-    ></script>
     <script
       type="text/javascript"
       src="ts/shims/showConfirmationDialog.js"
diff --git a/js/views/key_verification_view.js b/js/views/key_verification_view.js
deleted file mode 100644
index d5c49a68e7e..00000000000
--- a/js/views/key_verification_view.js
+++ /dev/null
@@ -1,37 +0,0 @@
-// Copyright 2015-2020 Signal Messenger, LLC
-// SPDX-License-Identifier: AGPL-3.0-only
-
-/* global Backbone, Signal, Whisper, $ */
-
-// eslint-disable-next-line func-names
-(function () {
-  window.Whisper = window.Whisper || {};
-
-  Whisper.KeyVerificationPanelView = Whisper.View.extend({
-    className: 'panel',
-    template: () => $('#key-verification').html(),
-    initialize(options) {
-      this.render();
-
-      this.view = new Whisper.ReactWrapperView({
-        JSX: Signal.State.Roots.createSafetyNumberViewer(window.reduxStore, {
-          contactID: options.model.get('id'),
-        }),
-        onInitialRender: () => {
-          if (options.onLoad) {
-            options.onLoad(this);
-          }
-        },
-      });
-
-      this.$('.key-verification-wrapper').append(this.view.el);
-    },
-
-    remove() {
-      if (this.view) {
-        this.view.remove();
-      }
-      Backbone.View.prototype.remove.call(this);
-    },
-  });
-})();
diff --git a/stylesheets/components/SafetyNumberViewer.scss b/stylesheets/components/SafetyNumberViewer.scss
index 53abdede544..beaf9f73410 100644
--- a/stylesheets/components/SafetyNumberViewer.scss
+++ b/stylesheets/components/SafetyNumberViewer.scss
@@ -2,6 +2,8 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 .module-SafetyNumberViewer {
+  text-align: center;
+
   &__icon {
     height: 1.25em;
     width: 1.25em;
@@ -9,10 +11,6 @@
     display: inline-block;
   }
 
-  &__verification-label {
-    margin: 10px 0;
-  }
-
   &__icon--verified {
     display: inline-block;
     height: 1.25em;
@@ -55,33 +53,14 @@
     }
   }
 
-  &__verify-container {
-    text-align: center;
-  }
-
-  &__button--verify {
-    border-radius: 5px;
-    font-weight: bold;
-    margin: 0;
-    outline: none;
-    padding: 10px;
-  }
-
   &__number {
-    background: #f6f6f6;
-    border-radius: 5px;
-    border: solid 1px #dedede;
+    background: $color-gray-02;
+    border-radius: 8px;
     font-family: monospace;
-    margin: 20px auto 20px auto;
-    padding: 10px;
-    text-align: center;
-    width: 16em;
-
-    @include dark-theme {
-      background: #1b1b1b;
-      border: solid 1px #848484;
-      color: #f6f6f6;
-    }
+    height: 100px;
+    margin: 24px auto;
+    padding: 24px;
+    width: 240px;
   }
 
   &__verification-status {
@@ -119,4 +98,12 @@
       }
     }
   }
+
+  &__button {
+    margin-top: 30px;
+  }
+
+  &__modal.module-Modal {
+    max-width: 500px;
+  }
 }
diff --git a/test/index.html b/test/index.html
index 41df47bf4d0..74e142cd7c0 100644
--- a/test/index.html
+++ b/test/index.html
@@ -79,12 +79,6 @@
       </div>
     </script>
 
-    <script type="text/x-tmpl-mustache" id="key-verification">
-      <div class="container" tabindex="0">
-        <div class="key-verification-wrapper"></div>
-      </div>
-    </script>
-
     <script type="text/x-tmpl-mustache" id="link-flow-template">
       <div class='module-title-bar-drag-area'></div>
 
@@ -263,11 +257,6 @@
       src="../js/views/contact_list_view.js"
       data-cover
     ></script>
-    <script
-      type="text/javascript"
-      src="../js/views/key_verification_view.js"
-      data-cover
-    ></script>
     <script
       type="text/javascript"
       src="../js/views/group_member_list_view.js"
diff --git a/ts/components/GlobalModalContainer.tsx b/ts/components/GlobalModalContainer.tsx
index 4af93c8b909..6047c160dc3 100644
--- a/ts/components/GlobalModalContainer.tsx
+++ b/ts/components/GlobalModalContainer.tsx
@@ -10,6 +10,9 @@ type PropsType = {
   // ProfileEditor
   isProfileEditorVisible: boolean;
   renderProfileEditor: () => JSX.Element;
+  // SafetyNumberModal
+  safetyNumberModalContactId?: string;
+  renderSafetyNumber: () => JSX.Element;
 };
 
 export const GlobalModalContainer = ({
@@ -19,7 +22,14 @@ export const GlobalModalContainer = ({
   // ProfileEditor
   isProfileEditorVisible,
   renderProfileEditor,
+  // SafetyNumberModal
+  safetyNumberModalContactId,
+  renderSafetyNumber,
 }: PropsType): JSX.Element | null => {
+  if (safetyNumberModalContactId) {
+    return renderSafetyNumber();
+  }
+
   if (contactModalState) {
     return renderContactModal();
   }
diff --git a/ts/components/SafetyNumberModal.tsx b/ts/components/SafetyNumberModal.tsx
new file mode 100644
index 00000000000..5810c7cffc7
--- /dev/null
+++ b/ts/components/SafetyNumberModal.tsx
@@ -0,0 +1,31 @@
+// Copyright 2021 Signal Messenger, LLC
+// SPDX-License-Identifier: AGPL-3.0-only
+
+import React from 'react';
+import { Modal } from './Modal';
+import {
+  SafetyNumberViewer,
+  PropsType as SafetyNumberViewerPropsType,
+} from './SafetyNumberViewer';
+
+type PropsType = {
+  toggleSafetyNumberModal: () => unknown;
+} & SafetyNumberViewerPropsType;
+
+export const SafetyNumberModal = ({
+  i18n,
+  toggleSafetyNumberModal,
+  ...safetyNumberViewerProps
+}: PropsType): JSX.Element | null => {
+  return (
+    <Modal
+      hasXButton
+      i18n={i18n}
+      moduleClassName="module-SafetyNumberViewer__modal"
+      onClose={() => toggleSafetyNumberModal()}
+      title={i18n('SafetyNumberModal__title')}
+    >
+      <SafetyNumberViewer i18n={i18n} {...safetyNumberViewerProps} />
+    </Modal>
+  );
+};
diff --git a/ts/components/SafetyNumberViewer.stories.tsx b/ts/components/SafetyNumberViewer.stories.tsx
index c166932f782..eb6fb0f4dca 100644
--- a/ts/components/SafetyNumberViewer.stories.tsx
+++ b/ts/components/SafetyNumberViewer.stories.tsx
@@ -50,12 +50,6 @@ const createProps = (overrideProps: Partial<PropsType> = {}): PropsType => ({
   generateSafetyNumber: action('generate-safety-number'),
   i18n,
   safetyNumber: text('safetyNumber', overrideProps.safetyNumber || 'XXX'),
-  safetyNumberChanged: boolean(
-    'safetyNumberChanged',
-    overrideProps.safetyNumberChanged !== undefined
-      ? overrideProps.safetyNumberChanged
-      : false
-  ),
   toggleVerified: action('toggle-verified'),
   verificationDisabled: boolean(
     'verificationDisabled',
@@ -95,16 +89,6 @@ story.add('Verification Disabled', () => {
   );
 });
 
-story.add('Safety Number Changed', () => {
-  return (
-    <SafetyNumberViewer
-      {...createProps({
-        safetyNumberChanged: true,
-      })}
-    />
-  );
-});
-
 story.add('Safety Number (dialog close)', () => {
   return (
     <SafetyNumberViewer
diff --git a/ts/components/SafetyNumberViewer.tsx b/ts/components/SafetyNumberViewer.tsx
index 4b339bd856f..cea72f70d00 100644
--- a/ts/components/SafetyNumberViewer.tsx
+++ b/ts/components/SafetyNumberViewer.tsx
@@ -2,9 +2,10 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 import React from 'react';
+import { Button, ButtonVariant } from './Button';
 import { ConversationType } from '../state/ducks/conversations';
-import { LocalizerType } from '../types/Util';
 import { Intl } from './Intl';
+import { LocalizerType } from '../types/Util';
 
 export type PropsType = {
   contact?: ConversationType;
@@ -12,7 +13,6 @@ export type PropsType = {
   i18n: LocalizerType;
   onClose?: () => void;
   safetyNumber: string;
-  safetyNumberChanged?: boolean;
   toggleVerified: (contact: ConversationType) => void;
   verificationDisabled: boolean;
 };
@@ -23,7 +23,6 @@ export const SafetyNumberViewer = ({
   i18n,
   onClose,
   safetyNumber,
-  safetyNumberChanged,
   toggleVerified,
   verificationDisabled,
 }: PropsType): JSX.Element | null => {
@@ -42,9 +41,7 @@ export const SafetyNumberViewer = ({
   if (!contact.phoneNumber) {
     return (
       <div className="module-SafetyNumberViewer">
-        <div className="module-SafetyNumberViewer__verify-container">
-          {i18n('cannotGenerateSafetyNumber')}
-        </div>
+        {i18n('cannotGenerateSafetyNumber')}
       </div>
     );
   }
@@ -59,9 +56,6 @@ export const SafetyNumberViewer = ({
 
   const { isVerified } = contact;
   const verifiedStatusKey = isVerified ? 'isVerified' : 'isNotVerified';
-  const safetyNumberChangedKey = safetyNumberChanged
-    ? 'changedRightAfterVerify'
-    : 'yourSafetyNumberWith';
   const verifyButtonText = isVerified ? i18n('unverify') : i18n('verify');
 
   return (
@@ -73,16 +67,6 @@ export const SafetyNumberViewer = ({
           </button>
         </div>
       )}
-      <div className="module-SafetyNumberViewer__verification-label">
-        <Intl
-          i18n={i18n}
-          id={safetyNumberChangedKey}
-          components={{
-            name1: boldName,
-            name2: boldName,
-          }}
-        />
-      </div>
       <div className="module-SafetyNumberViewer__number">
         {safetyNumber || getPlaceholder()}
       </div>
@@ -95,18 +79,16 @@ export const SafetyNumberViewer = ({
         )}
         <Intl i18n={i18n} id={verifiedStatusKey} components={[boldName]} />
       </div>
-      <div className="module-SafetyNumberViewer__verify-container">
-        <button
-          className="module-SafetyNumberViewer__button--verify"
+      <div className="module-SafetyNumberViewer__button">
+        <Button
           disabled={verificationDisabled}
           onClick={() => {
             toggleVerified(contact);
           }}
-          tabIndex={0}
-          type="button"
+          variant={ButtonVariant.Secondary}
         >
           {verifyButtonText}
-        </button>
+        </Button>
       </div>
     </div>
   );
diff --git a/ts/state/ducks/globalModals.ts b/ts/state/ducks/globalModals.ts
index 4a2bb652229..367bfc773ac 100644
--- a/ts/state/ducks/globalModals.ts
+++ b/ts/state/ducks/globalModals.ts
@@ -7,6 +7,7 @@ export type GlobalModalsStateType = {
   readonly contactModalState?: ContactModalStateType;
   readonly isProfileEditorVisible: boolean;
   readonly profileEditorHasError: boolean;
+  readonly safetyNumberModalContactId?: string;
 };
 
 // Actions
@@ -16,6 +17,7 @@ const SHOW_CONTACT_MODAL = 'globalModals/SHOW_CONTACT_MODAL';
 const TOGGLE_PROFILE_EDITOR = 'globalModals/TOGGLE_PROFILE_EDITOR';
 export const TOGGLE_PROFILE_EDITOR_ERROR =
   'globalModals/TOGGLE_PROFILE_EDITOR_ERROR';
+const TOGGLE_SAFETY_NUMBER_MODAL = 'globalModals/TOGGLE_SAFETY_NUMBER_MODAL';
 
 export type ContactModalStateType = {
   contactId: string;
@@ -39,11 +41,17 @@ export type ToggleProfileEditorErrorActionType = {
   type: typeof TOGGLE_PROFILE_EDITOR_ERROR;
 };
 
+type ToggleSafetyNumberModalActionType = {
+  type: typeof TOGGLE_SAFETY_NUMBER_MODAL;
+  payload: string | undefined;
+};
+
 export type GlobalModalsActionType =
   | HideContactModalActionType
   | ShowContactModalActionType
   | ToggleProfileEditorActionType
-  | ToggleProfileEditorErrorActionType;
+  | ToggleProfileEditorErrorActionType
+  | ToggleSafetyNumberModalActionType;
 
 // Action Creators
 
@@ -52,6 +60,7 @@ export const actions = {
   showContactModal,
   toggleProfileEditor,
   toggleProfileEditorHasError,
+  toggleSafetyNumberModal,
 };
 
 function hideContactModal(): HideContactModalActionType {
@@ -81,6 +90,15 @@ function toggleProfileEditorHasError(): ToggleProfileEditorErrorActionType {
   return { type: TOGGLE_PROFILE_EDITOR_ERROR };
 }
 
+function toggleSafetyNumberModal(
+  safetyNumberModalContactId?: string
+): ToggleSafetyNumberModalActionType {
+  return {
+    type: TOGGLE_SAFETY_NUMBER_MODAL,
+    payload: safetyNumberModalContactId,
+  };
+}
+
 // Reducer
 
 export function getEmptyState(): GlobalModalsStateType {
@@ -122,5 +140,12 @@ export function reducer(
     };
   }
 
+  if (action.type === TOGGLE_SAFETY_NUMBER_MODAL) {
+    return {
+      ...state,
+      safetyNumberModalContactId: action.payload,
+    };
+  }
+
   return state;
 }
diff --git a/ts/state/smart/GlobalModalContainer.tsx b/ts/state/smart/GlobalModalContainer.tsx
index 18be838f8c4..03d5277ed58 100644
--- a/ts/state/smart/GlobalModalContainer.tsx
+++ b/ts/state/smart/GlobalModalContainer.tsx
@@ -8,6 +8,7 @@ import { GlobalModalContainer } from '../../components/GlobalModalContainer';
 import { StateType } from '../reducer';
 import { SmartProfileEditorModal } from './ProfileEditorModal';
 import { SmartContactModal } from './ContactModal';
+import { SmartSafetyNumberModal } from './SafetyNumberModal';
 
 const FilteredSmartProfileEditorModal = SmartProfileEditorModal;
 
@@ -24,6 +25,11 @@ const mapStateToProps = (state: StateType) => {
     ...state.globalModals,
     renderContactModal,
     renderProfileEditor,
+    renderSafetyNumber: () => (
+      <SmartSafetyNumberModal
+        contactID={String(state.globalModals.safetyNumberModalContactId)}
+      />
+    ),
   };
 };
 
diff --git a/ts/state/smart/SafetyNumberModal.tsx b/ts/state/smart/SafetyNumberModal.tsx
new file mode 100644
index 00000000000..3ffa0362444
--- /dev/null
+++ b/ts/state/smart/SafetyNumberModal.tsx
@@ -0,0 +1,27 @@
+// Copyright 2020 Signal Messenger, LLC
+// SPDX-License-Identifier: AGPL-3.0-only
+
+import { connect } from 'react-redux';
+import { mapDispatchToProps } from '../actions';
+import { SafetyNumberModal } from '../../components/SafetyNumberModal';
+import { StateType } from '../reducer';
+import { getContactSafetyNumber } from '../selectors/safetyNumber';
+import { getConversationSelector } from '../selectors/conversations';
+import { getIntl } from '../selectors/user';
+
+export type Props = {
+  contactID: string;
+};
+
+const mapStateToProps = (state: StateType, props: Props) => {
+  return {
+    ...props,
+    ...getContactSafetyNumber(state, props),
+    contact: getConversationSelector(state)(props.contactID),
+    i18n: getIntl(state),
+  };
+};
+
+const smart = connect(mapStateToProps, mapDispatchToProps);
+
+export const SmartSafetyNumberModal = smart(SafetyNumberModal);
diff --git a/ts/util/lint/exceptions.json b/ts/util/lint/exceptions.json
index 3918833cfc5..efb3bfc7999 100644
--- a/ts/util/lint/exceptions.json
+++ b/ts/util/lint/exceptions.json
@@ -106,38 +106,6 @@
     "updated": "2018-09-18T19:19:27.699Z",
     "reasonDetail": "Very limited in what HTML can be injected - dark/light options specify colors for the light/dark parts of QRCode"
   },
-  {
-    "rule": "jQuery-$(",
-    "path": "js/views/key_verification_view.js",
-    "line": "      this.$('.key-verification-wrapper').append(this.view.el);",
-    "reasonCategory": "usageTrusted",
-    "updated": "2021-02-26T18:44:56.450Z",
-    "reasonDetail": "Adding sub-view to DOM"
-  },
-  {
-    "rule": "jQuery-$(",
-    "path": "js/views/key_verification_view.js",
-    "line": "    template: () => $('#key-verification').html(),",
-    "reasonCategory": "usageTrusted",
-    "updated": "2021-02-26T18:44:56.450Z",
-    "reasonDetail": "Static selector, read-only access"
-  },
-  {
-    "rule": "jQuery-append(",
-    "path": "js/views/key_verification_view.js",
-    "line": "      this.$('.key-verification-wrapper').append(this.view.el);",
-    "reasonCategory": "usageTrusted",
-    "updated": "2021-02-26T18:44:56.450Z",
-    "reasonDetail": "Adding sub-view to DOM"
-  },
-  {
-    "rule": "jQuery-html(",
-    "path": "js/views/key_verification_view.js",
-    "line": "    template: () => $('#key-verification').html(),",
-    "reasonCategory": "usageTrusted",
-    "updated": "2021-02-26T18:44:56.450Z",
-    "reasonDetail": "Static selector, read-only access"
-  },
   {
     "rule": "jQuery-wrap(",
     "path": "node_modules/@chanzuckerberg/axe-storybook-testing/node_modules/ansi-styles/index.js",
@@ -14101,4 +14069,4 @@
     "reasonCategory": "usageTrusted",
     "updated": "2021-09-17T21:02:59.414Z"
   }
-]
\ No newline at end of file
+]
diff --git a/ts/views/conversation_view.ts b/ts/views/conversation_view.ts
index 1b07f370a7e..507227970b5 100644
--- a/ts/views/conversation_view.ts
+++ b/ts/views/conversation_view.ts
@@ -2125,10 +2125,9 @@ export class ConversationView extends window.Backbone.View<ConversationModel> {
       conversation = window.ConversationController.get(id);
     }
     if (conversation) {
-      const view = new Whisper.KeyVerificationPanelView({
-        model: conversation,
-      });
-      this.listenBack(view);
+      window.reduxActions.globalModals.toggleSafetyNumberModal(
+        conversation.get('id')
+      );
     }
   }