Remove CDS feature flag

This commit is contained in:
Evan Hahn 2021-04-26 13:15:00 -05:00 committed by Scott Nonnenberg
parent e77dcf7f85
commit 013923d3c1
3 changed files with 67 additions and 73 deletions

View file

@ -1,11 +1,10 @@
// Copyright 2020 Signal Messenger, LLC // Copyright 2020-2021 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only // SPDX-License-Identifier: AGPL-3.0-only
import { get, throttle } from 'lodash'; import { get, throttle } from 'lodash';
import { WebAPIType } from './textsecure/WebAPI'; import { WebAPIType } from './textsecure/WebAPI';
export type ConfigKeyType = export type ConfigKeyType =
| 'desktop.cds'
| 'desktop.clientExpiration' | 'desktop.clientExpiration'
| 'desktop.disableGV1' | 'desktop.disableGV1'
| 'desktop.groupCalling' | 'desktop.groupCalling'

View file

@ -1755,7 +1755,6 @@ export async function startApp(): Promise<void> {
} }
try { try {
if (window.Signal.RemoteConfig.isEnabled('desktop.cds')) {
const lonelyE164s = window const lonelyE164s = window
.getConversations() .getConversations()
.filter(c => .filter(c =>
@ -1789,7 +1788,6 @@ export async function startApp(): Promise<void> {
}); });
}); });
} }
}
} catch (error) { } catch (error) {
window.log.error( window.log.error(
'connect: Error fetching UUIDs for lonely e164s:', 'connect: Error fetching UUIDs for lonely e164s:',

View file

@ -23,7 +23,6 @@ import {
} from 'libsignal-client'; } from 'libsignal-client';
import { ServerKeysType, WebAPIType } from './WebAPI'; import { ServerKeysType, WebAPIType } from './WebAPI';
import { isEnabled as isRemoteFlagEnabled } from '../RemoteConfig';
import { ContentClass, DataMessageClass } from '../textsecure.d'; import { ContentClass, DataMessageClass } from '../textsecure.d';
import { import {
CallbackResultType, CallbackResultType,
@ -645,7 +644,6 @@ export default class OutgoingMessage {
async sendToIdentifier(providedIdentifier: string): Promise<void> { async sendToIdentifier(providedIdentifier: string): Promise<void> {
let identifier = providedIdentifier; let identifier = providedIdentifier;
try { try {
if (isRemoteFlagEnabled('desktop.cds')) {
if (window.isValidGuid(identifier)) { if (window.isValidGuid(identifier)) {
// We're good! // We're good!
} else if (isValidNumber(identifier)) { } else if (isValidNumber(identifier)) {
@ -688,7 +686,6 @@ export default class OutgoingMessage {
`sendToIdentifier: identifier ${identifier} was neither a UUID or E164` `sendToIdentifier: identifier ${identifier} was neither a UUID or E164`
); );
} }
}
const updateDevices = await this.getStaleDeviceIdsForIdentifier( const updateDevices = await this.getStaleDeviceIdsForIdentifier(
identifier identifier