mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Improve localized emoji ranking

Browse source 
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
This commit is contained in:
automated-signal 2024-05-06 19:28:44 -05:00 • committed by Scott Nonnenberg
parent b757031f0b
commit 0119478d85
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
ts/components/emoji/lib.ts
View file

@ -254,8 +254,13 @@ export function createSearch(localeEmoji: SearchEmojiListType): SearchFnType {
}
}
let maxShortNameLength = 0;
for (const { shortName } of knownEmoji) {
maxShortNameLength = Math.max(maxShortNameLength, shortName.length);
}
const fuse = new Fuse(knownEmoji, {
shouldSort: true,
shouldSort: false,
threshold: 0.2,
minMatchCharLength: 1,
keys: ['shortName', 'tags'],
@ -263,7 +268,8 @@ export function createSearch(localeEmoji: SearchEmojiListType): SearchFnType {
});
const fuseExactPrefix = new Fuse(knownEmoji, {
shouldSort: true,
// We re-rank and sort manually below
shouldSort: false,
threshold: 0, // effectively a prefix search
minMatchCharLength: 2,
keys: ['shortName', 'tags'],
@ -280,8 +286,17 @@ export function createSearch(localeEmoji: SearchEmojiListType): SearchFnType {
const rankedResults = rawResults.map(entry => {
const rank = entry.item.rank || 1e9;
// Rank exact prefix matches in [0,1] range
if (entry.item.shortName.startsWith(query)) {
return {
score: entry.item.shortName.length / maxShortNameLength,
item: entry.item,
};
}
// Other matches in [1,], ordered by score and rank
return {
score: (entry.score ?? 0) + rank / knownEmoji.length,
score: 1 + (entry.score ?? 0) + rank / knownEmoji.length,
item: entry.item,
};
});