mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Don't linkify when certain unicode formatting characters are present

Browse source
This commit is contained in:
Scott Nonnenberg 2022-03-28 17:28:37 -07:00 • committed by GitHub
parent e62606361d
commit 006de5b1a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 50 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

21
ts/test-node/types/LinkPreview_test.ts
View file

@ -5,6 +5,7 @@ import { assert } from 'chai';
import {
findLinks,
shouldLinkifyMessage,
shouldPreviewHref,
isLinkSneaky,
} from '../../types/LinkPreview';
@ -44,6 +45,26 @@ describe('Link previews', () => {
});
});
describe('#shouldLinkifyMessage;', () => {
it('returns false for strings with directional override characters', () => {
assert.isFalse(shouldLinkifyMessage('\u202c'));
assert.isFalse(shouldLinkifyMessage('\u202d'));
assert.isFalse(shouldLinkifyMessage('\u202e'));
});
it('returns false for strings with unicode drawing characters', () => {
assert.isFalse(shouldLinkifyMessage('\u2500'));
assert.isFalse(shouldLinkifyMessage('\u2588'));
assert.isFalse(shouldLinkifyMessage('\u25FF'));
});
it('returns true other strings', () => {
assert.isTrue(shouldLinkifyMessage(null));
assert.isTrue(shouldLinkifyMessage(undefined));
assert.isTrue(shouldLinkifyMessage('Random other string aqu%C3%AD'));
});
});
describe('#findLinks', () => {
it('returns all links if no caretLocation is provided', () => {
const text =