mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
signal-desktop/.github/PULL_REQUEST_TEMPLATE.md

39 lines
1.9 KiB
Markdown
Raw Normal View History

Remove built assets from repo, updates to docs + GH templates (#1955) * Revamp issue and pull request templates, other docs tweaks `yarn test` now runs all of our tests. * Remove generated files from the repository * Update to new Signal support URL * Prevent the 'Test failed 2 == 1' from test-release in CI * Another attempt to fix grunt test-release on Appveyor * grunt test-release: Fail build if test fails * Lint fix, and move jshint earlier in CI process
2018-01-09 23:31:23 +00:00
<!--
Thanks for contributing to the project!
Please help us keep this project in good shape by going through this checklist.
Replace the empty checkboxes [ ] below with checked ones [X] as they are completed
Remember, you can preview this before saving it.
-->
Update issue and pull request templates Issue template - more explanations and tips - clarify how to fill checkboxes - actual and expected results - remove link to the community forum PR template - clarify how to fill checkboxes - more about tests - add a link to an explanation for BitHub rewards - explain that failing Travis CI build checks are normal Closes #735 // FREEBIE
2016-03-29 20:37:47 +00:00
<!-- You can remove this first section if you have contributed before -->
Remove built assets from repo, updates to docs + GH templates (#1955) * Revamp issue and pull request templates, other docs tweaks `yarn test` now runs all of our tests. * Remove generated files from the repository * Update to new Signal support URL * Prevent the 'Test failed 2 == 1' from test-release in CI * Another attempt to fix grunt test-release on Appveyor * grunt test-release: Fail build if test fails * Lint fix, and move jshint earlier in CI process
2018-01-09 23:31:23 +00:00
### First time contributor checklist:
Add templates for issues and pull requests GitHub recently introduced templates for issues and PRs. These will hopefully improve both. //FREEBIE
2016-02-20 00:35:15 +00:00
use the correct branch since the repo has since changed to main
2023-09-17 01:33:06 +00:00
- [ ] I have read the [README](https://github.com/signalapp/Signal-Desktop/blob/main/README.md) and [Contributor Guidelines](https://github.com/signalapp/Signal-Desktop/blob/main/CONTRIBUTING.md)
Upgrade Prettier
2020-01-08 17:44:54 +00:00
- [ ] I have signed the [Contributor Licence Agreement](https://signal.org/cla/)
Add templates for issues and pull requests GitHub recently introduced templates for issues and PRs. These will hopefully improve both. //FREEBIE
2016-02-20 00:35:15 +00:00
Remove built assets from repo, updates to docs + GH templates (#1955) * Revamp issue and pull request templates, other docs tweaks `yarn test` now runs all of our tests. * Remove generated files from the repository * Update to new Signal support URL * Prevent the 'Test failed 2 == 1' from test-release in CI * Another attempt to fix grunt test-release on Appveyor * grunt test-release: Fail build if test fails * Lint fix, and move jshint earlier in CI process
2018-01-09 23:31:23 +00:00
### Contributor checklist:
Remove call for public translations
2022-07-20 16:19:30 +00:00
- [ ] My contribution is **not** related to translations.
Upgrade Prettier
2020-01-08 17:44:54 +00:00
- [ ] My commits are in nice logical chunks with [good commit messages](http://chris.beams.io/posts/git-commit/)
Prepare for branch move: development -> main
2022-04-25 22:53:31 +00:00
- [ ] My changes are [rebased](https://medium.com/free-code-camp/git-rebase-and-the-golden-rule-explained-70715eccc372) on the latest [`main`](https://github.com/signalapp/Signal-Desktop/tree/main) branch
use the correct branch since the repo has since changed to main
2023-09-17 01:33:06 +00:00
- [ ] A `yarn ready` run passes successfully ([more about tests here](https://github.com/signalapp/Signal-Desktop/blob/main/CONTRIBUTING.md#tests))
Upgrade Prettier
2020-01-08 17:44:54 +00:00
- [ ] My changes are ready to be shipped to users
Add templates for issues and pull requests GitHub recently introduced templates for issues and PRs. These will hopefully improve both. //FREEBIE
2016-02-20 00:35:15 +00:00
### Description
Remove built assets from repo, updates to docs + GH templates (#1955) * Revamp issue and pull request templates, other docs tweaks `yarn test` now runs all of our tests. * Remove generated files from the repository * Update to new Signal support URL * Prevent the 'Test failed 2 == 1' from test-release in CI * Another attempt to fix grunt test-release on Appveyor * grunt test-release: Fail build if test fails * Lint fix, and move jshint earlier in CI process
2018-01-09 23:31:23 +00:00
Update issue and pull request templates Issue template - more explanations and tips - clarify how to fill checkboxes - actual and expected results - remove link to the community forum PR template - clarify how to fill checkboxes - more about tests - add a link to an explanation for BitHub rewards - explain that failing Travis CI build checks are normal Closes #735 // FREEBIE
2016-03-29 20:37:47 +00:00
<!--
Remove built assets from repo, updates to docs + GH templates (#1955) * Revamp issue and pull request templates, other docs tweaks `yarn test` now runs all of our tests. * Remove generated files from the repository * Update to new Signal support URL * Prevent the 'Test failed 2 == 1' from test-release in CI * Another attempt to fix grunt test-release on Appveyor * grunt test-release: Fail build if test fails * Lint fix, and move jshint earlier in CI process
2018-01-09 23:31:23 +00:00
Describe briefly what your pull request changes. Focus on the value provided to users.
Does it address any outstanding issues in this project?
Minor documentation cleanup - bug templates, readme, etc. (#2507)
2018-07-05 18:23:29 +00:00
https://github.com/signalapp/Signal-Desktop/issues?utf8=%E2%9C%93&q=is%3Aissue
Remove built assets from repo, updates to docs + GH templates (#1955) * Revamp issue and pull request templates, other docs tweaks `yarn test` now runs all of our tests. * Remove generated files from the repository * Update to new Signal support URL * Prevent the 'Test failed 2 == 1' from test-release in CI * Another attempt to fix grunt test-release on Appveyor * grunt test-release: Fail build if test fails * Lint fix, and move jshint earlier in CI process
2018-01-09 23:31:23 +00:00
Reference an issue with the hash symbol: "#222"
If you're fixing it, use something like "Fixes #222"
Update issue and pull request templates Issue template - more explanations and tips - clarify how to fill checkboxes - actual and expected results - remove link to the community forum PR template - clarify how to fill checkboxes - more about tests - add a link to an explanation for BitHub rewards - explain that failing Travis CI build checks are normal Closes #735 // FREEBIE
2016-03-29 20:37:47 +00:00
Remove built assets from repo, updates to docs + GH templates (#1955) * Revamp issue and pull request templates, other docs tweaks `yarn test` now runs all of our tests. * Remove generated files from the repository * Update to new Signal support URL * Prevent the 'Test failed 2 == 1' from test-release in CI * Another attempt to fix grunt test-release on Appveyor * grunt test-release: Fail build if test fails * Lint fix, and move jshint earlier in CI process
2018-01-09 23:31:23 +00:00
Please write a summary of your test approach:
- What kind of manual testing did you do?
- Did you write any new tests?
- What operating systems did you test with? (please use specific versions: http://whatsmyos.com/)
- What other devices did you test with? (other Desktop devices, Android, Android Simulator, iOS, iOS Simulator)
Update issue and pull request templates Issue template - more explanations and tips - clarify how to fill checkboxes - actual and expected results - remove link to the community forum PR template - clarify how to fill checkboxes - more about tests - add a link to an explanation for BitHub rewards - explain that failing Travis CI build checks are normal Closes #735 // FREEBIE
2016-03-29 20:37:47 +00:00
-->
Reference in a new issue Copy permalink