2022-07-08 20:46:25 +00:00
|
|
|
// Copyright 2022 Signal Messenger, LLC
|
|
|
|
// SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
|
|
|
|
import { assert } from 'chai';
|
|
|
|
import type { Group } from '@signalapp/mock-server';
|
2023-08-16 20:54:39 +00:00
|
|
|
import { Proto, ServiceIdKind } from '@signalapp/mock-server';
|
2022-07-08 20:46:25 +00:00
|
|
|
import createDebug from 'debug';
|
|
|
|
|
|
|
|
import * as durations from '../../util/durations';
|
|
|
|
import { Bootstrap } from '../bootstrap';
|
|
|
|
import type { App } from '../bootstrap';
|
|
|
|
|
|
|
|
export const debug = createDebug('mock:test:gv2');
|
|
|
|
|
2022-09-21 16:18:48 +00:00
|
|
|
describe('pnp/accept gv2 invite', function needsName() {
|
2022-07-08 20:46:25 +00:00
|
|
|
this.timeout(durations.MINUTE);
|
|
|
|
|
|
|
|
let bootstrap: Bootstrap;
|
|
|
|
let app: App;
|
|
|
|
let group: Group;
|
|
|
|
|
|
|
|
beforeEach(async () => {
|
|
|
|
bootstrap = new Bootstrap();
|
|
|
|
await bootstrap.init();
|
|
|
|
|
|
|
|
const { contacts } = bootstrap;
|
|
|
|
|
|
|
|
const [first, second] = contacts;
|
|
|
|
|
|
|
|
group = await first.createGroup({
|
|
|
|
title: 'Invite by PNI',
|
|
|
|
members: [first, second],
|
|
|
|
});
|
|
|
|
|
|
|
|
app = await bootstrap.link();
|
|
|
|
|
|
|
|
const { desktop } = bootstrap;
|
|
|
|
|
|
|
|
group = await first.inviteToGroup(group, desktop, {
|
2023-08-16 20:54:39 +00:00
|
|
|
serviceIdKind: ServiceIdKind.PNI,
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
|
|
|
|
|
|
|
// Verify that created group has pending member
|
|
|
|
assert.strictEqual(group.state?.members?.length, 2);
|
2023-08-16 20:54:39 +00:00
|
|
|
assert(!group.getMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getMemberByServiceId(desktop.pni));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.aci));
|
|
|
|
assert(group.getPendingMemberByServiceId(desktop.pni));
|
2022-07-08 20:46:25 +00:00
|
|
|
|
|
|
|
const window = await app.getWindow();
|
|
|
|
|
2023-07-26 22:23:32 +00:00
|
|
|
const leftPane = window.locator('#LeftPane');
|
2022-07-08 20:46:25 +00:00
|
|
|
|
|
|
|
debug('Opening group');
|
2023-01-13 00:24:59 +00:00
|
|
|
await leftPane.locator(`[data-testid="${group.id}"]`).click();
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(async function after() {
|
2023-07-14 16:53:20 +00:00
|
|
|
await bootstrap.maybeSaveLogs(this.currentTest, app);
|
2022-07-08 20:46:25 +00:00
|
|
|
await app.close();
|
|
|
|
await bootstrap.teardown();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should accept PNI invite and modify the group state', async () => {
|
|
|
|
const { phone, contacts, desktop } = bootstrap;
|
|
|
|
const [first, second] = contacts;
|
|
|
|
|
|
|
|
const window = await app.getWindow();
|
|
|
|
|
2023-07-26 22:23:32 +00:00
|
|
|
const conversationStack = window.locator('.Inbox__conversation-stack');
|
2022-07-08 20:46:25 +00:00
|
|
|
|
|
|
|
debug('Accepting');
|
|
|
|
await conversationStack
|
|
|
|
.locator('.module-message-request-actions button >> "Accept"')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
group = await phone.waitForGroupUpdate(group);
|
|
|
|
assert.strictEqual(group.revision, 2);
|
|
|
|
assert.strictEqual(group.state?.members?.length, 3);
|
2023-08-16 20:54:39 +00:00
|
|
|
assert(group.getMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getMemberByServiceId(desktop.pni));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.pni));
|
2022-07-08 20:46:25 +00:00
|
|
|
|
|
|
|
debug('Checking that notifications are present');
|
|
|
|
await window
|
|
|
|
.locator(`"${first.profileName} invited you to the group."`)
|
|
|
|
.waitFor();
|
|
|
|
await window
|
|
|
|
.locator(
|
|
|
|
`"You accepted an invitation to the group from ${first.profileName}."`
|
|
|
|
)
|
|
|
|
.waitFor();
|
|
|
|
|
|
|
|
debug('Invite PNI again');
|
|
|
|
group = await second.inviteToGroup(group, desktop, {
|
2023-08-16 20:54:39 +00:00
|
|
|
serviceIdKind: ServiceIdKind.PNI,
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
2023-08-16 20:54:39 +00:00
|
|
|
assert(group.getMemberByServiceId(desktop.aci));
|
|
|
|
assert(group.getPendingMemberByServiceId(desktop.pni));
|
2022-07-08 20:46:25 +00:00
|
|
|
|
|
|
|
await window
|
|
|
|
.locator(`"${second.profileName} invited you to the group."`)
|
|
|
|
.waitFor();
|
|
|
|
|
|
|
|
debug('Verify that message request state is not visible');
|
|
|
|
await conversationStack
|
|
|
|
.locator('.module-message-request-actions button >> "Accept"')
|
|
|
|
.waitFor({ state: 'hidden' });
|
|
|
|
|
|
|
|
debug('Leave the group through settings');
|
|
|
|
|
|
|
|
await conversationStack
|
|
|
|
.locator('button.module-ConversationHeader__button--more')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
await conversationStack
|
|
|
|
.locator('.react-contextmenu-item >> "Group settings"')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
await conversationStack
|
|
|
|
.locator('.conversation-details-panel >> "Leave group"')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
await window.locator('.module-Modal button >> "Leave"').click();
|
|
|
|
|
|
|
|
debug('Waiting for final group update');
|
|
|
|
group = await phone.waitForGroupUpdate(group);
|
|
|
|
assert.strictEqual(group.revision, 4);
|
|
|
|
assert.strictEqual(group.state?.members?.length, 2);
|
2023-08-16 20:54:39 +00:00
|
|
|
assert(!group.getMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getMemberByServiceId(desktop.pni));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.aci));
|
|
|
|
assert(group.getPendingMemberByServiceId(desktop.pni));
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
|
|
|
|
|
|
|
it('should decline PNI invite and modify the group state', async () => {
|
|
|
|
const { phone, desktop } = bootstrap;
|
|
|
|
|
|
|
|
const window = await app.getWindow();
|
|
|
|
|
2023-07-26 22:23:32 +00:00
|
|
|
const conversationStack = window.locator('.Inbox__conversation-stack');
|
2022-07-08 20:46:25 +00:00
|
|
|
|
|
|
|
debug('Declining');
|
|
|
|
await conversationStack
|
|
|
|
.locator('.module-message-request-actions button >> "Delete"')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
debug('waiting for confirmation modal');
|
|
|
|
await window.locator('.module-Modal button >> "Delete and Leave"').click();
|
|
|
|
|
|
|
|
group = await phone.waitForGroupUpdate(group);
|
|
|
|
assert.strictEqual(group.revision, 2);
|
|
|
|
assert.strictEqual(group.state?.members?.length, 2);
|
2023-08-16 20:54:39 +00:00
|
|
|
assert(!group.getMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getMemberByServiceId(desktop.pni));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.pni));
|
2023-05-23 23:38:58 +00:00
|
|
|
|
|
|
|
// Verify that sync message was sent.
|
|
|
|
const { syncMessage } = await phone.waitForSyncMessage(entry =>
|
|
|
|
Boolean(entry.syncMessage.sent?.message?.groupV2?.groupChange)
|
|
|
|
);
|
|
|
|
const groupChangeBuffer = syncMessage.sent?.message?.groupV2?.groupChange;
|
|
|
|
assert.notEqual(groupChangeBuffer, null);
|
|
|
|
const groupChange = Proto.GroupChange.decode(
|
|
|
|
groupChangeBuffer ?? new Uint8Array(0)
|
|
|
|
);
|
|
|
|
assert.notEqual(groupChange.actions, null);
|
|
|
|
const actions = Proto.GroupChange.Actions.decode(
|
|
|
|
groupChange?.actions ?? new Uint8Array(0)
|
|
|
|
);
|
|
|
|
assert.strictEqual(actions.deletePendingMembers.length, 1);
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
|
|
|
|
|
|
|
it('should accept ACI invite with extra PNI on the invite list', async () => {
|
|
|
|
const { phone, contacts, desktop } = bootstrap;
|
|
|
|
const [first, second] = contacts;
|
|
|
|
|
|
|
|
const window = await app.getWindow();
|
|
|
|
|
2022-09-01 16:35:44 +00:00
|
|
|
debug('Waiting for the PNI invite');
|
|
|
|
await window
|
|
|
|
.locator(`text=${first.profileName} invited you to the group.`)
|
|
|
|
.waitFor();
|
2022-07-08 20:46:25 +00:00
|
|
|
|
2022-09-01 16:35:44 +00:00
|
|
|
debug('Inviting ACI from another contact');
|
2022-07-08 20:46:25 +00:00
|
|
|
group = await second.inviteToGroup(group, desktop, {
|
2023-08-16 20:54:39 +00:00
|
|
|
serviceIdKind: ServiceIdKind.ACI,
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
|
|
|
|
2023-07-26 22:23:32 +00:00
|
|
|
const conversationStack = window.locator('.Inbox__conversation-stack');
|
2022-07-08 20:46:25 +00:00
|
|
|
|
2022-09-01 16:35:44 +00:00
|
|
|
debug('Waiting for the ACI invite');
|
|
|
|
await window
|
|
|
|
.locator(`text=${second.profileName} invited you to the group.`)
|
|
|
|
.waitFor();
|
|
|
|
|
2022-07-08 20:46:25 +00:00
|
|
|
debug('Accepting');
|
|
|
|
await conversationStack
|
|
|
|
.locator('.module-message-request-actions button >> "Accept"')
|
|
|
|
.click();
|
|
|
|
|
2022-09-01 16:35:44 +00:00
|
|
|
debug('Checking final notification');
|
2022-07-08 20:46:25 +00:00
|
|
|
await window
|
|
|
|
.locator(
|
2023-04-19 16:13:48 +00:00
|
|
|
'.SystemMessage >> text=You accepted an invitation to the group from ' +
|
2022-09-01 16:35:44 +00:00
|
|
|
`${second.profileName}.`
|
2022-07-08 20:46:25 +00:00
|
|
|
)
|
|
|
|
.waitFor();
|
|
|
|
|
|
|
|
group = await phone.waitForGroupUpdate(group);
|
|
|
|
assert.strictEqual(group.revision, 3);
|
|
|
|
assert.strictEqual(group.state?.members?.length, 3);
|
2023-08-16 20:54:39 +00:00
|
|
|
assert(group.getMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getMemberByServiceId(desktop.pni));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.aci));
|
|
|
|
assert(group.getPendingMemberByServiceId(desktop.pni));
|
2022-09-27 20:31:55 +00:00
|
|
|
|
|
|
|
debug('Verifying invite list');
|
|
|
|
await conversationStack
|
|
|
|
.locator('.module-ConversationHeader__header__info__title')
|
|
|
|
.click();
|
|
|
|
await conversationStack
|
|
|
|
.locator(
|
|
|
|
'.ConversationDetails-panel-row__root--button >> ' +
|
|
|
|
'text=Requests & Invites'
|
|
|
|
)
|
|
|
|
.click();
|
|
|
|
await conversationStack
|
2023-05-05 02:48:48 +00:00
|
|
|
.locator('.ConversationDetails__tabs__tab >> text=Invites (1)')
|
2022-09-27 20:31:55 +00:00
|
|
|
.click();
|
|
|
|
await conversationStack
|
|
|
|
.locator(
|
|
|
|
'.ConversationDetails-panel-row__root >> ' +
|
|
|
|
`text=/${first.profileName}.*Invited 1/i`
|
|
|
|
)
|
|
|
|
.waitFor();
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
|
|
|
|
|
|
|
it('should decline ACI invite with extra PNI on the invite list', async () => {
|
|
|
|
const { phone, contacts, desktop } = bootstrap;
|
|
|
|
const [, second] = contacts;
|
|
|
|
|
|
|
|
const window = await app.getWindow();
|
|
|
|
|
|
|
|
debug('Sending another invite');
|
|
|
|
|
|
|
|
// Invite ACI from another contact
|
|
|
|
group = await second.inviteToGroup(group, desktop, {
|
2023-08-16 20:54:39 +00:00
|
|
|
serviceIdKind: ServiceIdKind.ACI,
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
|
|
|
|
2023-07-26 22:23:32 +00:00
|
|
|
const conversationStack = window.locator('.Inbox__conversation-stack');
|
2022-07-08 20:46:25 +00:00
|
|
|
|
|
|
|
debug('Declining');
|
|
|
|
await conversationStack
|
|
|
|
.locator('.module-message-request-actions button >> "Delete"')
|
|
|
|
.click();
|
|
|
|
|
|
|
|
debug('waiting for confirmation modal');
|
|
|
|
await window.locator('.module-Modal button >> "Delete and Leave"').click();
|
|
|
|
|
|
|
|
group = await phone.waitForGroupUpdate(group);
|
|
|
|
assert.strictEqual(group.revision, 3);
|
|
|
|
assert.strictEqual(group.state?.members?.length, 2);
|
2023-08-16 20:54:39 +00:00
|
|
|
assert(!group.getMemberByServiceId(desktop.aci));
|
|
|
|
assert(!group.getMemberByServiceId(desktop.pni));
|
|
|
|
assert(!group.getPendingMemberByServiceId(desktop.aci));
|
|
|
|
assert(group.getPendingMemberByServiceId(desktop.pni));
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|
2023-01-11 01:20:13 +00:00
|
|
|
|
|
|
|
it('should display a single notification for remote PNI accept', async () => {
|
|
|
|
const { phone, contacts, desktop } = bootstrap;
|
|
|
|
|
|
|
|
const [first, second] = contacts;
|
|
|
|
|
|
|
|
debug('Creating new group with Desktop');
|
|
|
|
group = await phone.createGroup({
|
|
|
|
title: 'Remote Invite',
|
|
|
|
members: [phone, first],
|
|
|
|
});
|
|
|
|
|
|
|
|
debug('Inviting remote PNI to group');
|
2023-08-16 20:54:39 +00:00
|
|
|
const secondKey = await second.device.popSingleUseKey(ServiceIdKind.PNI);
|
|
|
|
await first.addSingleUseKey(second.device, secondKey, ServiceIdKind.PNI);
|
2023-01-11 01:20:13 +00:00
|
|
|
|
|
|
|
group = await first.inviteToGroup(group, second.device, {
|
2023-08-16 20:54:39 +00:00
|
|
|
serviceIdKind: ServiceIdKind.PNI,
|
2023-01-11 01:20:13 +00:00
|
|
|
timestamp: bootstrap.getTimestamp(),
|
|
|
|
|
|
|
|
// There is no one to receive it so don't bother.
|
|
|
|
sendInvite: false,
|
|
|
|
});
|
|
|
|
|
|
|
|
debug('Sending message to group');
|
|
|
|
await first.sendText(desktop, 'howdy', {
|
|
|
|
group,
|
|
|
|
timestamp: bootstrap.getTimestamp(),
|
|
|
|
});
|
|
|
|
|
|
|
|
const window = await app.getWindow();
|
2023-07-26 22:23:32 +00:00
|
|
|
const leftPane = window.locator('#LeftPane');
|
2023-01-11 01:20:13 +00:00
|
|
|
|
|
|
|
debug('Opening new group');
|
2023-01-13 00:24:59 +00:00
|
|
|
await leftPane.locator(`[data-testid="${group.id}"]`).click();
|
2023-01-11 01:20:13 +00:00
|
|
|
|
|
|
|
debug('Accepting remote invite');
|
|
|
|
await second.acceptPniInvite(group, desktop, {
|
|
|
|
timestamp: bootstrap.getTimestamp(),
|
|
|
|
});
|
|
|
|
|
|
|
|
await window
|
|
|
|
.locator(
|
|
|
|
'.SystemMessage >> ' +
|
|
|
|
`text=${second.profileName} accepted an invitation to the group ` +
|
|
|
|
`from ${first.profileName}.`
|
|
|
|
)
|
|
|
|
.waitFor();
|
|
|
|
});
|
2022-07-08 20:46:25 +00:00
|
|
|
});
|