signal-desktop/ts/test-both/state/selectors/conversations_test.ts

732 lines
20 KiB
TypeScript
Raw Normal View History

// Copyright 2019-2021 Signal Messenger, LLC
2020-10-30 20:34:04 +00:00
// SPDX-License-Identifier: AGPL-3.0-only
2019-01-14 21:49:58 +00:00
import { assert } from 'chai';
import {
ConversationLookupType,
ConversationType,
getEmptyState,
} from '../../../state/ducks/conversations';
2019-01-14 21:49:58 +00:00
import {
_getConversationComparator,
2019-03-12 00:20:16 +00:00
_getLeftPaneLists,
getComposeContacts,
getComposerContactSearchTerm,
getConversationSelector,
getIsConversationEmptySelector,
getPlaceholderContact,
getSelectedConversation,
getSelectedConversationId,
isComposing,
2019-01-14 21:49:58 +00:00
} from '../../../state/selectors/conversations';
import { noopAction } from '../../../state/ducks/noop';
import { StateType, reducer as rootReducer } from '../../../state/reducer';
import { setup as setupI18n } from '../../../../js/modules/i18n';
import enMessages from '../../../../_locales/en/messages.json';
2019-01-14 21:49:58 +00:00
describe('both/state/selectors/conversations', () => {
const getEmptyRootState = (): StateType => {
return rootReducer(undefined, noopAction());
};
function getDefaultConversation(id: string): ConversationType {
return {
id,
type: 'direct',
title: `${id} title`,
};
}
const i18n = setupI18n('en', enMessages);
describe('#getConversationSelector', () => {
it('returns empty placeholder if falsey id provided', () => {
const state = getEmptyRootState();
const selector = getConversationSelector(state);
const actual = selector(undefined);
assert.deepEqual(actual, getPlaceholderContact());
});
it('returns empty placeholder if no match', () => {
const state = {
...getEmptyRootState(),
};
const selector = getConversationSelector(state);
const actual = selector('random-id');
assert.deepEqual(actual, getPlaceholderContact());
});
it('returns conversation by e164 first', () => {
const id = 'id';
const conversation = getDefaultConversation(id);
const wrongConversation = getDefaultConversation('wrong');
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
[id]: wrongConversation,
},
conversationsByE164: {
[id]: conversation,
},
conversationsByUuid: {
[id]: wrongConversation,
},
conversationsByGroupId: {
[id]: wrongConversation,
},
},
};
const selector = getConversationSelector(state);
const actual = selector(id);
assert.strictEqual(actual, conversation);
});
it('returns conversation by uuid', () => {
const id = 'id';
const conversation = getDefaultConversation(id);
const wrongConversation = getDefaultConversation('wrong');
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
[id]: wrongConversation,
},
conversationsByUuid: {
[id]: conversation,
},
conversationsByGroupId: {
[id]: wrongConversation,
},
},
};
const selector = getConversationSelector(state);
const actual = selector(id);
assert.strictEqual(actual, conversation);
});
it('returns conversation by groupId', () => {
const id = 'id';
const conversation = getDefaultConversation(id);
const wrongConversation = getDefaultConversation('wrong');
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
[id]: wrongConversation,
},
conversationsByGroupId: {
[id]: conversation,
},
},
};
const selector = getConversationSelector(state);
const actual = selector(id);
assert.strictEqual(actual, conversation);
});
it('returns conversation by conversationId', () => {
const id = 'id';
const conversation = getDefaultConversation(id);
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
[id]: conversation,
},
},
};
const selector = getConversationSelector(state);
const actual = selector(id);
assert.strictEqual(actual, conversation);
});
// Less important now, given that all prop-generation for conversations is in
// models/conversation.getProps() and not here.
it('does proper caching of result', () => {
const id = 'id';
const conversation = getDefaultConversation(id);
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
[id]: conversation,
},
},
};
const selector = getConversationSelector(state);
const actual = selector(id);
const secondState = {
...state,
conversations: {
...getEmptyState(),
conversationLookup: {
[id]: conversation,
},
},
};
const secondSelector = getConversationSelector(secondState);
const secondActual = secondSelector(id);
assert.strictEqual(actual, secondActual);
const thirdState = {
...state,
conversations: {
...getEmptyState(),
conversationLookup: {
[id]: getDefaultConversation('third'),
},
},
};
const thirdSelector = getConversationSelector(thirdState);
const thirdActual = thirdSelector(id);
assert.notStrictEqual(actual, thirdActual);
});
});
describe('#getIsConversationEmptySelector', () => {
it('returns a selector that returns true for conversations that have no messages', () => {
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
messagesByConversation: {
abc123: {
heightChangeMessageIds: [],
isLoadingMessages: false,
messageIds: [],
metrics: { totalUnread: 0 },
resetCounter: 0,
scrollToMessageCounter: 0,
},
},
},
};
const selector = getIsConversationEmptySelector(state);
assert.isTrue(selector('abc123'));
});
it('returns a selector that returns true for conversations that have no messages, even if loading', () => {
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
messagesByConversation: {
abc123: {
heightChangeMessageIds: [],
isLoadingMessages: true,
messageIds: [],
metrics: { totalUnread: 0 },
resetCounter: 0,
scrollToMessageCounter: 0,
},
},
},
};
const selector = getIsConversationEmptySelector(state);
assert.isTrue(selector('abc123'));
});
it('returns a selector that returns false for conversations that have messages', () => {
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
messagesByConversation: {
abc123: {
heightChangeMessageIds: [],
isLoadingMessages: false,
messageIds: ['xyz'],
metrics: { totalUnread: 0 },
resetCounter: 0,
scrollToMessageCounter: 0,
},
},
},
};
const selector = getIsConversationEmptySelector(state);
assert.isFalse(selector('abc123'));
});
});
describe('#isComposing', () => {
it('returns false if there is no composer state', () => {
assert.isFalse(isComposing(getEmptyRootState()));
});
it('returns true if there is composer state', () => {
assert.isTrue(
isComposing({
...getEmptyRootState(),
conversations: {
...getEmptyState(),
composer: {
contactSearchTerm: '',
},
},
})
);
});
});
describe('#getComposeContacts', () => {
const getRootState = (contactSearchTerm = ''): StateType => {
const rootState = getEmptyRootState();
return {
...rootState,
conversations: {
...getEmptyState(),
conversationLookup: {
'our-conversation-id': {
...getDefaultConversation('our-conversation-id'),
isMe: true,
},
},
composer: {
contactSearchTerm,
},
},
user: {
...rootState.user,
ourConversationId: 'our-conversation-id',
i18n,
},
};
};
const getRootStateWithConverastions = (
contactSearchTerm = ''
): StateType => {
const result = getRootState(contactSearchTerm);
Object.assign(result.conversations.conversationLookup, {
'convo-1': {
...getDefaultConversation('convo-1'),
name: 'In System Contacts',
title: 'A. Sorted First',
},
'convo-2': {
...getDefaultConversation('convo-2'),
title: 'Should Be Dropped (no name, no profile sharing)',
},
'convo-3': {
...getDefaultConversation('convo-3'),
type: 'group',
title: 'Should Be Dropped (group)',
},
'convo-4': {
...getDefaultConversation('convo-4'),
isBlocked: true,
title: 'Should Be Dropped (blocked)',
},
'convo-5': {
...getDefaultConversation('convo-5'),
discoveredUnregisteredAt: new Date(1999, 3, 20).getTime(),
title: 'Should Be Dropped (unregistered)',
},
'convo-6': {
...getDefaultConversation('convo-6'),
profileSharing: true,
title: 'C. Has Profile Sharing',
},
'convo-7': {
...getDefaultConversation('convo-7'),
discoveredUnregisteredAt: Date.now(),
name: 'In System Contacts (and only recently unregistered)',
title: 'B. Sorted Second',
},
});
return result;
};
it('only returns Note to Self when there are no other contacts', () => {
const state = getRootState();
const result = getComposeContacts(state);
assert.lengthOf(result, 1);
assert.strictEqual(result[0]?.id, 'our-conversation-id');
});
it("returns no results when search doesn't match Note to Self and there are no other contacts", () => {
const state = getRootState('foo bar baz');
const result = getComposeContacts(state);
assert.isEmpty(result);
});
it('returns contacts with Note to Self at the end when there is no search term', () => {
const state = getRootStateWithConverastions();
const result = getComposeContacts(state);
const ids = result.map(contact => contact.id);
assert.deepEqual(ids, [
'convo-1',
'convo-7',
'convo-6',
'our-conversation-id',
]);
});
it('can search for contacts', () => {
const state = getRootStateWithConverastions('in system');
const result = getComposeContacts(state);
const ids = result.map(contact => contact.id);
assert.deepEqual(ids, ['convo-1', 'convo-7']);
});
});
describe('#getComposerContactSearchTerm', () => {
it("returns the composer's contact search term", () => {
assert.strictEqual(
getComposerContactSearchTerm({
...getEmptyRootState(),
conversations: {
...getEmptyState(),
composer: {
contactSearchTerm: 'foo bar',
},
},
}),
'foo bar'
);
});
});
2019-01-14 21:49:58 +00:00
describe('#getLeftPaneList', () => {
it('sorts conversations based on timestamp then by intl-friendly title', () => {
2019-03-12 00:20:16 +00:00
const data: ConversationLookupType = {
2019-01-14 21:49:58 +00:00
id1: {
id: 'id1',
e164: '+18005551111',
2019-01-14 21:49:58 +00:00
activeAt: Date.now(),
name: 'No timestamp',
timestamp: 0,
inboxPosition: 0,
2019-01-14 21:49:58 +00:00
phoneNumber: 'notused',
2019-03-12 00:20:16 +00:00
isArchived: false,
markedUnread: false,
2019-01-14 21:49:58 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'No timestamp',
2019-01-14 21:49:58 +00:00
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
2020-05-27 21:37:06 +00:00
acceptedMessageRequest: true,
2019-01-14 21:49:58 +00:00
},
id2: {
id: 'id2',
e164: '+18005551111',
2019-01-14 21:49:58 +00:00
activeAt: Date.now(),
name: 'B',
timestamp: 20,
inboxPosition: 21,
2019-01-14 21:49:58 +00:00
phoneNumber: 'notused',
2019-03-12 00:20:16 +00:00
isArchived: false,
markedUnread: false,
2019-01-14 21:49:58 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'B',
2019-01-14 21:49:58 +00:00
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
2020-05-27 21:37:06 +00:00
acceptedMessageRequest: true,
2019-01-14 21:49:58 +00:00
},
id3: {
id: 'id3',
e164: '+18005551111',
2019-01-14 21:49:58 +00:00
activeAt: Date.now(),
name: 'C',
timestamp: 20,
inboxPosition: 22,
2019-01-14 21:49:58 +00:00
phoneNumber: 'notused',
2019-03-12 00:20:16 +00:00
isArchived: false,
markedUnread: false,
2019-01-14 21:49:58 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'C',
2019-01-14 21:49:58 +00:00
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
2020-05-27 21:37:06 +00:00
acceptedMessageRequest: true,
2019-01-14 21:49:58 +00:00
},
id4: {
id: 'id4',
e164: '+18005551111',
2019-01-14 21:49:58 +00:00
activeAt: Date.now(),
name: 'Á',
timestamp: 20,
inboxPosition: 20,
2019-01-14 21:49:58 +00:00
phoneNumber: 'notused',
2019-03-12 00:20:16 +00:00
isArchived: false,
markedUnread: false,
2019-01-14 21:49:58 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'A',
2019-01-14 21:49:58 +00:00
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
2020-05-27 21:37:06 +00:00
acceptedMessageRequest: true,
2019-01-14 21:49:58 +00:00
},
id5: {
id: 'id5',
e164: '+18005551111',
2019-01-14 21:49:58 +00:00
activeAt: Date.now(),
name: 'First!',
timestamp: 30,
inboxPosition: 30,
2019-01-14 21:49:58 +00:00
phoneNumber: 'notused',
2019-03-12 00:20:16 +00:00
isArchived: false,
markedUnread: false,
2019-01-14 21:49:58 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'First!',
2019-01-14 21:49:58 +00:00
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
2020-05-27 21:37:06 +00:00
acceptedMessageRequest: true,
2019-01-14 21:49:58 +00:00
},
};
2020-07-24 01:35:32 +00:00
const comparator = _getConversationComparator();
2019-03-12 00:20:16 +00:00
const { conversations } = _getLeftPaneLists(data, comparator);
2019-01-14 21:49:58 +00:00
2019-03-12 00:20:16 +00:00
assert.strictEqual(conversations[0].name, 'First!');
assert.strictEqual(conversations[1].name, 'Á');
assert.strictEqual(conversations[2].name, 'B');
assert.strictEqual(conversations[3].name, 'C');
assert.strictEqual(conversations[4].name, 'No timestamp');
2019-01-14 21:49:58 +00:00
});
2020-10-10 14:25:17 +00:00
describe('given pinned conversations', () => {
it('sorts pinned conversations based on order in storage', () => {
const data: ConversationLookupType = {
pin2: {
id: 'pin2',
e164: '+18005551111',
activeAt: Date.now(),
name: 'Pin Two',
timestamp: 30,
inboxPosition: 30,
phoneNumber: 'notused',
isArchived: false,
isPinned: true,
markedUnread: false,
2020-10-10 14:25:17 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'Pin Two',
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
acceptedMessageRequest: true,
},
pin3: {
id: 'pin3',
e164: '+18005551111',
activeAt: Date.now(),
name: 'Pin Three',
timestamp: 30,
inboxPosition: 30,
phoneNumber: 'notused',
isArchived: false,
isPinned: true,
markedUnread: false,
2020-10-10 14:25:17 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'Pin Three',
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
acceptedMessageRequest: true,
},
pin1: {
id: 'pin1',
e164: '+18005551111',
activeAt: Date.now(),
name: 'Pin One',
timestamp: 30,
inboxPosition: 30,
phoneNumber: 'notused',
isArchived: false,
isPinned: true,
markedUnread: false,
2020-10-10 14:25:17 +00:00
type: 'direct',
isMe: false,
lastUpdated: Date.now(),
title: 'Pin One',
unreadCount: 1,
isSelected: false,
typingContact: {
name: 'Someone There',
color: 'blue',
phoneNumber: '+18005551111',
},
acceptedMessageRequest: true,
},
};
const pinnedConversationIds = ['pin1', 'pin2', 'pin3'];
2020-10-10 14:25:17 +00:00
const comparator = _getConversationComparator();
const { pinnedConversations } = _getLeftPaneLists(
data,
comparator,
undefined,
pinnedConversationIds
);
2020-10-10 14:25:17 +00:00
assert.strictEqual(pinnedConversations[0].name, 'Pin One');
assert.strictEqual(pinnedConversations[1].name, 'Pin Two');
assert.strictEqual(pinnedConversations[2].name, 'Pin Three');
});
});
2019-01-14 21:49:58 +00:00
});
describe('#getSelectedConversationId', () => {
it('returns undefined if no conversation is selected', () => {
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
abc123: getDefaultConversation('abc123'),
},
},
};
assert.isUndefined(getSelectedConversationId(state));
});
it('returns the selected conversation ID', () => {
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
abc123: getDefaultConversation('abc123'),
},
selectedConversationId: 'abc123',
},
};
assert.strictEqual(getSelectedConversationId(state), 'abc123');
});
});
describe('#getSelectedConversation', () => {
it('returns undefined if no conversation is selected', () => {
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
abc123: getDefaultConversation('abc123'),
},
},
};
assert.isUndefined(getSelectedConversation(state));
});
it('returns the selected conversation ID', () => {
const state = {
...getEmptyRootState(),
conversations: {
...getEmptyState(),
conversationLookup: {
abc123: getDefaultConversation('abc123'),
},
selectedConversationId: 'abc123',
},
};
assert.deepEqual(
getSelectedConversation(state),
getDefaultConversation('abc123')
);
});
});
2019-01-14 21:49:58 +00:00
});