2022-02-24 21:01:41 +00:00
|
|
|
// Copyright 2022 Signal Messenger, LLC
|
|
|
|
// SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
|
|
|
|
import { assert } from 'chai';
|
|
|
|
import path from 'path';
|
|
|
|
import http from 'http';
|
|
|
|
import fs from 'fs/promises';
|
|
|
|
import { tmpdir } from 'os';
|
|
|
|
|
|
|
|
import { strictAssert } from '../../util/assert';
|
2022-03-02 19:48:07 +00:00
|
|
|
import * as durations from '../../util/durations';
|
|
|
|
import { getGotOptions } from '../../updater/got';
|
2022-02-24 21:01:41 +00:00
|
|
|
import {
|
|
|
|
computeDiff,
|
|
|
|
getBlockMapFileName,
|
|
|
|
prepareDownload,
|
2022-02-25 18:44:03 +00:00
|
|
|
isValidPreparedData,
|
2022-02-24 21:01:41 +00:00
|
|
|
download,
|
|
|
|
} from '../../updater/differential';
|
|
|
|
|
|
|
|
const FIXTURES = path.join(__dirname, '..', '..', '..', 'fixtures');
|
2022-03-01 22:44:29 +00:00
|
|
|
const CRLF = '\r\n';
|
2022-02-24 21:01:41 +00:00
|
|
|
|
|
|
|
describe('updater/differential', () => {
|
|
|
|
describe('computeDiff', () => {
|
|
|
|
it('computes correct difference', () => {
|
|
|
|
const old = [
|
|
|
|
{ checksum: 'a', offset: 0, size: 2 },
|
|
|
|
{ checksum: 'b', offset: 2, size: 4 },
|
|
|
|
{ checksum: 'c', offset: 6, size: 1 },
|
|
|
|
{ checksum: 'c', offset: 7, size: 1 },
|
|
|
|
{ checksum: 'd', offset: 8, size: 4 },
|
|
|
|
];
|
|
|
|
|
|
|
|
const next = [
|
|
|
|
{ checksum: 'prepend', offset: 0, size: 2 },
|
|
|
|
{ checksum: 'not a', offset: 2, size: 4 },
|
|
|
|
{ checksum: 'b', offset: 6, size: 4 },
|
|
|
|
{ checksum: 'c', offset: 10, size: 1 },
|
|
|
|
{ checksum: 'c', offset: 11, size: 1 },
|
|
|
|
{ checksum: 'insert', offset: 12, size: 5 },
|
|
|
|
{ checksum: 'c', offset: 17, size: 1 },
|
|
|
|
{ checksum: 'd', offset: 18, size: 4 },
|
|
|
|
{ checksum: 'append', offset: 22, size: 3 },
|
|
|
|
];
|
|
|
|
|
|
|
|
assert.deepStrictEqual(computeDiff(old, next), [
|
|
|
|
{ action: 'download', readOffset: 0, size: 6, writeOffset: 0 },
|
|
|
|
{ action: 'copy', readOffset: 2, size: 6, writeOffset: 6 },
|
|
|
|
// Note: this includes the third "c"
|
|
|
|
{ action: 'download', readOffset: 12, size: 6, writeOffset: 12 },
|
|
|
|
// This is "d"
|
|
|
|
{ action: 'copy', readOffset: 8, size: 4, writeOffset: 18 },
|
|
|
|
{ action: 'download', readOffset: 22, size: 3, writeOffset: 22 },
|
|
|
|
]);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('prepareDownload/download', () => {
|
|
|
|
const oldFile = 'diff-original.bin';
|
|
|
|
const oldBlockFile = getBlockMapFileName(oldFile);
|
|
|
|
|
2022-04-08 02:14:41 +00:00
|
|
|
const emptyFile = 'diff-empty.bin';
|
|
|
|
|
2022-02-24 21:01:41 +00:00
|
|
|
const newFile = 'diff-modified.bin';
|
|
|
|
const newBlockFile = getBlockMapFileName(newFile);
|
|
|
|
const newHash =
|
2022-03-01 22:44:29 +00:00
|
|
|
'oEXIz7JVN1phjmumPLVQuwSYa+tHLEn5/a+q9w/pbk' +
|
|
|
|
'bnCaXAioWrAIq1P9HeqNQ0Lpsb4mWey632DUPnUXqfiw==';
|
2022-02-24 21:01:41 +00:00
|
|
|
|
|
|
|
const allowedFiles = new Set([
|
|
|
|
oldFile,
|
|
|
|
oldBlockFile,
|
|
|
|
newFile,
|
|
|
|
newBlockFile,
|
|
|
|
]);
|
|
|
|
|
|
|
|
let server: http.Server;
|
|
|
|
let baseUrl: string;
|
2022-03-02 19:48:07 +00:00
|
|
|
let shouldTimeout: 'response' | undefined;
|
2022-02-24 21:01:41 +00:00
|
|
|
|
|
|
|
beforeEach(callback => {
|
2022-03-02 19:48:07 +00:00
|
|
|
shouldTimeout = undefined;
|
2022-02-24 21:01:41 +00:00
|
|
|
server = http.createServer(async (req, res) => {
|
2022-03-02 18:06:58 +00:00
|
|
|
if (!req.headers['user-agent']?.includes('Signal-Desktop')) {
|
|
|
|
res.writeHead(403);
|
|
|
|
res.end(`Invalid user agent: "${req.headers['user-agent']}"`);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2022-02-24 21:01:41 +00:00
|
|
|
const file = req.url?.slice(1) ?? '';
|
|
|
|
if (!allowedFiles.has(file)) {
|
|
|
|
res.writeHead(404);
|
|
|
|
res.end('Not found');
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2022-03-01 22:44:29 +00:00
|
|
|
const fullFile = await fs.readFile(path.join(FIXTURES, file));
|
|
|
|
|
|
|
|
const rangeHeader = req.headers.range?.match(/^bytes=([\d,\s-]+)$/);
|
|
|
|
if (!rangeHeader) {
|
2022-02-24 21:01:41 +00:00
|
|
|
res.writeHead(200);
|
2022-03-01 22:44:29 +00:00
|
|
|
res.end(fullFile);
|
|
|
|
return;
|
2022-02-24 21:01:41 +00:00
|
|
|
}
|
|
|
|
|
2022-03-01 22:44:29 +00:00
|
|
|
const ranges = rangeHeader[1].split(/\s*,\s*/g).map(value => {
|
|
|
|
const range = value.match(/^(\d+)-(\d+)$/);
|
|
|
|
strictAssert(range, `Invalid header: ${rangeHeader}`);
|
|
|
|
|
|
|
|
return [parseInt(range[1], 10), parseInt(range[2], 10)];
|
|
|
|
});
|
|
|
|
|
2022-04-08 02:14:41 +00:00
|
|
|
if (ranges.length === 1) {
|
2022-04-26 23:58:29 +00:00
|
|
|
res.writeHead(206, {
|
2022-04-08 02:14:41 +00:00
|
|
|
'content-type': 'application/octet-stream',
|
|
|
|
});
|
|
|
|
if (shouldTimeout === 'response') {
|
|
|
|
res.flushHeaders();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
const [from, to] = ranges[0];
|
|
|
|
res.end(fullFile.slice(from, to + 1));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2022-03-01 22:44:29 +00:00
|
|
|
const BOUNDARY = 'f8f254ce1ba37627';
|
|
|
|
|
2022-03-02 19:48:07 +00:00
|
|
|
res.writeHead(206, {
|
|
|
|
'content-type': `multipart/byteranges; boundary=${BOUNDARY}`,
|
|
|
|
});
|
|
|
|
if (shouldTimeout === 'response') {
|
|
|
|
res.flushHeaders();
|
|
|
|
return;
|
|
|
|
}
|
2022-03-01 22:44:29 +00:00
|
|
|
|
|
|
|
const totalSize = fullFile.length;
|
|
|
|
|
|
|
|
const multipart = Buffer.concat([
|
|
|
|
...ranges
|
|
|
|
.map(([from, to]) => [
|
|
|
|
Buffer.from(
|
|
|
|
[
|
|
|
|
`--${BOUNDARY}`,
|
|
|
|
'Content-Type: binary/octet-stream',
|
|
|
|
`Content-Range: bytes ${from}-${to}/${totalSize}`,
|
|
|
|
'',
|
|
|
|
'',
|
|
|
|
].join(CRLF)
|
|
|
|
),
|
|
|
|
fullFile.slice(from, to + 1),
|
|
|
|
Buffer.from(CRLF),
|
|
|
|
])
|
|
|
|
.flat(),
|
|
|
|
Buffer.from(`--${BOUNDARY}--${CRLF}`),
|
|
|
|
]);
|
|
|
|
|
|
|
|
res.end(multipart);
|
2022-02-24 21:01:41 +00:00
|
|
|
});
|
|
|
|
|
|
|
|
server.unref();
|
|
|
|
|
|
|
|
server.listen(0, () => {
|
|
|
|
const addr = server.address();
|
2022-09-14 16:40:50 +00:00
|
|
|
strictAssert(typeof addr === 'object' && addr != null, 'node.js apis');
|
2022-02-24 21:01:41 +00:00
|
|
|
baseUrl = `http://127.0.0.1:${addr.port}`;
|
|
|
|
|
|
|
|
callback();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(() => {
|
|
|
|
server.close();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('prepares the download', async () => {
|
|
|
|
const data = await prepareDownload({
|
|
|
|
oldFile: path.join(FIXTURES, oldFile),
|
|
|
|
newUrl: `${baseUrl}/${newFile}`,
|
|
|
|
sha512: newHash,
|
|
|
|
});
|
|
|
|
|
2022-03-01 22:44:29 +00:00
|
|
|
assert.strictEqual(data.downloadSize, 62826);
|
2022-02-24 21:01:41 +00:00
|
|
|
assert.deepStrictEqual(data.diff, [
|
2022-03-01 22:44:29 +00:00
|
|
|
{ action: 'copy', size: 44288, readOffset: 0, writeOffset: 0 },
|
|
|
|
{
|
|
|
|
action: 'download',
|
|
|
|
size: 8813,
|
|
|
|
readOffset: 44288,
|
|
|
|
writeOffset: 44288,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
action: 'copy',
|
|
|
|
size: 37849,
|
|
|
|
readOffset: 53101,
|
|
|
|
writeOffset: 53101,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
action: 'download',
|
|
|
|
size: 21245,
|
|
|
|
readOffset: 90950,
|
|
|
|
writeOffset: 90950,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
action: 'copy',
|
|
|
|
size: 116397,
|
|
|
|
readOffset: 112195,
|
|
|
|
writeOffset: 112195,
|
|
|
|
},
|
2022-02-24 21:01:41 +00:00
|
|
|
{
|
|
|
|
action: 'download',
|
|
|
|
size: 32768,
|
2022-03-01 22:44:29 +00:00
|
|
|
readOffset: 228592,
|
|
|
|
writeOffset: 228592,
|
2022-02-24 21:01:41 +00:00
|
|
|
},
|
|
|
|
{
|
|
|
|
action: 'copy',
|
2022-03-01 22:44:29 +00:00
|
|
|
size: 784,
|
|
|
|
readOffset: 261360,
|
|
|
|
writeOffset: 261360,
|
2022-02-24 21:01:41 +00:00
|
|
|
},
|
|
|
|
]);
|
|
|
|
});
|
|
|
|
|
2022-02-25 18:44:03 +00:00
|
|
|
it('checks that the data is valid to facilitate caching', async () => {
|
|
|
|
const oldFilePath = path.join(FIXTURES, oldFile);
|
|
|
|
const newUrl = `${baseUrl}/${newFile}`;
|
|
|
|
|
|
|
|
const data = await prepareDownload({
|
|
|
|
oldFile: oldFilePath,
|
|
|
|
newUrl,
|
|
|
|
sha512: newHash,
|
|
|
|
});
|
|
|
|
|
|
|
|
assert.isTrue(
|
|
|
|
isValidPreparedData(data, {
|
|
|
|
oldFile: oldFilePath,
|
|
|
|
newUrl,
|
|
|
|
sha512: newHash,
|
|
|
|
})
|
|
|
|
);
|
|
|
|
|
|
|
|
assert.isFalse(
|
|
|
|
isValidPreparedData(data, {
|
|
|
|
oldFile: 'different file',
|
|
|
|
newUrl,
|
|
|
|
sha512: newHash,
|
|
|
|
})
|
|
|
|
);
|
|
|
|
|
|
|
|
assert.isFalse(
|
|
|
|
isValidPreparedData(data, {
|
|
|
|
oldFile: oldFilePath,
|
|
|
|
newUrl: 'different url',
|
|
|
|
sha512: newHash,
|
|
|
|
})
|
|
|
|
);
|
|
|
|
|
|
|
|
assert.isFalse(
|
|
|
|
isValidPreparedData(data, {
|
|
|
|
oldFile: oldFilePath,
|
|
|
|
newUrl,
|
|
|
|
sha512: 'different hash',
|
|
|
|
})
|
|
|
|
);
|
|
|
|
});
|
|
|
|
|
2022-02-24 21:01:41 +00:00
|
|
|
it('downloads the file', async () => {
|
|
|
|
const data = await prepareDownload({
|
|
|
|
oldFile: path.join(FIXTURES, oldFile),
|
|
|
|
newUrl: `${baseUrl}/${newFile}`,
|
|
|
|
sha512: newHash,
|
|
|
|
});
|
|
|
|
|
|
|
|
const outDir = await fs.mkdtemp(path.join(tmpdir(), 'signal-temp-'));
|
|
|
|
await fs.mkdir(outDir, { recursive: true });
|
|
|
|
|
|
|
|
const outFile = path.join(outDir, 'out.bin');
|
|
|
|
const chunks = new Array<number>();
|
2022-03-02 19:48:07 +00:00
|
|
|
await download(outFile, data, {
|
|
|
|
statusCallback(size) {
|
|
|
|
chunks.push(size);
|
|
|
|
},
|
|
|
|
});
|
2022-02-24 21:01:41 +00:00
|
|
|
|
|
|
|
const expected = await fs.readFile(path.join(FIXTURES, newFile));
|
|
|
|
const actual = await fs.readFile(outFile);
|
2022-04-08 02:14:41 +00:00
|
|
|
|
|
|
|
assert.isTrue(actual.equals(expected), 'Files do not match');
|
|
|
|
assert.isTrue(
|
|
|
|
chunks.length > 0,
|
|
|
|
'Expected multiple callback invocations'
|
|
|
|
);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('downloads the full file with a single range', async () => {
|
|
|
|
const data = await prepareDownload({
|
|
|
|
oldFile: path.join(FIXTURES, emptyFile),
|
|
|
|
newUrl: `${baseUrl}/${newFile}`,
|
|
|
|
sha512: newHash,
|
|
|
|
});
|
|
|
|
|
|
|
|
const outDir = await fs.mkdtemp(path.join(tmpdir(), 'signal-temp-'));
|
|
|
|
await fs.mkdir(outDir, { recursive: true });
|
|
|
|
|
|
|
|
const outFile = path.join(outDir, 'out.bin');
|
|
|
|
const chunks = new Array<number>();
|
|
|
|
await download(outFile, data, {
|
|
|
|
statusCallback(size) {
|
|
|
|
chunks.push(size);
|
|
|
|
},
|
|
|
|
});
|
|
|
|
|
|
|
|
const expected = await fs.readFile(path.join(FIXTURES, newFile));
|
|
|
|
const actual = await fs.readFile(outFile);
|
2022-02-24 21:01:41 +00:00
|
|
|
|
|
|
|
assert.isTrue(actual.equals(expected), 'Files do not match');
|
|
|
|
assert.isTrue(
|
|
|
|
chunks.length > 0,
|
|
|
|
'Expected multiple callback invocations'
|
|
|
|
);
|
|
|
|
});
|
2022-03-02 19:48:07 +00:00
|
|
|
|
|
|
|
it('handles response timeouts gracefully', async () => {
|
|
|
|
const data = await prepareDownload({
|
|
|
|
oldFile: path.join(FIXTURES, oldFile),
|
|
|
|
newUrl: `${baseUrl}/${newFile}`,
|
|
|
|
sha512: newHash,
|
|
|
|
});
|
|
|
|
|
|
|
|
const outDir = await fs.mkdtemp(path.join(tmpdir(), 'signal-temp-'));
|
|
|
|
await fs.mkdir(outDir, { recursive: true });
|
|
|
|
|
|
|
|
const outFile = path.join(outDir, 'out.bin');
|
|
|
|
|
|
|
|
shouldTimeout = 'response';
|
|
|
|
await assert.isRejected(
|
|
|
|
download(outFile, data, {
|
|
|
|
gotOptions: {
|
2024-03-20 18:05:10 +00:00
|
|
|
...(await getGotOptions()),
|
2022-03-02 19:48:07 +00:00
|
|
|
timeout: {
|
|
|
|
connect: 0.5 * durations.SECOND,
|
|
|
|
lookup: 0.5 * durations.SECOND,
|
|
|
|
socket: 0.5 * durations.SECOND,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}),
|
|
|
|
/Timeout awaiting 'socket' for 500ms/
|
|
|
|
);
|
|
|
|
});
|
2022-02-24 21:01:41 +00:00
|
|
|
});
|
|
|
|
});
|