Finish converting most of the undeprecated api to jspecify

patches/api/0199-Add-moon-phase-API.patch

@@ -6,17 +6,17 @@ Subject: [PATCH] Add moon phase API
 
 diff --git a/src/main/java/io/papermc/paper/world/MoonPhase.java b/src/main/java/io/papermc/paper/world/MoonPhase.java
 new file mode 100644
-index 0000000000000000000000000000000000000000..df05153397b42930cd53d37b30824c7e5f008f7e
+index 0000000000000000000000000000000000000000..0b24e1a92bba4fed0ca2d4336a3b8351a800f93a
 --- /dev/null
 +++ b/src/main/java/io/papermc/paper/world/MoonPhase.java
-@@ -0,0 +1,36 @@
+@@ -0,0 +1,35 @@
 +package io.papermc.paper.world;
 +
-+import org.jetbrains.annotations.NotNull;
-+
 +import java.util.HashMap;
 +import java.util.Map;
++import org.jspecify.annotations.NullMarked;
 +
++@NullMarked
 +public enum MoonPhase {
 +    FULL_MOON(0L),
 +    WANING_GIBBOUS(1L),
@@ -29,20 +29,19 @@ index 0000000000000000000000000000000000000000..df05153397b42930cd53d37b30824c7e
 +
 +    private final long day;
 +
-+    MoonPhase(long day) {
++    MoonPhase(final long day) {
 +        this.day = day;
 +    }
 +
 +    private static final Map<Long, MoonPhase> BY_DAY = new HashMap<>();
 +
 +    static {
-+        for (MoonPhase phase : values()) {
++        for (final MoonPhase phase : values()) {
 +            BY_DAY.put(phase.day, phase);
 +        }
 +    }
 +
-+    @NotNull
-+    public static MoonPhase getPhase(long day) {
++    public static MoonPhase getPhase(final long day) {
 +        return BY_DAY.get(day % 8L);
 +    }
 +}