mirrors/papermc
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Cache material data constructors. Fixes BUKKIT-2980

Browse source 
Reobtaining a constructor is not a trivial operation, this change makes the Material enum store the respective constructors for each MaterialData.

Additionally 'fixed' the material tests to use proper generics.

By: Darth Android <darthandroid@gmail.com>
This commit is contained in:
Bukkit/Spigot 2012-11-17 11:13:58 -06:00
parent f70c5fcd4c
commit d2e8c21941
2 changed files with 27 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

14
paper-api/src/test/java/org/bukkit/MaterialTest.java
View file

@ -1,11 +1,9 @@
package org.bukkit;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.isA;
import static org.hamcrest.CoreMatchers.nullValue;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
import org.bukkit.material.MaterialData;
import org.junit.Test;
public class MaterialTest {
@ -42,14 +40,12 @@ public class MaterialTest {
assertThat(Material.getMaterial(null), is(nullValue()));
}
// [EB]: gawd we need better code >.>
@SuppressWarnings({ "unchecked", "rawtypes" })
@Test
public void getData() {
for (Material material : Material.values()) {
Class clazz = material.getData();
Class<? extends MaterialData> clazz = material.getData();
assertThat(material.getNewData((byte) 0), isA(clazz));
assertThat(material.getNewData((byte) 0), is(instanceOf(clazz)));
}
}