mirrors/papermc
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Switch to using ForgeFlower for Paper Only mc-dev imports

Browse source 
ForgeFlower is better than Spigots FernFlower at decompiling the source.

However, in order to maintain the CraftBukkit patches, we must keep
using spigots for the primary.

However, for any file that we import on top of Spigots imported files
there is nothing stopping us from using better decompiled files.

So these changes will use ForgeFlower to maintain a better set of
decomped files, so anything we add on top of Paper can start off
in a better spot.
This commit is contained in:
Aikar 2018-08-31 18:56:57 -04:00
parent 854add2246
commit d089acb3bd
No known key found for this signature in database
GPG key ID: 401ADFC9891FAAFE
74 changed files with 1211 additions and 1269 deletions
Download patch file Download diff file Expand all files Collapse all files

68
scripts/decompile.sh
View file

@ -8,27 +8,89 @@ workdir="$basedir/work"
minecraftversion=$(cat "$workdir/BuildData/info.json" | grep minecraftVersion | cut -d '"' -f 4)
windows="$([[ "$OSTYPE" == "cygwin" || "$OSTYPE" == "msys" ]] && echo "true" || echo "false")"
decompiledir="$workdir/Minecraft/$minecraftversion"
spigotdecompiledir="$decompiledir/spigot"
forgedecompiledir="$decompiledir/forge"
forgeflowerversion="1.5.380.19"
forgeflowerurl="http://files.minecraftforge.net/maven/net/minecraftforge/forgeflower/$forgeflowerversion/forgeflower-$forgeflowerversion.jar"
# temp use patched version
forgeflowerurl="https://zachbr.keybase.pub/paper/forgeflower-patched/forgeflower-1.5.380.19.jar?dl=1"
forgeflowerbin="$workdir/ForgeFlower/$forgeflowerversion.jar"
# TODO: Make this better? We don't need spigot compat for this stage
forgefloweroptions="-dgs=1 -hdc=0 -asc=1 -udv=1 -jvn=1"
forgeflowercachefile="$decompiledir/forgeflowercache"
forgeflowercachevalue="$forgeflowerurl - $forgeflowerversion - $forgefloweroptions";
classdir="$decompiledir/classes"
mkdir -p "$workdir/ForgeFlower"
echo "Extracting NMS classes..."
if [ ! -d "$classdir" ]; then
mkdir -p "$classdir"
cd "$classdir"
set +e
jar xf "$decompiledir/$minecraftversion-mapped.jar" net/minecraft/server
if [ "$?" != "0" ]; then
cd "$basedir"
echo "Failed to extract NMS classes."
exit 1
fi
set -e
fi
echo "Decompiling classes..."
if [ ! -d "$decompiledir/net/minecraft/server" ]; then
# prep folders
mkdir -p "$spigotdecompiledir"
mkdir -p "$forgedecompiledir"
needsDecomp=0
if [ ! -f "$forgeflowercachefile" ]; then
needsDecomp=1
elif [ "$(cat ${forgeflowercachefile})" != "$forgeflowercachevalue" ]; then
needsDecomp=1
fi
if [ "$needsDecomp" == "1" ]; then
# our local cache is now invalidated, we can update forgeflower to get better deobfuscation
rm -rf "$forgedecompiledir"
fi
# Forge (for Paper mc-dev imports, and dev src folders for unimported files)
if [ ! -d "$forgedecompiledir/net" ] ; then
echo "Decompiling classes (stage 1)..."
cd "$basedir"
java -jar "$workdir/BuildData/bin/fernflower.jar" -dgs=1 -hdc=0 -asc=1 -udv=0 "$classdir" "$decompiledir"
if [ ! -f "$forgeflowerbin" ]; then
echo "Downloading ForgeFlower ($forgeflowerversion)..."
curl -s -o "$forgeflowerbin" "$forgeflowerurl"
fi
set +e
java -Ddecomp.renameparams=true -jar "$forgeflowerbin" ${forgefloweroptions} -ind=' ' "$classdir" "$forgedecompiledir"
if [ "$?" != "0" ]; then
rm -rf "$forgedecompiledir/net"
echo "Failed to decompile classes."
exit 1
fi
echo "$forgeflowercachevalue" > "$forgeflowercachefile"
set -e
fi
# Spigot (for CraftBukkit patches)
# if we see the old net folder, copy it to spigot to avoid redecompiling
if [ -d "$decompiledir/net" ]; then
cp -r "$decompiledir/net" "$spigotdecompiledir/"
fi
if [ ! -d "$spigotdecompiledir/net" ]; then
echo "Decompiling classes (stage 2)..."
cd "$basedir"
set +e
java -jar "$workdir/BuildData/bin/fernflower.jar" -dgs=1 -hdc=0 -asc=1 -udv=0 "$classdir" "$spigotdecompiledir"
if [ "$?" != "0" ]; then
rm -rf "$spigotdecompiledir/net"
echo "Failed to decompile classes."
exit 1
fi
set -e
fi
# set a symlink to current