mirrors/papermc
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't set last hand/armor lists to stripped items (#6977)

Browse source
This commit is contained in:
Jake Potrebic 2021-12-01 00:36:48 -08:00
parent b1687cbed4
commit a0f9b04f20
1 changed files with 36 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

63
patches/server/Hide-unnecessary-itemmeta-from-clients.patch
View file

@ -30,7 +30,7 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
public static final EntityDataSerializer<ItemStack> ITEM_STACK = new EntityDataSerializer<ItemStack>() { public static final EntityDataSerializer<ItemStack> ITEM_STACK = new EntityDataSerializer<ItemStack>() {
@Override @Override
public void write(FriendlyByteBuf buf, ItemStack value) { public void write(FriendlyByteBuf buf, ItemStack value) {
+ net.minecraft.world.entity.LivingEntity.stripMeta(value, null); // Paper - strip items to prevent oversized data + value = net.minecraft.world.entity.LivingEntity.stripMeta(value, null, false); // Paper - strip items to prevent oversized data
buf.writeItem(value); buf.writeItem(value);
} }
@ -42,8 +42,9 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
} }
+ public static void stripMeta(ItemStack itemStack, @org.jetbrains.annotations.Nullable Level level) { + public static ItemStack stripMeta(ItemStack itemStack, @org.jetbrains.annotations.Nullable Level level, boolean copy) {
+ if (itemStack.getTag() != null && !itemStack.isEmpty()) { + if ((itemStack.getCount() > 1 || itemStack.hasTag()) && !itemStack.isEmpty()) {
+ if (copy) itemStack = itemStack.copy();
+ CompoundTag nbt = itemStack.getTag(); + CompoundTag nbt = itemStack.getTag();
+ if (level != null && level.paperConfig.hideDurabilityFromClients) { + if (level != null && level.paperConfig.hideDurabilityFromClients) {
+ // Only show damage values for elytra's, since they show a different texture when broken. + // Only show damage values for elytra's, since they show a different texture when broken.
@ -57,36 +58,41 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
+ // we'll tell the client if there's one or (more than) two items. + // we'll tell the client if there's one or (more than) two items.
+ itemStack.setCount(itemStack.getCount() > 1 ? 2 : 1); + itemStack.setCount(itemStack.getCount() > 1 ? 2 : 1);
+ // We can't just strip out display, leather helmets still use the display.color tag. + // We can't just strip out display, leather helmets still use the display.color tag.
+ if (nbt.get("display") instanceof CompoundTag displayTag) { + if (nbt != null) {
+ displayTag.remove("Lore"); + if (nbt.get("display") instanceof CompoundTag displayTag) {
+ displayTag.remove("Name"); + displayTag.remove("Lore");
+ } + displayTag.remove("Name");
+ }
+ +
+ if (nbt.get("Enchantments") instanceof ListTag enchantmentsTag && !enchantmentsTag.isEmpty()) { + if (nbt.get("Enchantments") instanceof ListTag enchantmentsTag && !enchantmentsTag.isEmpty()) {
+ // The client still renders items with the enchantment glow if the enchantments tag contains at least one (empty) child. + // The client still renders items with the enchantment glow if the enchantments tag contains at least one (empty) child.
+ ListTag enchantments = new ListTag(); + ListTag enchantments = new ListTag();
+ enchantments.add(new CompoundTag()); + enchantments.add(new CompoundTag());
+ nbt.put("Enchantments", enchantments); + nbt.put("Enchantments", enchantments);
+ }
+ nbt.remove("AttributeModifiers");
+ } + }
+ nbt.remove("AttributeModifiers");
+ } + }
+ // Always remove items to prevent oversized data + // Always remove items to prevent oversized data
+ // Bundles change their texture based on their fullness. + // Bundles change their texture based on their fullness.
+ if (itemStack.is(Items.BUNDLE) && nbt.get("Items") instanceof ListTag oldItems && !oldItems.isEmpty()) { + if (nbt != null) {
+ org.bukkit.inventory.meta.BundleMeta bundleMeta = (org.bukkit.inventory.meta.BundleMeta) itemStack.asBukkitMirror().getItemMeta(); + if (itemStack.is(Items.BUNDLE) && nbt.get("Items") instanceof ListTag oldItems && !oldItems.isEmpty()) {
+ int sizeUsed = 0; + org.bukkit.inventory.meta.BundleMeta bundleMeta = (org.bukkit.inventory.meta.BundleMeta) itemStack.asBukkitMirror().getItemMeta();
+ for (org.bukkit.inventory.ItemStack item : bundleMeta.getItems()) { + int sizeUsed = 0;
+ int scale = 64 / item.getMaxStackSize(); + for (org.bukkit.inventory.ItemStack item : bundleMeta.getItems()) {
+ sizeUsed += scale * item.getAmount(); + int scale = 64 / item.getMaxStackSize();
+ sizeUsed += scale * item.getAmount();
+ }
+ // Now we add a single fake item that uses the same amount of slots as all other items.
+ ListTag items = new ListTag();
+ items.add(new ItemStack(Items.PAPER, sizeUsed).save(new CompoundTag()));
+ nbt.put("Items", items);
+ } + }
+ // Now we add a single fake item that uses the same amount of slots as all other items. + nbt.remove("BlockEntityTag");
+ ListTag items = new ListTag(); + nbt.remove("EntityTag");
+ items.add(new ItemStack(Items.PAPER, sizeUsed).save(new CompoundTag()));
+ nbt.put("Items", items);
+ } + }
+ nbt.remove("BlockEntityTag");
+ nbt.remove("EntityTag");
+ } + }
+ return itemStack;
+ } + }
+ +
private void handleEquipmentChanges(Map<EquipmentSlot, ItemStack> equipmentChanges) { private void handleEquipmentChanges(Map<EquipmentSlot, ItemStack> equipmentChanges) {
@ -94,7 +100,10 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
equipmentChanges.forEach((enumitemslot, itemstack) -> { equipmentChanges.forEach((enumitemslot, itemstack) -> {
ItemStack itemstack1 = itemstack.copy(); ItemStack itemstack1 = itemstack.copy();
+ stripMeta(itemstack1, this.level); // Paper - hide unnecessary itemmeta from clients + final ItemStack toSend = stripMeta(itemstack1, this.level, true); // Paper - hide unnecessary itemmeta from clients
list.add(Pair.of(enumitemslot, itemstack1)); - list.add(Pair.of(enumitemslot, itemstack1));
+ list.add(Pair.of(enumitemslot, toSend)); // Paper - hide unnecessary itemmeta from clients
switch (enumitemslot.getType()) { switch (enumitemslot.getType()) {
case HAND:
this.setLastHandItem(enumitemslot, itemstack1);