okaaay let's go

patches/server/0173-Disable-Explicit-Network-Manager-Flushing.patch

@@ -1,34 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Aikar <aikar@aikar.co>
-Date: Sun, 11 Mar 2018 14:13:33 -0400
-Subject: [PATCH] Disable Explicit Network Manager Flushing
-
-This seems completely pointless, as packet dispatch uses .writeAndFlush.
-
-Things seem to work fine without explicit flushing, but incase issues arise,
-provide a System property to re-enable it using improved logic of doing the
-flushing on the netty event loop, so it won't do the flush on the main thread.
-
-Renable flushing by passing -Dpaper.explicit-flush=true
-
-diff --git a/src/main/java/net/minecraft/network/Connection.java b/src/main/java/net/minecraft/network/Connection.java
-index 4ce0aaaeebe7b333491e3d8aece212c1378297c1..c45b8b2c89ffec7bd6a6875963c61f11185d3ee1 100644
---- a/src/main/java/net/minecraft/network/Connection.java
-+++ b/src/main/java/net/minecraft/network/Connection.java
-@@ -123,6 +123,7 @@ public class Connection extends SimpleChannelInboundHandler<Packet<?>> {
-     // Paper start - NetworkClient implementation
-     public int protocolVersion;
-     public java.net.InetSocketAddress virtualHost;
-+    private static boolean enableExplicitFlush = Boolean.getBoolean("paper.explicit-flush"); // Paper - Disable explicit network manager flushing
-     // Paper end
- 
-     // Paper start - add utility methods
-@@ -457,7 +458,7 @@ public class Connection extends SimpleChannelInboundHandler<Packet<?>> {
-         }
- 
-         if (this.channel != null) {
--            this.channel.flush();
-+            if (enableExplicitFlush) this.channel.eventLoop().execute(() -> this.channel.flush()); // Paper - Disable explicit network manager flushing; we don't need to explicit flush here, but allow opt in incase issues are found to a better version
-         }
- 
-         if (this.tickCount++ % 20 == 0) {