mirrors/papermc
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
papermc/CraftBukkit-Patches/0056-Item-Despawn-Rate.patch

39 lines
1.6 KiB
Diff
Raw Normal View History

Revert previous change to clear chunk list on the end of each tick, make it configurable instead. Whilst the new behaviour was technically correct as it prevented the possibility of the chunk tick list actually increasing over time, it introduced a few issues, namely the fact that it slowed growth to unreasonable levels, and interfered with the values which server admins have finally tuned, and come to enjoy over the last few years. If it is absolutely essential that growth be halted and ticking reduced as much as possible, the config option is there for power users. If we wish to 'fix' this by default in the future, a new chunk ticking algorithm, which actually has meaningful config options should be designed.
2014-01-14 08:16:43 +00:00
From 271b8162947d0cb71d237b42f39ca03135732626 Mon Sep 17 00:00:00 2001
Allow configuration of Item Despawn Rate
2013-09-22 09:11:09 +00:00
From: md_5 <md_5@live.com.au>
Date: Sun, 22 Sep 2013 19:10:53 +1000
Subject: [PATCH] Item Despawn Rate
diff --git a/src/main/java/net/minecraft/server/EntityItem.java b/src/main/java/net/minecraft/server/EntityItem.java
Stage 1
2013-12-01 03:40:53 +00:00
index 08b9ac8..8ea7abc 100644
Allow configuration of Item Despawn Rate
2013-09-22 09:11:09 +00:00
--- a/src/main/java/net/minecraft/server/EntityItem.java
+++ b/src/main/java/net/minecraft/server/EntityItem.java
Stage 1
2013-12-01 03:40:53 +00:00
@@ -104,7 +104,7 @@ public class EntityItem extends Entity {
}
Allow configuration of Item Despawn Rate
2013-09-22 09:11:09 +00:00
Stage 1
2013-12-01 03:40:53 +00:00
// ++this.age; // CraftBukkit - Moved up
- if (!this.world.isStatic && this.age >= 6000) {
+ if (!this.world.isStatic && this.age >= world.spigotConfig.itemDespawnRate) { // Spigot
// CraftBukkit start
if (org.bukkit.craftbukkit.event.CraftEventFactory.callItemDespawnEvent(this).isCancelled()) {
this.age = 0;
Allow configuration of Item Despawn Rate
2013-09-22 09:11:09 +00:00
diff --git a/src/main/java/org/spigotmc/SpigotWorldConfig.java b/src/main/java/org/spigotmc/SpigotWorldConfig.java
Revert previous change to clear chunk list on the end of each tick, make it configurable instead. Whilst the new behaviour was technically correct as it prevented the possibility of the chunk tick list actually increasing over time, it introduced a few issues, namely the fact that it slowed growth to unreasonable levels, and interfered with the values which server admins have finally tuned, and come to enjoy over the last few years. If it is absolutely essential that growth be halted and ticking reduced as much as possible, the config option is there for power users. If we wish to 'fix' this by default in the future, a new chunk ticking algorithm, which actually has meaningful config options should be designed.
2014-01-14 08:16:43 +00:00
index 3825bdf..72aabff 100644
Allow configuration of Item Despawn Rate
2013-09-22 09:11:09 +00:00
--- a/src/main/java/org/spigotmc/SpigotWorldConfig.java
+++ b/src/main/java/org/spigotmc/SpigotWorldConfig.java
Revert previous change to clear chunk list on the end of each tick, make it configurable instead. Whilst the new behaviour was technically correct as it prevented the possibility of the chunk tick list actually increasing over time, it introduced a few issues, namely the fact that it slowed growth to unreasonable levels, and interfered with the values which server admins have finally tuned, and come to enjoy over the last few years. If it is absolutely essential that growth be halted and ticking reduced as much as possible, the config option is there for power users. If we wish to 'fix' this by default in the future, a new chunk ticking algorithm, which actually has meaningful config options should be designed.
2014-01-14 08:16:43 +00:00
@@ -196,4 +196,11 @@ public class SpigotWorldConfig
Allow configuration of Item Despawn Rate
2013-09-22 09:11:09 +00:00
log( "*** WARNING *** Please use this option with caution, SpigotMC is not responsible for any issues this option may cause in the future!" );
}
}
+
+ public int itemDespawnRate;
+ private void itemDespawnRate()
+ {
+ itemDespawnRate = getInt( "item-despawn-rate", 6000 );
+ log( "Item Despawn Rate: " + itemDespawnRate );
+ }
}
--
Stage 1
2013-12-01 03:40:53 +00:00
1.8.3.2
Allow configuration of Item Despawn Rate
2013-09-22 09:11:09 +00:00
Reference in a new issue Copy permalink