mirrors/papermc
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
papermc/Spigot-Server-Patches/0162-ShulkerBox-Dupe-Prevention.patch

24 lines
1.1 KiB
Diff
Raw Normal View History

Block Entity#remove from being called on Players This doesn't result in the same behavior as other entities and causes several problems. Anyone ever complain about the "Cannot send chat message" thing? That's one of the issues this causes, among others. If a plugin developer can come up with a valid reason to call this on a Player we will look at limiting the scope of this change. It appears to be unintentional in the few cases we've seen so far.
2019-02-05 04:43:28 +00:00
From b29be1d2fea8597e02b6dfc3bd4ebe0096c7bb30 Mon Sep 17 00:00:00 2001
ShulkerBox Dupe Prevention - Fixes #488 This ensures that Shulker Boxes can never drop their contents twice, and that the inventory is cleared incase it some how also got saved to the world.
2017-01-02 21:49:08 +00:00
From: Aikar <aikar@aikar.co>
Date: Mon, 2 Jan 2017 16:32:56 -0500
Subject: [PATCH] ShulkerBox Dupe Prevention
This ensures that Shulker Boxes can never drop their contents twice, and
that the inventory is cleared incase it some how also got saved to the world.
diff --git a/src/main/java/net/minecraft/server/BlockShulkerBox.java b/src/main/java/net/minecraft/server/BlockShulkerBox.java
Block Entity#remove from being called on Players This doesn't result in the same behavior as other entities and causes several problems. Anyone ever complain about the "Cannot send chat message" thing? That's one of the issues this causes, among others. If a plugin developer can come up with a valid reason to call this on a Player we will look at limiting the scope of this change. It appears to be unintentional in the few cases we've seen so far.
2019-02-05 04:43:28 +00:00
index ab0ece55..997ed795 100644
ShulkerBox Dupe Prevention - Fixes #488 This ensures that Shulker Boxes can never drop their contents twice, and that the inventory is cleared incase it some how also got saved to the world.
2017-01-02 21:49:08 +00:00
--- a/src/main/java/net/minecraft/server/BlockShulkerBox.java
+++ b/src/main/java/net/minecraft/server/BlockShulkerBox.java
NOT WORKING! Even even more patches!
2018-07-17 20:32:05 +00:00
@@ -100,6 +100,7 @@ public class BlockShulkerBox extends BlockTileEntity {
}
ShulkerBox Dupe Prevention - Fixes #488 This ensures that Shulker Boxes can never drop their contents twice, and that the inventory is cleared incase it some how also got saved to the world.
2017-01-02 21:49:08 +00:00
NOT WORKING! Even even more patches!
2018-07-17 20:32:05 +00:00
a(world, blockposition, itemstack);
+ tileentityshulkerbox.clear(); // Paper - This was intended to be called in Vanilla (is checked in the if statement above if has been called) - Fixes dupe issues
}
ShulkerBox Dupe Prevention - Fixes #488 This ensures that Shulker Boxes can never drop their contents twice, and that the inventory is cleared incase it some how also got saved to the world.
2017-01-02 21:49:08 +00:00
}
world.updateAdjacentComparators(blockposition, iblockdata.getBlock());
--
Block Entity#remove from being called on Players This doesn't result in the same behavior as other entities and causes several problems. Anyone ever complain about the "Cannot send chat message" thing? That's one of the issues this causes, among others. If a plugin developer can come up with a valid reason to call this on a Player we will look at limiting the scope of this change. It appears to be unintentional in the few cases we've seen so far.
2019-02-05 04:43:28 +00:00
2.20.1.windows.1
ShulkerBox Dupe Prevention - Fixes #488 This ensures that Shulker Boxes can never drop their contents twice, and that the inventory is cleared incase it some how also got saved to the world.
2017-01-02 21:49:08 +00:00
Reference in a new issue Copy permalink