f8836306fa
This fixes fsck of a remote that uses chunking displaying (checking remotename) (checking remotename)" for every chunk. Also, some remotes displayed the message, and others did not, with no consistency. It was originally displayed only when accessing remotes that were expensive or might involve a password prompt, I think, but nothing in the API said when to do it so it became an inconsistent mess. Originally I thought fsck should always display it. But it only displays in fsck --from remote, so the user knows the remote is being accessed, so there is no reason to tell them it's accessing it over and over. It was also possible for git-annex move to sometimes display it twice, due to checking if content is present twice. But, the user of move specifies --from/--to, so it does not need to display when it's accessing the remote, as the user expects it to access the remote. git-annex get might display it, but only if the remote also supports hasKeyCheap, which is really only local git remotes, which didn't display it always; and in any case nothing displayed it before hasKeyCheap, which is checked first, so I don't think this needs to display it ever. mirror is like move. And that's all the main places it would have been displayed. This commit was sponsored by Jochen Bartl on Patreon.
32 lines
746 B
Haskell
32 lines
746 B
Haskell
{- git-annex remote messages
|
|
-
|
|
- Copyright 2013 Joey Hess <id@joeyh.name>
|
|
-
|
|
- Licensed under the GNU AGPL version 3 or higher.
|
|
-}
|
|
|
|
{-# LANGUAGE TypeSynonymInstances, FlexibleInstances #-}
|
|
|
|
module Remote.Helper.Messages where
|
|
|
|
import Annex.Common
|
|
import qualified Git
|
|
import qualified Types.Remote as Remote
|
|
|
|
class Describable a where
|
|
describe :: a -> String
|
|
|
|
instance Describable Git.Repo where
|
|
describe = Git.repoDescribe
|
|
|
|
instance Describable (Remote.RemoteA a) where
|
|
describe = Remote.name
|
|
|
|
instance Describable String where
|
|
describe = id
|
|
|
|
cantCheck :: Describable a => a -> e
|
|
cantCheck v = giveup $ "unable to check " ++ describe v
|
|
|
|
showLocking :: Describable a => a -> Annex ()
|
|
showLocking v = showAction $ "locking " ++ describe v
|