1be4d281d6
FAT has a lot of characters it does not allow in filenames, like ? and * It's probably the worst offender, but other filesystems also have limitiations. In 2011, I made keyFile escape : to handle FAT, but missed the other characters. It also turns out that when I did that, I was also living dangerously; any existing keys that contained a : had their object location change. Oops. So, adding new characters to escape to keyFile is out. Well, it would be possible to make keyFile behave differently on a per-filesystem basis, but this would be a real nightmare to get right. Consider that a rsync special remote uses keyFile to determine the filenames to use, and we don't know the underlying filesystem on the rsync server.. Instead, I have gone for a solution that is backwards compatable and simple. Its only downside is that already generated URL and WORM keys might not be able to be stored on FAT or some other filesystem that dislikes a character used in the key. (In this case, the user can just migrate the problem keys to a checksumming backend. If this became a big problem, fsck could be made to detect these and suggest a migration.) Going forward, new keys that are created will escape all characters that are likely to cause problems. And if some filesystem comes along that's even worse than FAT (seems unlikely, but here it is 2013, and people are still using FAT!), additional characters can be added to the set that are escaped without difficulty. (Also, made WORM limit the part of the filename that is embedded in the key, to deal with filesystem filename length limits. This could have already been a problem, but is more likely now, since the escaping of the filename can make it longer.) This commit was sponsored by Ian Downes
43 lines
1 KiB
Haskell
43 lines
1 KiB
Haskell
{- git-annex "WORM" backend -- Write Once, Read Many
|
|
-
|
|
- Copyright 2010 Joey Hess <joey@kitenet.net>
|
|
-
|
|
- Licensed under the GNU GPL version 3 or higher.
|
|
-}
|
|
|
|
module Backend.WORM (backends) where
|
|
|
|
import Common.Annex
|
|
import Types.Backend
|
|
import Types.Key
|
|
import Types.KeySource
|
|
import Backend.Utilities
|
|
|
|
backends :: [Backend]
|
|
backends = [backend]
|
|
|
|
backend :: Backend
|
|
backend = Backend
|
|
{ name = "WORM"
|
|
, getKey = keyValue
|
|
, fsckKey = Nothing
|
|
, canUpgradeKey = Nothing
|
|
}
|
|
|
|
{- The key includes the file size, modification time, and the
|
|
- basename of the filename.
|
|
-
|
|
- That allows multiple files with the same names to have different keys,
|
|
- while also allowing a file to be moved around while retaining the
|
|
- same key.
|
|
-}
|
|
keyValue :: KeySource -> Annex (Maybe Key)
|
|
keyValue source = do
|
|
stat <- liftIO $ getFileStatus $ contentLocation source
|
|
n <- genKeyName $ keyFilename source
|
|
return $ Just Key
|
|
{ keyName = n
|
|
, keyBackendName = name backend
|
|
, keySize = Just $ fromIntegral $ fileSize stat
|
|
, keyMtime = Just $ modificationTime stat
|
|
}
|