5c32196a37
Fix process and file descriptor leak that was exposed when git-annex was built with ghc 8.2.1. Apparently ghc has changed its behavior of GC of open file handles that are pipes to running processes. That broke git-annex test on OSX due to running out of FDs. Audited for all uses of Annex.new and made stopCoProcesses be called once it's done with the state. Fixed several places that might have leaked in other situations than running the test suite. This commit was sponsored by Ewen McNeill.
32 lines
962 B
Markdown
32 lines
962 B
Markdown
### Please describe the problem.
|
|
git annex test fails outside a git repository.
|
|
|
|
[[!format sh """
|
|
$ git annex test
|
|
git-annex: Not in a git repository.
|
|
"""]]
|
|
|
|
and then some tests fail once you work around that.
|
|
[[!format sh """
|
|
Exception: getCurrentDirectory:getWorkingDirectory: resource exhausted (Too many open files)
|
|
"""]]
|
|
|
|
Exception: getCurrentDirectory:getWorkingDirectory: resource exhausted
|
|
|
|
### What steps will reproduce the problem?
|
|
Run `git annex test`.
|
|
|
|
### What version of git-annex are you using? On what operating system?
|
|
HEAD at 425a3a1 built with GHC 8.2.1.
|
|
|
|
### Please provide any additional information below.
|
|
|
|
Full log is here: https://gist.github.com/ilovezfs/1ed886b43d534b239be25f4aa8b7394e
|
|
|
|
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
|
|
|
|
Yes!
|
|
|
|
[[!meta title="OSX git-annex test fails: Too many open files"]]
|
|
|
|
> [[fixed|done]] --[[Joey]]
|