9828f45d85
This solves the problem of sameas remotes trampling over per-remote state. Used for: * per-remote state, of course * per-remote metadata, also of course * per-remote content identifiers, because two remote implementations could in theory generate the same content identifier for two different peices of content While chunk logs are per-remote data, they don't use this, because the number and size of chunks stored is a common property across sameas remotes. External special remote had a complication, where it was theoretically possible for a remote to send SETSTATE or GETSTATE during INITREMOTE or EXPORTSUPPORTED. Since the uuid of the remote is typically generate in Remote.setup, it would only be possible to pass a Maybe RemoteStateHandle into it, and it would otherwise have to construct its own. Rather than go that route, I decided to send an ERROR in this case. It seems unlikely that any existing external special remote will be affected. They would have to make up a git-annex key, and set state for some reason during INITREMOTE. I can imagine such a hack, but it doesn't seem worth complicating the code in such an ugly way to support it. Unfortunately, both TestRemote and Annex.Import needed the Remote to have a new field added that holds its RemoteStateHandle.
19 lines
560 B
Haskell
19 lines
560 B
Haskell
{- git-annex remote state handle type
|
|
-
|
|
- Copyright 2019 Joey Hess <id@joeyh.name>
|
|
-
|
|
- Licensed under the GNU AGPL version 3 or higher.
|
|
-}
|
|
|
|
module Types.RemoteState where
|
|
|
|
import Types.UUID
|
|
|
|
{- When per-remote state, its UUID is used to identify it.
|
|
-
|
|
- However, sameas remotes mean that two different Remote implementations
|
|
- can be used for the same underlying data store. To avoid them using
|
|
- state in conflicting ways, a different UUID needs to be used for each
|
|
- additional sameas remote.
|
|
-}
|
|
newtype RemoteStateHandle = RemoteStateHandle UUID
|