71ecfbfccf
This is a first step toward that goal, using the ProposedAccepted type in RemoteConfig lets initremote/enableremote reject bad parameters that were passed in a remote's configuration, while avoiding enableremote rejecting bad parameters that have already been stored in remote.log This does not eliminate every place where a remote config is parsed and a default value is used if the parse false. But, I did fix several things that expected foo=yes/no and so confusingly accepted foo=true but treated it like foo=no. There are still some fields that are parsed with yesNo but not not checked when initializing a remote, and there are other fields that are parsed in other ways and not checked when initializing a remote. This also lays groundwork for rejecting unknown/typoed config keys.
56 lines
1.8 KiB
Haskell
56 lines
1.8 KiB
Haskell
{- git-annex command
|
|
-
|
|
- Copyright 2019 Joey Hess <id@joeyh.name>
|
|
-
|
|
- Licensed under the GNU AGPL version 3 or higher.
|
|
-}
|
|
|
|
module Command.RenameRemote where
|
|
|
|
import Command
|
|
import qualified Annex.SpecialRemote
|
|
import Annex.SpecialRemote.Config (nameField, sameasNameField)
|
|
import qualified Logs.Remote
|
|
import qualified Types.Remote as R
|
|
import qualified Remote
|
|
import Types.ProposedAccepted
|
|
|
|
import qualified Data.Map as M
|
|
|
|
cmd :: Command
|
|
cmd = command "renameremote" SectionSetup
|
|
"changes name of special remote"
|
|
(paramPair paramName paramName)
|
|
(withParams seek)
|
|
|
|
seek :: CmdParams -> CommandSeek
|
|
seek = withWords (commandAction . start)
|
|
|
|
start :: [String] -> CommandStart
|
|
start (oldname:newname:[]) = Annex.SpecialRemote.findExisting oldname >>= \case
|
|
Just (u, cfg, mcu) -> Annex.SpecialRemote.findExisting newname >>= \case
|
|
Just _ -> giveup $ "The name " ++ newname ++ " is already used by a special remote."
|
|
Nothing -> go u cfg mcu
|
|
-- Support lookup by uuid or description as well as remote name,
|
|
-- as a fallback when there is nothing with the name in the
|
|
-- special remote log.
|
|
Nothing -> Remote.nameToUUID' oldname >>= \case
|
|
Left e -> giveup e
|
|
Right u -> do
|
|
m <- Logs.Remote.readRemoteLog
|
|
case M.lookup u m of
|
|
Nothing -> giveup "That is not a special remote."
|
|
Just cfg -> go u cfg Nothing
|
|
where
|
|
go u cfg mcu = starting "rename" (ActionItemOther Nothing) $
|
|
perform u cfg mcu newname
|
|
start _ = giveup "Specify an old name (or uuid or description) and a new name."
|
|
|
|
perform :: UUID -> R.RemoteConfig -> Maybe (Annex.SpecialRemote.ConfigFrom UUID) -> String -> CommandPerform
|
|
perform u cfg mcu newname = do
|
|
let (namefield, cu) = case mcu of
|
|
Nothing -> (nameField, u)
|
|
Just (Annex.SpecialRemote.ConfigFrom u') -> (sameasNameField, u')
|
|
Logs.Remote.configSet cu (M.insert namefield (Proposed newname) cfg)
|
|
|
|
next $ return True
|