mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
git-annex/Logs
History
Joey Hess 10d3b7fc62
Fix reversion introduced in 6.20171214 that caused concurrent transfers to incorrectly fail with "transfer already in progress". 
Avoid creating transfer info file before transfer lock is created and
locked.

The wrong order for one thing caused transfer info to be overwritten
when a transfer was already in progress.

But worse, it caused checkTransfer to see the transfer info,
and so lock the transfer lock in order to verify the transfer was not in
progress. Which in a concurrent situation, prevented the transferrer
from locking the transfer lock, so it failed with "transfer already in
progress".

Note that the transferinfo command does not lock the transfer lock
before creating the transfer info. But, that's only run after
recvkey is running, and recvkey does lock the transfer lock, so that
seems more or less ok. (Other than being a super complicated legacy mess
that the P2P code has mostly obsoleted now.)

This commit was supported by the NSF-funded DataLad project.
2018-03-14 18:55:34 -04:00
..
Chunk remove 163 lines of code without changing anything except imports 2016-01-20 16:36:33 -04:00
Difference remove 163 lines of code without changing anything except imports 2016-01-20 16:36:33 -04:00
PreferredContent Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Presence avoid accidental Show of VectorClock 2017-08-14 14:51:54 -04:00
Trust Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Activity.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Chunk.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Config.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Difference.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Export.hs cleanup imports 2017-09-13 12:53:19 -04:00
File.hs more core.sharedRepository perm fixes 2018-01-04 14:46:58 -04:00
FsckResults.hs Fix several places where files in .git/annex/ were written with modes that did not take the core.sharedRepository config into account. 2018-01-02 17:25:25 -04:00
Group.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Line.hs Split lines in the git-annex branch on \r as well as \n, to deal with \r\n terminated lines written by some versions of git-annex on Windows. 2016-05-27 11:45:13 -04:00
Location.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
MapLog.hs avoid accidental Show of VectorClock 2017-08-14 14:51:54 -04:00
MetaData.hs Warn when metadata is inherited from a previous version of a file 2017-09-28 12:56:35 -04:00
Multicast.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
NumCopies.hs vicfg: Include the numcopies configuation. 2017-01-30 15:27:25 -04:00
PreferredContent.hs Limit annex.largefiles parsing to the subset of preferred content expressions that make sense in its context. 2016-02-03 15:04:42 -04:00
Presence.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Remote.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
RemoteState.hs Added GIT_ANNEX_VECTOR_CLOCK environment variable 2017-08-14 14:19:58 -04:00
Schedule.hs Fix several places where files in .git/annex/ were written with modes that did not take the core.sharedRepository config into account. 2018-01-02 17:25:25 -04:00
SingleValue.hs avoid accidental Show of VectorClock 2017-08-14 14:51:54 -04:00
TimeStamp.hs Optimised git-annex branch log file timestamp parsing. 10% speedup 2016-09-29 14:04:53 -04:00
Transfer.hs Fix reversion introduced in 6.20171214 that caused concurrent transfers to incorrectly fail with "transfer already in progress". 2018-03-14 18:55:34 -04:00
Transitions.hs avoid accidental Show of VectorClock 2017-08-14 14:51:54 -04:00
Trust.hs Allow exporttree remotes to be marked as dead. 2017-12-05 13:46:55 -04:00
Unused.hs Fix several places where files in .git/annex/ were written with modes that did not take the core.sharedRepository config into account. 2018-01-02 17:25:25 -04:00
UUID.hs remove dead code 2017-11-07 14:18:10 -04:00
UUIDBased.hs avoid accidental Show of VectorClock 2017-08-14 14:51:54 -04:00
View.hs Fix several places where files in .git/annex/ were written with modes that did not take the core.sharedRepository config into account. 2018-01-02 17:25:25 -04:00
Web.hs wip 2017-11-28 17:17:40 -04:00