ed0afbc36b
Seem there are several races that happen when 2 threads run PidLock.tryLock at the same time. One involves checkSaneLock of the side lock file, which may be deleted by another process that is dropping the lock, causing checkSaneLock to fail. And even with the deletion disabled, it can still fail, Probably due to linkToLock failing when a second thread overwrites the lock file. The same can happen when 2 processes do, but then one process just fails to take the lock, which is fine. But with 2 threads, some actions where failing even though the process as a whole had the pid lock held. Utility.LockPool.PidLock already maintains a STM lock, and since it uses LockShared, 2 threads can hold the pidlock at the same time, and when the first thread drops the lock, it will remain held by the second thread, and so the pid lock file should not get deleted until the last thread to hold it drops the lock. Which is the right behavior, and why a LockShared STM lock is used in the first place. The problem is that each time it takes the STM lock, it then also calls PidLock.tryLock. So that was getting called repeatedly and concurrently. Fixed by noticing when the shared lock is already held, and stop calling PidLock.tryLock again, just use the pid lock that already exists then. Also, LockFile.PidLock.tryLock was deleting the pid lock when it failed to take the lock, which was entirely wrong. It should only drop the side lock. Sponsored-by: Dartmouth College's Datalad project
153 lines
5.1 KiB
Haskell
153 lines
5.1 KiB
Haskell
{- STM implementation of lock pools.
|
|
-
|
|
- Copyright 2015-2021 Joey Hess <id@joeyh.name>
|
|
-
|
|
- License: BSD-2-clause
|
|
-}
|
|
|
|
module Utility.LockPool.STM (
|
|
LockPool,
|
|
lockPool,
|
|
LockFile,
|
|
LockMode(..),
|
|
LockHandle,
|
|
FirstLock(..),
|
|
FirstLockSemVal(..),
|
|
waitTakeLock,
|
|
tryTakeLock,
|
|
getLockStatus,
|
|
releaseLock,
|
|
CloseLockFile,
|
|
registerCloseLockFile,
|
|
) where
|
|
|
|
import Utility.Monad
|
|
|
|
import System.IO.Unsafe (unsafePerformIO)
|
|
import System.FilePath.ByteString (RawFilePath)
|
|
import qualified Data.Map.Strict as M
|
|
import Control.Concurrent.STM
|
|
import Control.Exception
|
|
import Control.Monad
|
|
|
|
type LockFile = RawFilePath
|
|
|
|
data LockMode = LockExclusive | LockShared
|
|
deriving (Eq)
|
|
|
|
-- This TMVar is full when the handle is open, and is emptied when it's
|
|
-- closed.
|
|
type LockHandle = TMVar (LockPool, LockFile, CloseLockFile)
|
|
|
|
-- When a shared lock is taken, this will only be true for the first
|
|
-- process, not subsequent processes. The first process should
|
|
-- fill the FirstLockSem after doing any IO actions to finish lock setup
|
|
-- and subsequent processes can block on that getting filled to know
|
|
-- when the lock is fully set up.
|
|
data FirstLock = FirstLock Bool FirstLockSem
|
|
|
|
type FirstLockSem = TMVar FirstLockSemVal
|
|
|
|
data FirstLockSemVal = FirstLockSemWaited Bool | FirstLockSemTried Bool
|
|
|
|
type LockCount = Integer
|
|
|
|
data LockStatus = LockStatus LockMode LockCount FirstLockSem
|
|
|
|
type CloseLockFile = IO ()
|
|
|
|
-- This TMVar is normally kept full.
|
|
type LockPool = TMVar (M.Map LockFile LockStatus)
|
|
|
|
-- A shared global variable for the lockPool. Avoids callers needing to
|
|
-- maintain state for this implementation detail.
|
|
{-# NOINLINE lockPool #-}
|
|
lockPool :: LockPool
|
|
lockPool = unsafePerformIO (newTMVarIO M.empty)
|
|
|
|
-- Updates the LockPool, blocking as necessary if another thread is holding
|
|
-- a conflicting lock.
|
|
--
|
|
-- Note that when a shared lock is held, an exclusive lock will block.
|
|
-- While that blocking is happening, another call to this function to take
|
|
-- the same shared lock should not be blocked on the exclusive lock.
|
|
-- Keeping the whole Map in a TMVar accomplishes this, at the expense of
|
|
-- sometimes retrying after unrelated changes in the map.
|
|
waitTakeLock :: LockPool -> LockFile -> LockMode -> STM (LockHandle, FirstLock)
|
|
waitTakeLock pool file mode = maybe retry return =<< tryTakeLock pool file mode
|
|
|
|
-- Avoids blocking if another thread is holding a conflicting lock.
|
|
tryTakeLock :: LockPool -> LockFile -> LockMode -> STM (Maybe (LockHandle, FirstLock))
|
|
tryTakeLock pool file mode = do
|
|
m <- takeTMVar pool
|
|
let success firstlock v = do
|
|
putTMVar pool (M.insert file v m)
|
|
tmv <- newTMVar (pool, file, noop)
|
|
return (Just (tmv, firstlock))
|
|
case M.lookup file m of
|
|
Just (LockStatus mode' n firstlocksem)
|
|
| mode == LockShared && mode' == LockShared -> do
|
|
fl@(FirstLock _ firstlocksem') <- if n == 0
|
|
then FirstLock True <$> newEmptyTMVar
|
|
else pure (FirstLock False firstlocksem)
|
|
success fl $ LockStatus mode (succ n) firstlocksem'
|
|
| n > 0 -> do
|
|
putTMVar pool m
|
|
return Nothing
|
|
_ -> do
|
|
firstlocksem <- newEmptyTMVar
|
|
success (FirstLock True firstlocksem) $ LockStatus mode 1 firstlocksem
|
|
|
|
-- Call after waitTakeLock or tryTakeLock, to register a CloseLockFile
|
|
-- action to run when releasing the lock.
|
|
registerCloseLockFile :: LockHandle -> CloseLockFile -> STM ()
|
|
registerCloseLockFile h closelockfile = do
|
|
(p, f, c) <- takeTMVar h
|
|
putTMVar h (p, f, c >> closelockfile)
|
|
|
|
-- Checks if a lock is being held. If it's held by the current process,
|
|
-- runs the getdefault action; otherwise runs the checker action.
|
|
--
|
|
-- Note that the lock pool is left empty while the checker action is run.
|
|
-- This allows checker actions that open/close files, and so would be in
|
|
-- danger of conflicting with locks created at the same time this is
|
|
-- running. With the lock pool empty, anything that attempts
|
|
-- to take a lock will block, avoiding that race.
|
|
getLockStatus :: LockPool -> LockFile -> IO v -> IO v -> IO v
|
|
getLockStatus pool file getdefault checker = do
|
|
v <- atomically $ do
|
|
m <- takeTMVar pool
|
|
let threadlocked = case M.lookup file m of
|
|
Just (LockStatus _ n _) | n > 0 -> True
|
|
_ -> False
|
|
if threadlocked
|
|
then do
|
|
putTMVar pool m
|
|
return Nothing
|
|
else return $ Just $ atomically $ putTMVar pool m
|
|
case v of
|
|
Nothing -> getdefault
|
|
Just restore -> bracket_ (return ()) restore checker
|
|
|
|
-- Only runs action to close underlying lock file when this is the last
|
|
-- user of the lock, and when the lock has not already been closed.
|
|
--
|
|
-- Note that the lock pool is left empty while the CloseLockFile action
|
|
-- is run, to avoid race with another thread trying to open the same lock
|
|
-- file.
|
|
releaseLock :: LockHandle -> IO ()
|
|
releaseLock h = go =<< atomically (tryTakeTMVar h)
|
|
where
|
|
go (Just (pool, file, closelockfile)) = do
|
|
(m, lastuser) <- atomically $ do
|
|
m <- takeTMVar pool
|
|
return $ case M.lookup file m of
|
|
Just (LockStatus mode n firstlocksem)
|
|
| n == 1 -> (M.delete file m, True)
|
|
| otherwise ->
|
|
(M.insert file (LockStatus mode (pred n) firstlocksem) m, False)
|
|
Nothing -> (m, True)
|
|
() <- when lastuser closelockfile
|
|
atomically $ putTMVar pool m
|
|
-- The LockHandle was already closed.
|
|
go Nothing = return ()
|