
However, filepath-bytestring is still in Setup-Depends. That's because Utility.OsPath uses it when not built with OsPath. It would be maybe possible to make Utility.OsPath fall back to using filepath, and eliminate that dependency too, but it would mean either wrapping all of System.FilePath's functions, or using `type OsPath = FilePath` Annex.Import uses ifdefs to avoid converting back to FilePath when not on windows. On windows it's a bit slower due to that conversion. Utility.Path.Windows.convertToWindowsNativeNamespace got a bit slower too, but not really worth optimising I think. Note that importing Utility.FileSystemEncoding at the same time as System.Posix.ByteString will result in conflicting definitions for RawFilePath. filepath-bytestring avoids that by importing RawFilePath from System.Posix.ByteString, but that's not possible in Utility.FileSystemEncoding, since Setup-Depends does not include unix. This turned out not to affect any code in git-annex though. Sponsored-by: Leon Schuermann
28 lines
590 B
Haskell
28 lines
590 B
Haskell
{- openFd wrapper to support old versions of unix package.
|
|
-
|
|
- Copyright 2023 Joey Hess <id@joeyh.name>
|
|
-
|
|
- License: BSD-2-clause
|
|
-}
|
|
|
|
{-# LANGUAGE CPP #-}
|
|
{-# OPTIONS_GHC -fno-warn-tabs #-}
|
|
|
|
module Utility.OpenFd where
|
|
|
|
#ifndef mingw32_HOST_OS
|
|
|
|
import System.Posix.IO.ByteString
|
|
import System.Posix.Types
|
|
|
|
import Utility.RawFilePath
|
|
|
|
openFdWithMode :: RawFilePath -> OpenMode -> Maybe FileMode -> OpenFileFlags -> IO Fd
|
|
#if MIN_VERSION_unix(2,8,0)
|
|
openFdWithMode f openmode filemode flags =
|
|
openFd f openmode (flags { creat = filemode })
|
|
#else
|
|
openFdWithMode = openFd
|
|
#endif
|
|
|
|
#endif
|