34c8af74ba
I've been disliking how the command seek actions were written for some time, with their inversion of control and ugly workarounds. The last straw to fix it was sync --content, which didn't fit the Annex [CommandStart] interface well at all. I have not yet made it take advantage of the changed interface though. The crucial change, and probably why I didn't do it this way from the beginning, is to make each CommandStart action be run with exceptions caught, and if it fails, increment a failure counter in annex state. So I finally remove the very first code I wrote for git-annex, which was before I had exception handling in the Annex monad, and so ran outside that monad, passing state explicitly as it ran each CommandStart action. This was a real slog from 1 to 5 am. Test suite passes. Memory usage is lower than before, sometimes by a couple of megabytes, and remains constant, even when running in a large repo, and even when repeatedly failing and incrementing the error counter. So no accidental laziness space leaks. Wall clock speed is identical, even in large repos. This commit was sponsored by an anonymous bitcoiner.
40 lines
1.2 KiB
Haskell
40 lines
1.2 KiB
Haskell
{- git-annex command
|
|
-
|
|
- Copyright 2010 Joey Hess <joey@kitenet.net>
|
|
-
|
|
- Licensed under the GNU GPL version 3 or higher.
|
|
-}
|
|
|
|
module Command.Copy where
|
|
|
|
import Common.Annex
|
|
import Command
|
|
import GitAnnex.Options
|
|
import qualified Command.Move
|
|
import qualified Remote
|
|
import Annex.Wanted
|
|
|
|
def :: [Command]
|
|
def = [withOptions Command.Move.moveOptions $ command "copy" paramPaths seek
|
|
SectionCommon "copy content of files to/from another repository"]
|
|
|
|
seek :: CommandSeek
|
|
seek ps = do
|
|
to <- getOptionField toOption Remote.byNameWithUUID
|
|
from <- getOptionField fromOption Remote.byNameWithUUID
|
|
withKeyOptions
|
|
(Command.Move.startKey to from False)
|
|
(withFilesInGit $ whenAnnexed $ start to from)
|
|
ps
|
|
|
|
{- A copy is just a move that does not delete the source file.
|
|
- However, --auto mode avoids unnecessary copies, and avoids getting or
|
|
- sending non-preferred content. -}
|
|
start :: Maybe Remote -> Maybe Remote -> FilePath -> (Key, Backend) -> CommandStart
|
|
start to from file (key, backend) = stopUnless shouldCopy $
|
|
Command.Move.start to from False file (key, backend)
|
|
where
|
|
shouldCopy = checkAuto (check <||> numCopiesCheck file key (<))
|
|
check = case to of
|
|
Nothing -> wantGet False (Just file)
|
|
Just r -> wantSend False (Just file) (Remote.uuid r)
|