a7156b875c
75aab72d23 made fsck skip files whose
content is not present, but it should complain if there are not enough
copies.
26 lines
1 KiB
Markdown
26 lines
1 KiB
Markdown
Recent optimisation work has caused some test suite failures, involving
|
|
unannex and fsck. --[[Joey]]
|
|
|
|
Hmm, the unannex one is because it doesn't check if a file is present
|
|
inAnnex anymore, so fails on unannexing a non-present file.
|
|
|
|
The check was removed in
|
|
[[!commit 75aab72d23ebf8ef0d56d7dd74c121e33d64f1f6]], but that did have
|
|
withFilesInGitAnnex doing an inAnnex check and not running the command if
|
|
it failed. But later that got changed to only happen when
|
|
checkContentPresent is set.
|
|
|
|
Everything in that and related commits
|
|
needs to be re-examined to make sure no other inAnnex checks were lost.
|
|
|
|
> Well, I didn't find any others.
|
|
|
|
The fsck failure is that it fails to fail when there are 0 copies of the
|
|
file. Same basic cause, but the other direction, it was skipping files
|
|
whose content is not present. Also introduced in [[!commit
|
|
75aab72d23ebf8ef0d56d7dd74c121e33d64f1f6]].
|
|
|
|
So, also need to audit everything with checkContentPresent = Just True
|
|
etc to make sure it's right. Ok, done, there were not many using it yet.
|
|
|
|
[[done]] --[[Joey]]
|