591e4b145f
This preserves the workaround for the old bug that caused NoUUID items to be stored in the log, prefixing log lines with " ". It's now handled implicitly, by using takeWhile1 (/= ' ') to get the uuid. There is a behavior change from the old parser, which split the value into words and then recombined it. That meant that "foo bar" and "foo\tbar" came out as "foo bar". That behavior was not documented, and seems surprising; it meant that after a git-annex describe here "foo bar", you wouldn't get that same string back out when git-annex displayed repo descriptions. Otoh, some other parsers relied on the old behavior, and the attoparsec rewrites had to deal with the issue themselves... For group.log, there are some edge cases around the user providing a group name with a leading or trailing space. The old parser would ignore such excess whitespace. The new parser does too, because the alternative is to refuse to parse something like " group1 group2 " due to excess whitespace, which would be even more confusing behavior. The only git-annex branch log file that is not converted to attoparsec and bytestring-builder now is transitions.log.
52 lines
1.4 KiB
Haskell
52 lines
1.4 KiB
Haskell
{- git-annex activity log
|
|
-
|
|
- Copyright 2015-2019 Joey Hess <id@joeyh.name>
|
|
-
|
|
- Licensed under the GNU GPL version 3 or higher.
|
|
-}
|
|
|
|
module Logs.Activity (
|
|
Log,
|
|
Activity(..),
|
|
recordActivity,
|
|
lastActivities,
|
|
) where
|
|
|
|
import Annex.Common
|
|
import qualified Annex.Branch
|
|
import Logs
|
|
import Logs.UUIDBased
|
|
|
|
import qualified Data.ByteString as S
|
|
import qualified Data.Attoparsec.ByteString as A
|
|
import Data.ByteString.Builder
|
|
|
|
data Activity
|
|
= Fsck
|
|
deriving (Eq, Read, Show, Enum, Bounded)
|
|
|
|
recordActivity :: Activity -> UUID -> Annex ()
|
|
recordActivity act uuid = do
|
|
c <- liftIO currentVectorClock
|
|
Annex.Branch.change activityLog $
|
|
buildLog buildActivity
|
|
. changeLog c uuid (Right act)
|
|
. parseLog parseActivity
|
|
|
|
lastActivities :: Maybe Activity -> Annex (Log Activity)
|
|
lastActivities wantact = parseLog (onlywanted =<< parseActivity)
|
|
<$> Annex.Branch.get activityLog
|
|
where
|
|
onlywanted (Right a) | wanted a = pure a
|
|
onlywanted _ = fail "unwanted activity"
|
|
wanted a = maybe True (a ==) wantact
|
|
|
|
buildActivity :: Either S.ByteString Activity -> Builder
|
|
buildActivity (Right a) = byteString $ encodeBS $ show a
|
|
buildActivity (Left b) = byteString b
|
|
|
|
-- Allow for unknown activities to be added later by preserving them.
|
|
parseActivity :: A.Parser (Either S.ByteString Activity)
|
|
parseActivity = go <$> A.takeByteString
|
|
where
|
|
go b = maybe (Left b) Right $ readish $ decodeBS b
|