cf07a2c412
There was confusion in different parts of the progress bar code about whether an update contained the total number of bytes transferred, or the number of bytes transferred since the last update. One way this bug showed up was progress bars that seemed to stick at zero for a long time. In order to fix it comprehensively, I add a new BytesProcessed data type, that is explicitly a total quantity of bytes, not a delta. Note that this doesn't necessarily fix every problem with progress bars. Particularly, buffering can now cause progress bars to seem to run ahead of transfers, reaching 100% when data is still being uploaded.
26 lines
1.1 KiB
Markdown
26 lines
1.1 KiB
Markdown
## What steps will reproduce the problem?
|
|
|
|
Add new data to a repository with an S3 special remote. Monitor the repository with the web app.
|
|
|
|
|
|
## What is the expected output? What do you see instead?
|
|
|
|
I expect a changing status bar and percentage. Instead I see no changes when an upload becomes active.
|
|
|
|
|
|
## What version of git-annex are you using? On what operating system?
|
|
|
|
3.20130102 on Arch 64-bit.
|
|
|
|
|
|
## Please provide any additional information below.
|
|
|
|
|
|
When uploading local data to an S3 remote, I see no progress bars. The progress bar area on active uploads stays the same grey as the bar on queued uploads. The status does not change from "0% of...". The uploads are completing, but this makes it very difficult to judge their activity.
|
|
|
|
The only remotes I currently have setup are S3 special remotes, so I cannot say whether progress bars are working for uploads to other remote types.
|
|
|
|
> [[done]], this turned out to be a confusion in the progress code;
|
|
> parts were expecting a full number of bytes since the start, while
|
|
> other parts were sending the number of bytes in a chunk. Result was
|
|
> progress bars stuck at 0% often. --[[Joey]]
|