345ee4f37c
As seen in this bug report, the lifted exception handling using the StateT monad throws away state changes when an action throws an exception. http://git-annex.branchable.com/bugs/git_annex_fork_bombs_on_gpg_file/ .. Which can result in cached values being redundantly calculated, or other possibly worse bugs when the annex state gets out of sync with reality. This switches from a StateT AnnexState to a ReaderT (MVar AnnexState). All changes to the state go via the MVar. So when an Annex action is running inside an exception handler, and it makes some changes, they immediately go into affect in the MVar. If it then throws an exception (or even crashes its thread!), the state changes are still in effect. The MonadCatchIO-transformers change is actually only incidental. I could have kept on using lifted-base for the exception handling. However, I'd have needed to write a new instance of MonadBaseControl for the new monad.. and I didn't write the old instance.. I begged Bas and he kindly sent it to me. Happily, MonadCatchIO-transformers is able to derive a MonadCatchIO instance for my monad. This is a deep level change. It passes the test suite! What could it break? Well.. The most likely breakage would be to code that runs an Annex action in an exception handler, and *wants* state changes to be thrown away. Perhaps the state changes leaves the state inconsistent, or wrong. Since there are relatively few places in git-annex that catch exceptions in the Annex monad, and the AnnexState is generally just used to cache calculated data, this is unlikely to be a problem. Oh yeah, this change also makes Assistant.Types.ThreadedMonad a bit redundant. It's now entirely possible to run concurrent Annex actions in different threads, all sharing access to the same state! The ThreadedMonad just adds some extra work on top of that, with its own MVar, and avoids such actions possibly stepping on one-another's toes. I have not gotten rid of it, but might try that later. Being able to run concurrent Annex actions would simplify parts of the Assistant code. |
||
|---|---|---|
| .. | ||
| Android | ||
| android | ||
| assistant | ||
| backends | ||
| bare_repositories | ||
| bugs | ||
| design | ||
| direct_mode | ||
| download | ||
| encryption | ||
| footer | ||
| forum | ||
| install | ||
| internals | ||
| license | ||
| links | ||
| news | ||
| not | ||
| preferred_content | ||
| special_remotes | ||
| sync | ||
| templates | ||
| tips | ||
| todo | ||
| upgrades | ||
| use_case | ||
| users | ||
| videos | ||
| walkthrough | ||
| Android.mdwn | ||
| assistant.mdwn | ||
| backends.mdwn | ||
| bare_repositories.mdwn | ||
| bugs.mdwn | ||
| coding_style.mdwn | ||
| comments.mdwn | ||
| contact.mdwn | ||
| copies.mdwn | ||
| design.mdwn | ||
| direct_mode.mdwn | ||
| distributed_version_control.mdwn | ||
| download.mdwn | ||
| encryption.mdwn | ||
| favicon.ico | ||
| feeds.mdwn | ||
| forum.mdwn | ||
| future_proofing.mdwn | ||
| git-annex-shell.mdwn | ||
| git-annex.mdwn | ||
| git-union-merge.mdwn | ||
| how_it_works.mdwn | ||
| index.mdwn | ||
| install.mdwn | ||
| internals.mdwn | ||
| license.mdwn | ||
| location_tracking.mdwn | ||
| logo-bw.svg | ||
| logo.png | ||
| logo.svg | ||
| logo_small.png | ||
| meta.mdwn | ||
| news.mdwn | ||
| not.mdwn | ||
| preferred_content.mdwn | ||
| related_software.mdwn | ||
| repomap.png | ||
| scalability.mdwn | ||
| sidebar.mdwn | ||
| sitemap.mdwn | ||
| special_remotes.mdwn | ||
| summary.mdwn | ||
| sync.mdwn | ||
| testimonials.mdwn | ||
| tips.mdwn | ||
| todo.mdwn | ||
| transferring_data.mdwn | ||
| trust.mdwn | ||
| upgrades.mdwn | ||
| users.mdwn | ||
| videos.mdwn | ||
| walkthrough.mdwn | ||
