de138c642b
* p2phttp: Allow unauthenticated users to lock content by default. * p2phttp: Added --unauth-nolocking option to prevent unauthenticated users from locking content. The rationalle for this is that locking is not really a write operation, so makes sense to allow in a repository that only allows read-only access. Not supporting locking in that situation will prevent the user from dropping content from a special remote they control in cases where the other copy of the content is on the p2phttp server. Also, when p2phttp is configured to also allow authenticated access, lockcontent was resulting in a password prompt for users who had no way to authenticate. And there is no good way to distinguish between the two types of users client side. --unauth-nolocking anticipates that this might be abused, and seems better than disabling unauthenticated access entirely if a server is being attacked. It may be that rate limiting locking by IP address or similar would be an effective measure in such a situation. Or just limiting the number of locks by anonymous users that can be live at any one time. Since the impact of such an DOS attempt is limited to preventing dropping content from the server, it seems not a very appealing target anyway. |
||
|---|---|---|
| .. | ||
| comment_1_c40d58f34ec183e51c6d97571be7bb65._comment | ||
| comment_2_be1f58d6c49a69ddae692cef911245be._comment | ||
| comment_3_83dc4e317e09ad1e24fdd3ee347edb43._comment | ||
| comment_4_0d0e163ac91cceb3840779f6bbb5dd1c._comment | ||
| comment_5_f4cd5bba64cc01813591ea6fc2f0c55c._comment | ||
| comment_6_f883c505182b6b740081beaa0871b9a9._comment | ||
| comment_7_8c1a79bda3984d321c51f5922075715f._comment | ||
| comment_8_f5564bbd7fd27a2488877c0d641441c0._comment | ||
| comment_9_9e0afd6ffae1545392af59b60e539e9e._comment | ||
| comment_10_34c0c0e2bcd28f95a5aef47652c0f18e._comment | ||