34c8af74ba
I've been disliking how the command seek actions were written for some time, with their inversion of control and ugly workarounds. The last straw to fix it was sync --content, which didn't fit the Annex [CommandStart] interface well at all. I have not yet made it take advantage of the changed interface though. The crucial change, and probably why I didn't do it this way from the beginning, is to make each CommandStart action be run with exceptions caught, and if it fails, increment a failure counter in annex state. So I finally remove the very first code I wrote for git-annex, which was before I had exception handling in the Annex monad, and so ran outside that monad, passing state explicitly as it ran each CommandStart action. This was a real slog from 1 to 5 am. Test suite passes. Memory usage is lower than before, sometimes by a couple of megabytes, and remains constant, even when running in a large repo, and even when repeatedly failing and incrementing the error counter. So no accidental laziness space leaks. Wall clock speed is identical, even in large repos. This commit was sponsored by an anonymous bitcoiner.
56 lines
1.5 KiB
Haskell
56 lines
1.5 KiB
Haskell
{- git-annex command
|
|
-
|
|
- Copyright 2013 Joey Hess <joey@kitenet.net>
|
|
-
|
|
- Licensed under the GNU GPL version 3 or higher.
|
|
-}
|
|
|
|
module Command.EnableRemote where
|
|
|
|
import Common.Annex
|
|
import Command
|
|
import qualified Logs.Remote
|
|
import qualified Types.Remote as R
|
|
import qualified Command.InitRemote as InitRemote
|
|
|
|
import qualified Data.Map as M
|
|
|
|
def :: [Command]
|
|
def = [command "enableremote"
|
|
(paramPair paramName $ paramOptional $ paramRepeating paramKeyValue)
|
|
seek SectionSetup "enables use of an existing special remote"]
|
|
|
|
seek :: CommandSeek
|
|
seek = withWords start
|
|
|
|
start :: [String] -> CommandStart
|
|
start [] = unknownNameError "Specify the name of the special remote to enable."
|
|
start (name:ws) = go =<< InitRemote.findExisting name
|
|
where
|
|
config = Logs.Remote.keyValToConfig ws
|
|
|
|
go Nothing = unknownNameError "Unknown special remote name."
|
|
go (Just (u, c)) = do
|
|
let fullconfig = config `M.union` c
|
|
t <- InitRemote.findType fullconfig
|
|
|
|
showStart "enableremote" name
|
|
next $ perform t u fullconfig
|
|
|
|
unknownNameError :: String -> Annex a
|
|
unknownNameError prefix = do
|
|
names <- InitRemote.remoteNames
|
|
error $ prefix ++ "\n" ++
|
|
if null names
|
|
then "(No special remotes are currently known; perhaps use initremote instead?)"
|
|
else "Known special remotes: " ++ unwords names
|
|
|
|
perform :: RemoteType -> UUID -> R.RemoteConfig -> CommandPerform
|
|
perform t u c = do
|
|
(c', u') <- R.setup t (Just u) c
|
|
next $ cleanup u' c'
|
|
|
|
cleanup :: UUID -> R.RemoteConfig -> CommandCleanup
|
|
cleanup u c = do
|
|
Logs.Remote.configSet u c
|
|
return True
|