1243af4a18
Added Maybe POSIXTime to SafeDropProof, which gets set when the proof is based on a LockedCopy. If there are several LockedCopies, it uses the closest expiry time. That is not optimal, it may be that the proof expires based on one LockedCopy but another one has not expired. But that seems unlikely to really happen, and anyway the user can just re-run a drop if it fails due to expiry. Pass the SafeDropProof to removeKey, which is responsible for checking it for expiry in situations where that could be a problem. Which really only means in Remote.Git. Made Remote.Git check expiry when dropping from a local remote. Checking expiry when dropping from a P2P remote is not yet implemented. P2P.Protocol.remove has SafeDropProof plumbed through to it for that purpose. Fixing the remaining 2 build warnings should complete this work. Note that the use of a POSIXTime here means that if the clock gets set forward while git-annex is in the middle of a drop, it may say that dropping took too long. That seems ok. Less ok is that if the clock gets turned back a sufficient amount (eg 5 minutes), proof expiry won't be noticed. It might be better to use the Monotonic clock, but that doesn't advance when a laptop is suspended, and while there is the linux Boottime clock, that is not available on other systems. Perhaps a combination of POSIXTime and the Monotonic clock could detect laptop suspension and also detect clock being turned back? There is a potential future flag day where p2pDefaultLockContentRetentionDuration is not assumed, but is probed using the P2P protocol, and peers that don't support it can no longer produce a LockedCopy. Until that happens, when git-annex is communicating with older peers there is a risk of data loss when a ssh connection closes during LOCKCONTENT.
75 lines
2.4 KiB
Haskell
75 lines
2.4 KiB
Haskell
{- Adds readonly support to remotes.
|
|
-
|
|
- Copyright 2013-2019 Joey Hess <id@joeyh.name>
|
|
-
|
|
- Licensed under the GNU AGPL version 3 or higher.
|
|
-}
|
|
|
|
module Remote.Helper.ReadOnly
|
|
( adjustReadOnly
|
|
, readonlyStoreKey
|
|
, readonlyStorer
|
|
, readonlyRemoveKey
|
|
) where
|
|
|
|
import Annex.Common
|
|
import Types.Remote
|
|
import Types.StoreRetrieve
|
|
import Types.Import
|
|
import Types.Export
|
|
import Utility.Metered
|
|
|
|
{- Adds support for read-only remotes, by replacing the
|
|
- methods that write to a remote with dummies that fail.
|
|
-
|
|
- Note that disabling git pushes to remotes is not handled here.
|
|
-}
|
|
adjustReadOnly :: Remote -> Remote
|
|
adjustReadOnly r
|
|
| remoteAnnexReadOnly (gitconfig r) = r
|
|
{ storeKey = readonlyStoreKey
|
|
, removeKey = readonlyRemoveKey
|
|
, repairRepo = Nothing
|
|
, exportActions = (exportActions r)
|
|
{ storeExport = readonlyStoreExport
|
|
, removeExport = readonlyRemoveExport
|
|
, removeExportDirectory = Just readonlyRemoveExportDirectory
|
|
, renameExport = Nothing
|
|
}
|
|
, importActions = (importActions r)
|
|
{ storeExportWithContentIdentifier = readonlyStoreExportWithContentIdentifier
|
|
, removeExportWithContentIdentifier = readonlyRemoveExportWithContentIdentifier
|
|
, removeExportDirectoryWhenEmpty = Just readonlyRemoveExportDirectory
|
|
}
|
|
}
|
|
| otherwise = r
|
|
|
|
readonlyStoreKey :: Key -> AssociatedFile -> Maybe FilePath -> MeterUpdate -> Annex ()
|
|
readonlyStoreKey _ _ _ _ = readonlyFail
|
|
|
|
readonlyRemoveKey :: Maybe SafeDropProof -> Key -> Annex ()
|
|
readonlyRemoveKey _ _ = readonlyFail
|
|
|
|
readonlyStorer :: Storer
|
|
readonlyStorer _ _ _ = readonlyFail
|
|
|
|
readonlyStoreExport :: FilePath -> Key -> ExportLocation -> MeterUpdate -> Annex ()
|
|
readonlyStoreExport _ _ _ _ = readonlyFail
|
|
|
|
readonlyRemoveExport :: Key -> ExportLocation -> Annex ()
|
|
readonlyRemoveExport _ _ = readonlyFail
|
|
|
|
readonlyRemoveExportDirectory :: ExportDirectory -> Annex ()
|
|
readonlyRemoveExportDirectory _ = readonlyFail
|
|
|
|
readonlyStoreExportWithContentIdentifier :: FilePath -> Key -> ExportLocation -> [ContentIdentifier] -> MeterUpdate -> Annex ContentIdentifier
|
|
readonlyStoreExportWithContentIdentifier _ _ _ _ _ = readonlyFail
|
|
|
|
readonlyRemoveExportWithContentIdentifier :: Key -> ExportLocation -> [ContentIdentifier] -> Annex ()
|
|
readonlyRemoveExportWithContentIdentifier _ _ _ = readonlyFail
|
|
|
|
readonlyFail :: Annex a
|
|
readonlyFail = giveup readonlyWarning
|
|
|
|
readonlyWarning :: String
|
|
readonlyWarning = "this remote is readonly"
|