Commit graph

11574 commits

Author SHA1 Message Date
hoegiflo@befdf51af27be5af346451fe32863dadb1d37ad5
b47ea090ca 2022-08-24 18:43:15 +00:00
hoegiflo@befdf51af27be5af346451fe32863dadb1d37ad5
7c4b37a7b1 2022-08-24 18:41:37 +00:00
Joey Hess
55bf1c6896
comment 2022-08-24 13:05:15 -04:00
Ilya_Shlyakhter
cfad39ccb4 added bug report about a cryptic error message when copying to S3 2022-08-24 14:47:16 +00:00
Ilya_Shlyakhter
274ef9db2a Added a comment: imports and symlinks 2022-08-22 20:40:42 +00:00
Joey Hess
28921af543
remove old closed bugs and todo items to speed up wiki updates and reduce size
Remove closed bugs and todos that were last edited or commented before 2021.

Except for ones tagged projects/* since projects like datalad want to keep
around records of old deleted bugs longer.

Command line used:

    for f in $(grep -l '|done\]\]' -- ./*.mdwn); do if ! grep -q "projects/" "$f"; then d="$(echo "$f" | sed 's/.mdwn$//')"; if [ -z "$(git log --since=01-01-2021 --pretty=oneline -- "$f")" -a -z "$(git log --since=01-01-2021 --pretty=oneline -- "$d")" ]; then git rm -- "./$f" ; git rm -rf "./$d"; fi; fi; done
    for f in $(grep -l '\[\[done\]\]' -- ./*.mdwn); do if ! grep -q "projects/" "$f"; then d="$(echo "$f" | sed 's/.mdwn$//')"; if [ -z "$(git log --since=01-01-2021 --pretty=oneline -- "$f")" -a -z "$(git log --since=01-01-2021 --pretty=oneline -- "$d")" ]; then git rm -- "./$f" ; git rm -rf "./$d"; fi; fi; done
2022-08-22 12:27:10 -04:00
Joey Hess
c13b3aba98
add comment (and other old comment I forgot to add earlier) 2022-08-22 12:01:29 -04:00
Joey Hess
3ce71cad8c
Merge branch 'master' of ssh://git-annex.branchable.com 2022-08-22 11:50:21 -04:00
Yaroslav Halchenko
0151976676
Typo fix unncessary -> unnecessary.
Detected while reading recent CHANGELOG entry but then decided to apply
to entire codebase and docs since why not?
2022-08-20 09:40:19 -04:00
Ilya_Shlyakhter
c25ade4d97 Added a comment: imports and symlinks 2022-08-19 20:19:50 +00:00
Joey Hess
f091eff476
Merge branch 'master' of ssh://git-annex.branchable.com 2022-08-19 13:45:19 -04:00
Joey Hess
ed39979ac8
import: Avoid following symbolic links inside directories being imported
Too big a footgun.

This does not prevent attackers who can write to the directory being
imported from racing the check. But they can cause anything to be imported
anyway, so would be limited to getting the legacy import to follow into a
directory they do not write to, and move files out of it into the annex.
(The directory special remote does not have that problem since it does not
move files.)

Sponsored-by: Jack Hill on Patreon
2022-08-19 13:31:16 -04:00
Ilya_Shlyakhter
39763ddee7 Added a comment: git-annex-import and symlinks 2022-08-19 17:18:37 +00:00
Joey Hess
4ca8e95773
comment 2022-08-19 13:06:38 -04:00
Joey Hess
94029995fa
fix git-annex add regression on deleted file
Fix a regression in 10.20220624 that caused git-annex add to crash when
there was an unstaged deletion.

Sponsored-by: Dartmouth College's Datalad project
2022-08-19 12:55:49 -04:00
skcin
fb57fd9b96 Added a comment: Option to not follow symlinks? 2022-08-18 15:32:43 +00:00
yarikoptic
c80ea222da added datalad project tag to the issue 2022-08-17 19:56:25 +00:00
yarikoptic
3368172a10 Added a comment 2022-08-17 19:55:45 +00:00
yarikoptic
702f6fcb00 initial report on getSymbolicLinkStatus crashing upon file removal 2022-08-17 18:46:27 +00:00
Joey Hess
0d33a7a029
Merge branch 'master' of ssh://git-annex.branchable.com 2022-08-17 13:16:06 -04:00
Joey Hess
b801812660
init: probe if sqlite works
Help the user get annex.dbdir configured when their filesystem is not
one that sqlite works on.

The change in Database.Handle makes an error from sqlite not be ignored
besides being displayed, which it was before. I can't see any reason
git-annex would want to ignore these errors.

I chose to use the fsck database rather than the keys database because
opening the keys database populates it, and see commit
b3c4579c79.

The placement of the call to checkSqliteWorks inside checkInitializeAllowed
avoids annex.uuid getting set before it's called.

Sponsored-by: Dartmouth College's Datalad project
2022-08-17 13:12:26 -04:00
account+annex@806a7c5f67b75d530bced4ea294c77681ebdf766
ec3863e8d4 Added a comment 2022-08-17 16:59:17 +00:00
Joey Hess
fc2d10d2cd
fixed in v10 2022-08-17 12:40:43 -04:00
account+annex@806a7c5f67b75d530bced4ea294c77681ebdf766
c382375d49 2022-08-17 14:28:27 +00:00
Joey Hess
7286f408fa
close 2022-08-15 14:33:40 -04:00
Joey Hess
195f870265
comment 2022-08-15 14:05:05 -04:00
Joey Hess
d07a1dbdee
comment about annex.dbdir on relevant bugs 2022-08-12 13:31:27 -04:00
Joey Hess
4cfe17a9e8
use a subdirectory of annex.dbdir
This allows annex.dbdir to be set globally or always set to the same
value when needed. Each repository uses a subdirectory of it.

Sponsored-by: Dartmouth College's Datalad project
2022-08-12 13:18:15 -04:00
Joey Hess
16e82f6cf9
comment 2022-08-12 13:10:54 -04:00
Joey Hess
b80ad3a2ad
comment 2022-08-11 17:16:35 -04:00
Joey Hess
e9ffffbb8f
close 2022-08-10 12:29:29 -04:00
Atemu
434a1423c0 Added a comment 2022-08-10 12:35:28 +00:00
yarikoptic
bd3c68a57a Added a comment 2022-08-09 19:12:40 +00:00
yarikoptic
7cfab36e10 Added a comment 2022-08-09 18:02:32 +00:00
yarikoptic
dc10e9fdc2 Added a comment 2022-08-09 18:02:08 +00:00
Joey Hess
21cfd0ea98
fix reversion
3a513cfe73 caused a reversion in addurl.
The type of addSmall changed, but the void prevented the type checker
from helping notice this. Since it now returns a CommandPerform, the
cleanup action has to be run.

Sponsored-by: Dartmouth College's Datalad project
2022-08-09 13:49:30 -04:00
Joey Hess
eb2acf5fd7
comment 2022-08-09 13:26:47 -04:00
Joey Hess
4a68abace1
comment 2022-08-09 13:21:58 -04:00
Joey Hess
607c57d66b
comment 2022-08-09 13:06:48 -04:00
Joey Hess
4a5b50fae8
comment 2022-08-09 12:33:24 -04:00
yarikoptic
5595d0ef96 initial report on possible regression due to --dry-run 2022-08-09 13:37:39 +00:00
Atemu
50c4632740 Added a comment 2022-08-09 06:22:50 +00:00
Atemu
007d89f3e9 Added a comment 2022-08-09 06:14:05 +00:00
rinomizu5@5ead4c82685c65d7717dbd5591b80425036ae9e3
8adb37a98c Added a comment 2022-08-09 00:33:56 +00:00
Joey Hess
abd417d4fe
Avoid running multiple bup split processes concurrently
Since bup split is not concurrency safe.

Used a lock file so that 2 git-annex processes only run one bup split
between them (per bup repo).

(Concurrent writes from different git-annex repository clones to the same
bup repo could still have concurrency problems.)

Sponsored-by: Noam Kremen on Patreon
2022-08-08 18:54:06 -04:00
Joey Hess
04247fb4d0
avoid surprising "not found" error when copying to a http remote
git-annex copy --to a http remote will of course fail, as that's not
supported. But git-annex copy first checks if the content is already
present in the remote, and that threw a "not found".

Looks to me like other remotes that use Url.checkBoth in their checkPresent
do just return false when it fails. And Url.checkBoth does display
errors when unusual errors occur. So I'm pretty sure removing this error
message is ok.

Sponsored-by: Jarkko Kniivilä on Patreon
2022-08-08 11:57:24 -04:00
Joey Hess
645a66a084
comment 2022-08-08 11:26:25 -04:00
Joey Hess
7a235469e7
comment 2022-08-08 11:23:54 -04:00
Joey Hess
8d3a6ae527
comment 2022-08-08 11:15:04 -04:00
rinomizu5@5ead4c82685c65d7717dbd5591b80425036ae9e3
d4b29293b8 Added a comment: Additional Questions: git annex copy failed 2022-08-08 10:31:26 +00:00
rinomizu5@5ead4c82685c65d7717dbd5591b80425036ae9e3
96794dbd0a Added a comment: Additional Questions: git annex copy failed 2022-08-08 10:31:04 +00:00
Atemu
dec58c032c Added a comment 2022-08-07 08:05:24 +00:00
Joey Hess
6d762fafae
idea 2022-08-05 14:54:10 -04:00
Joey Hess
ee73bc7a3c
tag datalad since they have an issue about this 2022-08-05 14:48:21 -04:00
Joey Hess
7ac161395b
comment 2022-08-05 14:10:47 -04:00
Joey Hess
9e66a332b4
Merge branch 'master' of ssh://git-annex.branchable.com 2022-08-05 13:57:32 -04:00
Joey Hess
5bc70e2da5
When bup split fails, display its stderr
It seems worth noting here that I emailed bup's author about bup split
being noisy on stderr even with -q in approximately 2011. That never got
fixed. Its current repo on github only accepts pull requests, not bug
reports. Needing to add such complexity to deal with such a longstanding
unfixed issue is not fun.

Sponsored-by: Kevin Mueller on Patreon
2022-08-05 13:57:20 -04:00
yarikoptic
e884d2ed4c Added a comment 2022-08-05 16:17:09 +00:00
Joey Hess
a23fd7349f
work around git segfault
Work around bug in git 2.37 that causes a segfault when when
core.untrackedCache is set, and broke git-annex init.

Depending on when git gets fixed and how widely the buggy versions are
used, this could be reverted quite soon, or need to linger for a long time.
It only makes git-annex init a tiny bit slower in a new repo.

Sponsored-by: Max Thoursie on Patreon
2022-08-04 14:20:57 -04:00
Joey Hess
008204b2f3
explain why this happens and close 2022-08-04 12:39:07 -04:00
Joey Hess
6950e01e2a
Revert "fix link"
This reverts commit 2f671f1d1b.

Didn't work
2022-08-04 12:20:02 -04:00
Joey Hess
2f671f1d1b
fix link 2022-08-04 12:18:49 -04:00
rinomizu5@5ead4c82685c65d7717dbd5591b80425036ae9e3
2824b476c2 2022-08-04 08:28:09 +00:00
rinomizu5@5ead4c82685c65d7717dbd5591b80425036ae9e3
925424092b 2022-08-04 08:26:11 +00:00
rinomizu5@5ead4c82685c65d7717dbd5591b80425036ae9e3
e91fdabba7 2022-08-04 08:23:05 +00:00
jkniiv
164129b53d Added a comment 2022-08-03 15:47:08 +00:00
Joey Hess
c2aa67d373
Merge branch 'master' of ssh://git-annex.branchable.com 2022-08-02 12:33:17 -04:00
yarikoptic
bb30d43b7f Added a comment 2022-08-01 18:55:38 +00:00
yarikoptic
818614ceaf Added a comment 2022-08-01 18:51:59 +00:00
Joey Hess
dddaec1b74
Revert "stack.yaml: Updated to lts-19.16"
This reverts commit b5dc04099e.

Broke windows build, because the new lts updates Win32 to a version that
lacks a function that git-annex needs. git-annex.cabal depends on an
older Win32, and so stack build fails.

Will need to wait to update stack.yaml until this is fixed
https://github.com/haskell/win32/issues/208
and is in a new LTS release.
2022-08-01 13:24:46 -04:00
Joey Hess
010332dba3
comment 2022-08-01 13:10:30 -04:00
jkniiv
0e14491e00 Added a comment 2022-07-31 18:00:59 +00:00
Ilya_Shlyakhter
2d982ffccd Added a comment: lts version 2022-07-31 17:25:27 +00:00
jkniiv
0b748f8d9b lts-19.16 causes an issue on Windows 2022-07-31 08:56:00 +00:00
ceramic_glass
10d051f49d Added a comment 2022-07-29 08:08:33 +00:00
Joey Hess
c8a2752345
comment 2022-07-28 12:07:30 -04:00
ceramic_glass
7ec949e0fc 2022-07-28 00:23:44 +00:00
Joey Hess
d905232842
use ResourcePool for hash-object handles
Avoid starting an unncessary number of git hash-object processes when
concurrency is enabled.

Sponsored-by: Dartmouth College's DANDI project
2022-07-25 17:32:39 -04:00
Joey Hess
b1c49c373a
analysis 2022-07-25 17:03:24 -04:00
yarikoptic
afa4f3c3da initial report on hash-object's 2022-07-25 19:17:37 +00:00
arnaud@c1d1cc612a3921dc06a417301be08a3e125478c4
be2d1ab18d Added a comment 2022-07-23 08:48:17 +00:00
Atemu
d73b2d307c Added a comment 2022-07-22 23:47:19 +00:00
Joey Hess
e1de941b2c
close git bug that I reported to git mailing list 2022-07-22 13:24:24 -04:00
Joey Hess
591e87f1f2
reproduced 2022-07-22 12:24:42 -04:00
Joey Hess
162c8cdec0
comment 2022-07-22 11:59:15 -04:00
arnaud@c1d1cc612a3921dc06a417301be08a3e125478c4
113ccfcc32 Added a comment: Happens only when core.untrackedCache=true 2022-07-21 08:23:04 +00:00
akspecs@fae4f3d58a0c6c9d50f01a850ce53d425e1a90ba
d23c281856 Added a comment: cannot reproduce 2022-07-19 12:53:46 +00:00
arnaud@c1d1cc612a3921dc06a417301be08a3e125478c4
b566ef839e 2022-07-19 11:22:26 +00:00
g@aaed65f19d6c3a2a18c33da828e66c7bb915e65a
14e8b42c77 removed duplicated content 2022-07-18 16:42:10 +00:00
g@aaed65f19d6c3a2a18c33da828e66c7bb915e65a
f8d454b493 Add new bug "creating failure getting/copying on git-lfs remote (gcrypt)" 2022-07-18 16:18:42 +00:00
g@aaed65f19d6c3a2a18c33da828e66c7bb915e65a
36dd9c124f Add new bug "creating failure getting/copying on git-lfs remote (gcrypt)" 2022-07-18 16:17:33 +00:00
Atemu
2f09ebaf4d 2022-07-17 13:49:11 +00:00
Atemu
4a78214bde 2022-07-17 13:17:22 +00:00
Joey Hess
ee8acd5b5d
Merge branch 'master' of ssh://git-annex.branchable.com 2022-07-15 15:07:05 -04:00
Joey Hess
a2b1f369d1
disable journalIgnorable in enableInteractiveBranchAccess
Fix a reversion that prevented --batch commands (and the assistant)
from noticing data written to the journal by other commands.

I have not identified which commit broke this for sure,
but probably it was aeca7c2207

--batch commands that wrote to the journal avoided the problem since
journalIgnorable sets unset on write. It's a little bit surprising that
nobody noticed that query --batch commands did not see data written by
other commands.

Sponsored-by: Dartmouth College's DANDI project
2022-07-15 13:48:41 -04:00
nick.guenther@e418ed3c763dff37995c2ed5da4232a7c6cee0a9
4f66f036e6 2022-07-15 16:26:18 +00:00
Joey Hess
c3df38dd15
comment 2022-07-14 13:54:50 -04:00
yarikoptic
ba3c48a9e3 Added a comment 2022-07-13 22:05:46 +00:00
Joey Hess
50c2cac7e7
adb: Added configuration setting oldandroid=true
To avoid using find -printf, which was first supported in Android around
2019-2020.

Probing seems too fragile, and execing stat once per file is too slow to do
when there's a faster way available, which brought me to an option...

Sponsored-by: Brett Eisenberg on Patreon
2022-07-13 18:00:47 -04:00
Joey Hess
f358805fc2
comment 2022-07-13 17:26:10 -04:00
Joey Hess
58d163cfc0
Merge branch 'master' of ssh://git-annex.branchable.com 2022-07-13 17:17:44 -04:00
Joey Hess
fbc3c223a6
filter-process: Fix protocol for empty files
This caused git to complain that filter-process failed and kill it with
signal 15. Because it wrote an extra flushPkt for an empty file, which
git did not expect, and so git saw an unexpected response to the next
request.

Luckily, filter-process is only used by default in v9 and up, and v8 is
still the default. Also, git had to be updating an empty file, followed
by another file, which is a fairly unlikely situation. And git restarts
filter-process after this happens and uses it to filter the rest of the
files. So this isn't a crippling bug.

Sponsored-by: Luke Shumaker on Patreon
2022-07-13 17:13:54 -04:00
yarikoptic
557341315a Added a comment 2022-07-13 19:27:06 +00:00
Joey Hess
7c7b7ac9b9
followup 2022-07-13 14:53:46 -04:00
Joey Hess
afbfc106af
comment 2022-07-13 13:09:04 -04:00
Joey Hess
aaccada8fd
comment 2022-07-12 17:00:36 -04:00
Joey Hess
e74e51c761
Merge branch 'master' of ssh://git-annex.branchable.com 2022-07-12 16:48:11 -04:00
Joey Hess
323c78b191
comment
(and fix an old comment's formatting)
2022-07-12 16:47:49 -04:00
yarikoptic
aead843318 Added a comment 2022-07-12 20:47:22 +00:00
yarikoptic
12c5c1d975 initial complaining about slow annex init 2022-07-12 20:10:26 +00:00
Joey Hess
79e3dcc169
retitle and fix link 2022-07-12 15:01:53 -04:00
Joey Hess
9a7654d83a
Merge branch 'master' of ssh://git-annex.branchable.com 2022-07-12 14:59:24 -04:00
Joey Hess
2d65c4ff1d
avoid unix-compat's rename
On Windows, that does not support long paths
https://github.com/jacobstanley/unix-compat/issues/56

Instead, use System.Directory.renamePath, which does support long paths.

Sponsored-by: Dartmouth College's Datalad project
2022-07-12 14:55:02 -04:00
jenkin.schibel@286264d9ceb79998aecff0d5d1a4ffe34f8b8421
44a5eef718 Added a comment: phone version 2022-07-12 18:37:16 +00:00
Joey Hess
51c43e8c95
comment 2022-07-12 12:37:08 -04:00
jenkin.schibel@286264d9ceb79998aecff0d5d1a4ffe34f8b8421
95048a7ad4 2022-07-12 00:24:14 +00:00
Joey Hess
9c6e45c0b2
Merge branch 'master' of ssh://git-annex.branchable.com 2022-07-08 10:33:54 -04:00
yarikoptic
e7f499ba36 initial report on inability to connect to S3 2022-07-07 19:56:06 +00:00
Joey Hess
24ff57160f
comment 2022-07-07 12:45:51 -04:00
mih
a223f402f3 Added a comment: Recent version tested 2022-07-06 12:18:36 +00:00
mih
35d27ab0d9 2022-07-06 06:24:06 +00:00
Joey Hess
697e22cceb
fixed 2022-07-05 16:35:19 -04:00
Joey Hess
201e41cffd
add: Fix reversion when adding an annex link that has been moved to another directory
Fixes commit f259be7f39

Sponsored-by: Dartmouth College's Datalad project
2022-07-05 16:22:41 -04:00
Joey Hess
149d12f188
support --backend again in addurl and importfeed
Missed these two when converting from a global option.

Sponsored-by: Dartmouth College's Datalad project
2022-07-05 15:35:43 -04:00
yarikoptic
e355c22629 Added a comment: mystery resolved 2022-07-01 19:19:30 +00:00
yarikoptic
cd1c07bc4c initial report on move bug 2022-07-01 13:45:02 +00:00
Soxofaan
65ba22ae5c Added a comment: no worries 2022-06-30 16:51:51 +00:00
yarikoptic
dac8c76d0c asking to return --backend for addurl 2022-06-30 15:00:19 +00:00
yarikoptic
c0f86a1009 FTBFS report on linux 2022-06-30 14:52:24 +00:00
contr-error
c17a4476f9 marking as done 2022-06-29 19:14:38 +00:00
contr-error
281f116c6a Added a comment 2022-06-29 19:13:56 +00:00
Joey Hess
ad34d7996d
close bug that was recently fixed 2022-06-29 14:51:11 -04:00
Joey Hess
0184fef516
close 2022-06-29 14:44:02 -04:00
Joey Hess
834b4e5012
close 2022-06-29 14:42:40 -04:00
Joey Hess
43814314ae
close 2022-06-29 14:41:34 -04:00
Joey Hess
42c5d9631d
close 2022-06-29 14:39:21 -04:00
Joey Hess
dd4c110f3c
close 2022-06-29 14:38:16 -04:00
Joey Hess
82063e20c7
close 2022-06-29 14:37:02 -04:00
Joey Hess
cddcabfbb5
include filename in fsck warning
So it's available in --quiet mode. The same was already done in other
fsck warnings.

Sponsored-by: Noam Kremen on Patreon
2022-06-29 14:33:35 -04:00
Joey Hess
4b4795ec85
this is fixed 2022-06-29 14:30:57 -04:00
Joey Hess
4a17981196
close 2022-06-29 14:29:00 -04:00
Joey Hess
a6e332fd51
close 2022-06-29 14:27:44 -04:00
Joey Hess
02ef3d6a64
fix build with assistant disabled and webapp enabled
The webapp modules cannot build with the assistant disabled, so make the
webapp be under the assistant build flag.

Sponsored-by: Jarkko Kniivilä on Patreon
2022-06-29 14:19:18 -04:00
Joey Hess
46faf74d90
close 2022-06-29 13:45:33 -04:00
Joey Hess
7f1d556d13
close 2022-06-29 13:38:46 -04:00
Joey Hess
b223988e22
remove --backend from global options
--backend is no longer a global option, and is only accepted by commands
that actually need it.

Three commands that used to support backend but don't any longer are
watch, webapp, and assistant. It would be possible to make them support it,
but I doubt anyone used the option with these. And in the case of webapp
and assistant, the option was handled inconsistently, only taking affect
when the command is run with an existing git-annex repo, not when it
creates a new one.

Also, renamed GlobalOption etc to AnnexOption. Because there are many
options of this type that are not actually global (any more) and get
added to commands that need them.

Sponsored-by: Kevin Mueller on Patreon
2022-06-29 13:33:25 -04:00
Joey Hess
3eecf2033a
update 2022-06-29 12:51:01 -04:00
Joey Hess
2a009bf14e
close 2022-06-29 12:43:30 -04:00
Joey Hess
21c50c0f72
fix parallel copy from/to a local git repo
Improve handling of parallelization with -J when copying content from/to a
git remote that is a local path.

Sponsored-by: Nicholas Golder-Manning on Patreon
2022-06-29 12:40:12 -04:00
Joey Hess
54baa480b6
close mistaken bug report 2022-06-29 12:26:36 -04:00