Commit graph

23578 commits

Author SHA1 Message Date
https://www.google.com/accounts/o8/id?id=AItOawnVnsqEy82M-MuS2gLri-az83wSQ6lXSrc
44739733a1 2015-04-07 06:45:49 +00:00
Joey Hess
279fa44cd0 fromkey, registerurl: When reading from stdin, allow the filename and url, respectively, to contain whitespace. 2015-04-07 00:58:51 -04:00
Joey Hess
42281f12d6 bring back --quiet filtering of stdout and stderr, with deadlock fixed
I don't quite understand the cause of the deadlock. It only occurred
when git-annex-shell transferinfo was being spawned over ssh to feed
download transfer progress back. And if I removed this line from
feedprogressback, the deadlock didn't occur:
	bytes <- readSV v

The problem was not a leaked FD, as far as I could see. So what was it?
I don't know.

Anyway, this is a nice clean implementation, that avoids the deadlock.
Just fork off the async threads to handle filtering the stdout and stderr,
and let them clean up their handles whenever they decide to exit.

I've verified that the handles do get promptly closed, although a little
later than I would expect. Presumably that "little later" is what
was making waiting on the threads deadlock.

Despite the late exit, the last line of stdout and stderr appears where
I'd want it to, so I guess this is ok..
2015-04-06 20:20:52 -04:00
Joey Hess
667e16f1b9 use signingKey 2015-04-06 18:56:38 -04:00
Joey Hess
b359ead58e Merge branch 'master' of ssh://git-annex.branchable.com 2015-04-06 18:39:08 -04:00
Joey Hess
b857253ae9 reorder params 2015-04-06 18:38:34 -04:00
https://id.koumbit.net/anarcat
229074516c Added a comment 2015-04-06 22:16:57 +00:00
Joey Hess
b2814bc891 response 2015-04-06 17:21:53 -04:00
Joey Hess
72db78b92d add news item for git-annex 5.20150406.1 2015-04-06 17:21:45 -04:00
Joey Hess
8966bbb474 Merge branch 'master' of ssh://git-annex.branchable.com 2015-04-06 17:13:37 -04:00
Joey Hess
c83940393a emergency release 2015-04-06 17:13:20 -04:00
Joey Hess
0a89d55269 Fixes a bug in the last release that caused rsync and possibly other commands to hang at the end of a file transfer.
Stderr reader blocks waiting for all stderr, and so blocks the process ever
exiting.

I tried several ways to get around this, but no success yet. For now,
disable the stderr reader entirely.
2015-04-06 17:12:38 -04:00
anarcat
5c802a8e39 sshcaching seems to be the cause here 2015-04-06 20:56:52 +00:00
anarcat
4eb0a24344 ok, this is not a git-annex-shell problem it seems? i am totally confused 2015-04-06 20:38:36 +00:00
anarcat
84e99bd7db git-annex-shell doesn't seem to work as a login shell here 2015-04-06 20:29:38 +00:00
anarcat
cdcd678007 ah, just found metainit 2015-04-06 19:59:42 +00:00
anarcat
d38fd5069c sample startup script 2015-04-06 19:57:43 +00:00
Joey Hess
88458211a2 add news item for git-annex 5.20150406 2015-04-06 14:37:59 -04:00
Joey Hess
b909b3ccbb remove one-off clean 2015-04-06 14:11:43 -04:00
Joey Hess
2a9fbec446 Merge branch 'master' of ssh://git-annex.branchable.com 2015-04-06 14:07:42 -04:00
Joey Hess
4ca5370980 force rebuild 2015-04-06 14:07:02 -04:00
https://www.google.com/accounts/o8/id?id=AItOawlZF5AC-FSxwkiay5ZgEYZwUzN69Wa6PTE
74b14a5252 Added a comment: filename from metadata? 2015-04-06 18:00:26 +00:00
Joey Hess
42e46a8701 avoid using --literal-pathspecs with git older than 1.8.1 which added it
Windows is still building with an older git.
2015-04-06 13:46:11 -04:00
Joey Hess
aba1464fe4 promote comment which is really a bug report to a proper bug report 2015-04-06 13:11:07 -04:00
Joey Hess
f64c58f364 move to todo 2015-04-06 13:09:46 -04:00
Joey Hess
e6fdd01f6e reopen 2015-04-06 13:09:35 -04:00
Joey Hess
7f356edc46 comment 2015-04-06 13:01:59 -04:00
Joey Hess
e7c521f946 response 2015-04-06 13:00:17 -04:00
Joey Hess
dd96043011 prep release 2015-04-06 12:50:22 -04:00
Joey Hess
62ed5409c6 expire --no-act 2015-04-05 15:02:55 -04:00
Joey Hess
e3ea9d21fc info remove: show trust level 2015-04-05 13:51:01 -04:00
Joey Hess
9c31b91c89 update 2015-04-05 13:28:16 -04:00
Joey Hess
7fcfb1ae77 Merge branch 'master' of ssh://git-annex.branchable.com 2015-04-05 12:58:57 -04:00
Joey Hess
567a6b2c3a devblog 2015-04-05 12:57:25 -04:00
Joey Hess
9445556c97 rethought distributed fsck; instead add activity.log and expire command
This is much more space efficient!
2015-04-05 12:50:02 -04:00
mac
9fe7198359 Added a comment: importfeeds with file based rss contents 2015-04-04 20:42:27 +00:00
mac
ada2f6b1f9 removed 2015-04-04 20:42:03 +00:00
mac
6428fa1e0b Added a comment: importfeeds with file based rss contents 2015-04-04 20:39:57 +00:00
Joey Hess
1d57f142f1 Merge branch 'concurrentprogress' 2015-04-04 15:01:00 -04:00
Joey Hess
30aa902174 relay external special remote stderr through progress suppression machinery (eep!)
It sounds worse than it is. ;)

Some external special remotes may run commands that display progress on
stderr. If git-annex is run with --quiet, this should filter out such
displays while letting the errors through.
2015-04-04 14:54:03 -04:00
Joey Hess
2343f99c85 well along the way to fully quiet --quiet
Came up with a generic way to filter out progress messages while keeping
errors, for commands that use stderr for both.

--json mode will disable command outputs too.
2015-04-04 14:34:03 -04:00
https://www.google.com/accounts/o8/id?id=AItOawl6rte43qSRK1o2zn7Ww4Z8pgBmJm8gDrc
d50a475a8b Added a comment 2015-04-04 07:34:58 +00:00
https://openid.stackexchange.com/user/e65e6d0e-58ba-41de-84cc-1f2ba54cf574
8f9f0a00b5 Added a comment: Yes and no... 2015-04-04 04:13:48 +00:00
Joey Hess
ff2eeaf054 avoid progress bar for url download with --quiet 2015-04-03 20:38:56 -04:00
Joey Hess
b2ad3403c6 make downloadQuiet quiet again
This was broken in commit c64ede23cd
2015-04-03 20:38:20 -04:00
Joey Hess
6d79378346 dead code 2015-04-03 20:10:32 -04:00
Joey Hess
e87f3b40eb propigate outer output state into inner state when running onLocal
Otherwise, progress displays would not be suppressed here when running with
--quiet. Interesting wrinkle!
2015-04-03 20:08:38 -04:00
Joey Hess
d7f66a90af reall disable progress displays for --quiet 2015-04-03 20:08:25 -04:00
Joey Hess
3146d24e29 use def 2015-04-03 19:56:56 -04:00
Joey Hess
45e97191c3 fix stderr handling 2015-04-03 19:48:56 -04:00