Commit graph

10433 commits

Author SHA1 Message Date
falsifian
4407ade4c3 Added a comment 2021-02-12 03:52:39 +00:00
jwodder
80ec124fb0 2021-02-11 16:06:00 +00:00
jwodder
69f2fb7a23 2021-02-11 16:04:20 +00:00
Joey Hess
f36a0c1b13
deal with cabal unpack not preserving execute bit 2021-02-08 14:32:24 -04:00
Joey Hess
3a66cd715f
avoid making absolute git remote path relative
When a git remote is configured with an absolute path, use that path,
rather than making it relative. If it's configured with a relative path,
use that.

Git.Construct.fromPath changed to preserve the path as-is,
rather than making it absolute. And Annex.new changed to not
convert the path to relative. Instead, Git.CurrentRepo.get
generates a relative path.

A few things that used fromAbsPath unncessarily were changed in passing to
use fromPath instead. I'm seeing fromAbsPath as a security check,
while before it was being used in some cases when the path was
known absolute already. It may be that fromAbsPath is not really needed,
but only git-annex-shell uses it now, and I'm not 100% sure that there's
not some input that would cause a relative path to be used, opening a
security hole, without the security check. So left it as-is.

Test suite passes and strace shows the configured remote url is used
unchanged in the path into it. I can't be 100% sure there's not some code
somewhere that takes an absolute path to the repo and converts it to
relative and uses it, but it seems pretty unlikely that the code paths used
for a git remote would call such code. One place I know of is gitAnnexLink,
but I'm pretty sure that git remotes never deal with annex symlinks. If
that did get called, it generates a path relative to cwd, which would have
been wrong before this change as well, when operating on a remote.
2021-02-08 13:18:01 -04:00
yarikoptic
2038d839cc Added a comment: why relative path? 2021-02-08 14:47:43 +00:00
yarikoptic
30728860ac removed 2021-02-08 14:46:11 +00:00
yarikoptic
6834093433 Added a comment 2021-02-08 14:44:39 +00:00
falsifian
be5a0e4b8f 2021-02-05 05:11:24 +00:00
gueux
59fa8b7671 Added a comment 2021-02-03 17:20:24 +00:00
gueux
31f5482729 Added a comment 2021-02-03 17:06:24 +00:00
jrollins
627940cf7b Added a comment 2021-02-02 17:43:19 +00:00
Joey Hess
d631304237
remove priority tag (unused) 2021-02-02 12:42:20 -04:00
Joey Hess
ba0de2d26a
comment 2021-02-02 12:33:01 -04:00
Joey Hess
e8d31910d0
update tutorial to work with 6 year old version of git-annex-shell 2021-02-02 12:26:37 -04:00
jrollins
4e5a27841a Added a comment 2021-02-01 19:30:54 +00:00
jrollins
8de52b9f94 Added a comment 2021-02-01 19:07:29 +00:00
jrollins
85e9e67748 Added a comment 2021-02-01 19:04:42 +00:00
jrollins
f2b21baec4 Added a comment 2021-02-01 18:42:24 +00:00
gueux
c7096eb1ee Added a comment 2021-02-01 18:33:52 +00:00
jrollins
3aa72e95e3 Added a comment 2021-02-01 18:25:09 +00:00
gueux
657cc67385 Added a comment 2021-02-01 18:11:41 +00:00
jrollins
d1fe1bf908 Added a comment 2021-02-01 17:45:16 +00:00
Joey Hess
71f96a8d84
comment 2021-02-01 12:42:30 -04:00
Joey Hess
a6b0e8c7ea
comment 2021-02-01 12:40:30 -04:00
Joey Hess
895b02d8a3
comment 2021-02-01 12:16:26 -04:00
Joey Hess
58216ef39d
Include libkqueue.h file needed to build the assistant on BSDs
I suspect this is a bug in cabal sdist, because with
Includes: Utility/libkqueue.h
the file is not included, but putting it in extra-files does
get it into the tarball.
2021-02-01 12:00:56 -04:00
Joey Hess
41bf440729
Fix build on openbsd. Thanks, James Cook for the patch. 2021-02-01 11:56:17 -04:00
gitannex@5bd4fdc44060e9df930b142f801e3fc0d543c85d
131aeb53a3 2021-02-01 05:35:28 +00:00
jrollins
65b7c8cb09 Added a comment 2021-01-31 20:28:23 +00:00
jrollins
e5314ec9ee 2021-01-31 20:22:50 +00:00
jrollins
82e058ee24 2021-01-31 20:17:19 +00:00
jrollins
602c74ed0a 2021-01-31 20:12:07 +00:00
falsifian
7bf84e4963 Added a comment: tests mostly pass 2021-01-31 05:07:16 +00:00
falsifian
7cfa1e61bf 2021-01-31 04:56:16 +00:00
falsifian
36aa9a1d24 2021-01-31 04:55:34 +00:00
Joey Hess
7d18153955
close 2021-01-29 15:54:13 -04:00
Joey Hess
69be08ce0e
close 2021-01-29 15:52:45 -04:00
Joey Hess
e560110a7e
close 2021-01-29 15:50:08 -04:00
Joey Hess
6569e35ba4
close 2021-01-29 15:48:45 -04:00
Joey Hess
a7eff71cff
Merge branch 'master' of ssh://git-annex.branchable.com 2021-01-29 15:39:02 -04:00
Joey Hess
30667c2512
close moreinfo 2021-01-29 15:36:36 -04:00
Joey Hess
0fc1b94018
done 2021-01-29 15:35:30 -04:00
Joey Hess
96ffea3439
close direct mode 2021-01-29 15:34:47 -04:00
Joey Hess
59d9cb5394
close with proof this is not a bug 2021-01-29 15:33:15 -04:00
Joey Hess
93a5342797
close 2021-01-29 15:29:55 -04:00
Joey Hess
0d411a4203
close 2021-01-29 15:27:43 -04:00
Joey Hess
e248252542
close 2021-01-29 15:26:06 -04:00
Joey Hess
655068c71a
merge 2021-01-29 15:24:47 -04:00
Joey Hess
d5a2c39933
reject 2021-01-29 15:13:16 -04:00