Commit graph

3313 commits

Author SHA1 Message Date
http://joeyh.name/
92a3b8b2a7 Added a comment 2013-10-17 21:49:10 +00:00
http://joeyh.name/
66dd077fd5 Added a comment 2013-10-17 21:21:30 +00:00
Joey Hess
b7ab2c2ecb Merge branch 'master' of ssh://git-annex.branchable.com 2013-10-17 15:15:17 -04:00
Joey Hess
19816bca41 update for DiffTree type change (which fixes assistant in subdir confusion bug) 2013-10-17 15:11:21 -04:00
Joey Hess
f40ed91276 update 2013-10-17 14:17:48 -04:00
Joey Hess
4188ad9d7e repro recipe 2013-10-17 13:48:49 -04:00
https://www.google.com/accounts/o8/id?id=AItOawlWskoNgUB7r70OXglR-4iKI4bOuPJb-xg
6cd4e78718 Added a comment 2013-10-17 16:04:05 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkGCmVc5qIJaQQgG82Hc5zzBdAVdhe2JEM
af647b9cfc Added a comment 2013-10-16 22:47:46 +00:00
Joey Hess
4401df1e57 Merge branch 'master' of ssh://git-annex.branchable.com 2013-10-16 16:58:53 -04:00
Joey Hess
c868b00569 moreinfo 2013-10-16 16:46:23 -04:00
http://joeyh.name/
3d6e799213 Added a comment 2013-10-16 20:45:26 +00:00
http://joeyh.name/
36bead9ff2 Added a comment 2013-10-16 20:42:10 +00:00
Joey Hess
c76c94a0da S3: Try to ensure bucket name is valid for archive.org. 2013-10-16 16:35:47 -04:00
Joey Hess
02522cba68 Merge branch 'master' of ssh://git-annex.branchable.com 2013-10-16 16:13:09 -04:00
Joey Hess
4c6d2c0bbb close 2013-10-16 16:08:53 -04:00
http://joeyh.name/
52b8152a32 Added a comment 2013-10-16 18:04:30 +00:00
Joey Hess
6fb6913168 sheesh 2013-10-16 13:15:10 -04:00
Joey Hess
396e47b07e tighten file2key to not produce invalid keys with no keyName
A file named "foo-" or "foo-bar" was taken as a key's file, with a backend
of "foo", and an empty keyName. This led to various problems, especially
because converting that key back to a file did not yeild the same filename.
2013-10-16 12:46:24 -04:00
Joey Hess
15597e5fff Merge branch 'master' of ssh://git-annex.branchable.com 2013-10-16 12:25:09 -04:00
Joey Hess
8b80c340a6 move another bug report out of forum 2013-10-16 12:24:20 -04:00
http://joeyh.name/
b18e5128e0 Added a comment 2013-10-16 16:16:02 +00:00
http://joeyh.name/
ceab0aa358 Added a comment 2013-10-16 15:47:38 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmCzVCPjgg_Un_114P8iiSwExms0G2csCA
ab78289679 Added a comment: details about my problem 2013-10-15 23:30:27 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmCzVCPjgg_Un_114P8iiSwExms0G2csCA
c3dc010577 removed 2013-10-15 23:27:56 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmCzVCPjgg_Un_114P8iiSwExms0G2csCA
287ec803e8 Added a comment: details about my problem 2013-10-15 23:26:05 +00:00
bla
2a01a7d116 Added a comment: More info on latest autobuild 2013-10-15 21:42:52 +00:00
bla
6f3c6ebde1 Added a comment: Testing 2013-10-15 21:24:35 +00:00
Joey Hess
216d4bf10a Merge branch 'master' of ssh://git-annex.branchable.com 2013-10-15 16:06:10 -04:00
Joey Hess
bac078742d Deal with git check-attr -z output format change in git 1.8.5.
I have not actually tested with 1.8.5, which is not yet relesaed, but
git.git commit f7cd8c50b9ab83e084e8f52653ecc8d90665eef2 changes -z
to also apply to output, without regards to back-compat. (But with pretty
good reasons.)

New code should work with both versions, by fingerprinting for NULs and
newlines.
2013-10-15 16:05:27 -04:00
http://joeyh.name/
c5e9d901ae Added a comment: I can reproduce this! (with 4.20130923-g78e9013) 2013-10-15 19:57:19 +00:00
http://joeyh.name/
2a93f6285f Added a comment 2013-10-15 18:29:10 +00:00
Joey Hess
0d88bf9090 move bug report from forum.. sorry, people, but I can't let the forum continually be cluttered up with old bug reports 2013-10-15 14:11:08 -04:00
https://www.google.com/accounts/o8/id?id=AItOawlqOu7P4tb4D-Xo2pYrjln2NsAObtErliM
2fd67b8a0b 2013-10-14 18:42:20 +00:00
Joey Hess
b299408f62 Merge branch 'master' of ssh://git-annex.branchable.com 2013-10-14 12:21:16 -04:00
Joey Hess
267f8b0bb5 switch to runFormPostNoToken to work around strange yesod bug
I am not happy about disabling yesod's XSRF tokens, but the webapp has two
guards of its own that should suffice: Listening only to localhost
(normally) and requiring its own auth token on every single request
(always).
2013-10-14 12:19:11 -04:00
http://joeyh.name/
ca6936090a Added a comment 2013-10-14 16:18:03 +00:00
bla
56f929cfc3 2013-10-14 06:19:37 +00:00
bla
860b72a7dc 2013-10-14 06:13:19 +00:00
bla
6085934567 2013-10-13 20:14:06 +00:00
Joey Hess
0d0c7e1244 Merge branch 'master' of ssh://git-annex.branchable.com 2013-10-13 13:31:50 -04:00
https://www.google.com/accounts/o8/id?id=AItOawlWskoNgUB7r70OXglR-4iKI4bOuPJb-xg
00b18987a4 Added a comment 2013-10-13 12:35:50 +00:00
https://www.google.com/accounts/o8/id?id=AItOawlWskoNgUB7r70OXglR-4iKI4bOuPJb-xg
8c41f6a7dd 2013-10-13 09:04:52 +00:00
https://www.google.com/accounts/o8/id?id=AItOawlWskoNgUB7r70OXglR-4iKI4bOuPJb-xg
1d4f1d5170 2013-10-13 08:56:02 +00:00
Joey Hess
03fc341dcb close 2013-10-12 19:27:35 -04:00
https://www.google.com/accounts/o8/id?id=AItOawlWskoNgUB7r70OXglR-4iKI4bOuPJb-xg
13649750b8 2013-10-12 20:13:39 +00:00
https://id.koumbit.net/anarcat
c8ab2f1fce Added a comment: awesome, fix confirmed, and IA+quvi forwarded upstream 2013-10-12 11:23:31 +00:00
https://id.koumbit.net/anarcat
d6702ae54b bug fixed in later versions 2013-10-12 10:07:52 +00:00
http://joeyh.name/
a2d3e0f72a Added a comment 2013-10-11 18:49:25 +00:00
https://id.koumbit.net/anarcat
b84da183d3 report this bug properly 2013-10-11 18:45:50 +00:00
http://cstork.org/
6721b7501b Added a comment: git annex get/sync don't delete files 2013-10-10 11:43:29 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmVV_nBwlsyCv53BXoJt8YpCX_wZPfzpyo
859889a6ec Added a comment: Productive Annoyance 2013-10-10 04:30:48 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmVV_nBwlsyCv53BXoJt8YpCX_wZPfzpyo
3ec0e64f50 Added a comment: Progress 2013-10-10 01:17:08 +00:00
https://id.koumbit.net/anarcat
85594ec46c document this bug more explicitely 2013-10-09 22:47:20 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkGCmVc5qIJaQQgG82Hc5zzBdAVdhe2JEM
1d642259cb 2013-10-09 01:31:59 +00:00
https://www.google.com/accounts/o8/id?id=AItOawknwkXgi8SnK4QT32ANl3GMKvFLyQGeHqo
27fb2f7d02 Added a comment 2013-10-08 16:18:07 +00:00
http://droggl.myopenid.com/
dbb49b2a0f Added a comment 2013-10-08 07:46:35 +00:00
http://droggl.myopenid.com/
d21864be4b 2013-10-08 07:36:42 +00:00
http://alan.petitepomme.net/
59c5c4a46d 2013-10-08 07:11:18 +00:00
Joey Hess
45aed381df import: Skip .git directories. 2013-10-07 13:03:05 -04:00
https://id.koumbit.net/anarcat
75fd6e87bd sign 2013-10-07 12:07:07 +00:00
https://id.koumbit.net/anarcat
a9fab4d7b9 Added a comment: it's worse than not working, it kills! :) 2013-10-07 12:06:22 +00:00
https://id.koumbit.net/anarcat
19763df501 import not only doesn't work, it kills 2013-10-07 12:02:56 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnZEanlyzay_QlEAL0CWpyZcRTyN7vay8U
8a19b0e50b Added a comment: Tilde did it for me 2013-10-06 21:59:44 +00:00
Joey Hess
635c9a1549 assistant: Detect stale git lock files at startup time, and remove them.
Extends the index.lock handling to other git lock files. I surveyed
all lock files used by git, and found more than I expected. All are
handled the same in git; it leaves them open while doing the operation,
possibly writing the new file content to the lock file, and then closes
them when done.

The gc.pid file is excluded because it won't affect the normal operation
of the assistant, and waiting for a gc to finish on startup wouldn't be
good.

All threads except the webapp thread wait on the new startup sanity checker
thread to complete, so they won't try to do things with git that fail
due to stale lock files. The webapp thread mostly avoids doing that kind of
thing itself. A few configurators might fail on lock files, but only if the
user is explicitly trying to run them. The webapp needs to start
immediately when the user has opened it, even if there are stale lock
files.

Arranging for the threads to wait on the startup sanity checker was a bit
of a bear. Have to get all the NotificationHandles set up before the
startup sanity checker runs, or they won't see its signal. Perhaps
the NotificationBroadcaster is not the best interface to have used for
this. Oh well, it works.

This commit was sponsored by Michael Jakl
2013-10-05 17:04:21 -04:00
Joey Hess
1be4d281d6 Better sanitization of problem characters when generating URL and WORM keys.
FAT has a lot of characters it does not allow in filenames, like ? and *
It's probably the worst offender, but other filesystems also have
limitiations.

In 2011, I made keyFile escape : to handle FAT, but missed the other
characters. It also turns out that when I did that, I was also living
dangerously; any existing keys that contained a : had their object
location change. Oops.

So, adding new characters to escape to keyFile is out. Well, it would be
possible to make keyFile behave differently on a per-filesystem basis, but
this would be a real nightmare to get right. Consider that a rsync special
remote uses keyFile to determine the filenames to use, and we don't know
the underlying filesystem on the rsync server..

Instead, I have gone for a solution that is backwards compatable and
simple. Its only downside is that already generated URL and WORM keys
might not be able to be stored on FAT or some other filesystem that
dislikes a character used in the key. (In this case, the user can just
migrate the problem keys to a checksumming backend. If this became a big
problem, fsck could be made to detect these and suggest a migration.)

Going forward, new keys that are created will escape all characters that
are likely to cause problems. And if some filesystem comes along that's
even worse than FAT (seems unlikely, but here it is 2013, and people are
still using FAT!), additional characters can be added to the set that are
escaped without difficulty.

(Also, made WORM limit the part of the filename that is embedded in the key,
to deal with filesystem filename length limits. This could have already
been a problem, but is more likely now, since the escaping of the filename
can make it longer.)

This commit was sponsored by Ian Downes
2013-10-05 15:01:49 -04:00
http://cstork.org/
7b7d4b2353 Added a comment 2013-10-04 11:17:42 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnyMzZZLS1xGW1raqc_9Md6Ksdkvx5rUJU
5a330fe6c8 Added a comment 2013-10-04 10:59:30 +00:00
http://olivier.mehani.name/
fe52de18b5 Added a comment 2013-10-04 05:14:16 +00:00
Joey Hess
891242ad26 another lock file 2013-10-03 17:05:53 -04:00
https://www.google.com/accounts/o8/id?id=AItOawmf-gdwX6Nk3DyHyVCh3C_e8VGcAnPbMCI
05db0fef17 2013-10-03 13:02:40 +00:00
volfyd
64b3f4120b 2013-10-02 22:11:57 +00:00
http://joeyh.name/
d6986aef82 Added a comment 2013-10-02 20:37:04 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnyMzZZLS1xGW1raqc_9Md6Ksdkvx5rUJU
899d8959ca 2013-10-02 20:15:33 +00:00
Joey Hess
87c7f5dd62 Merge branch 'master' of ssh://git-annex.branchable.com 2013-09-30 12:49:06 -04:00
Joey Hess
7f7dcd315b fix direct mode switch permissions problem
Similar to how a similar problem with indirect was earlier fixed.
2013-09-30 12:48:40 -04:00
http://joeyh.name/
0a83779df5 Added a comment 2013-09-30 16:47:43 +00:00
http://joeyh.name/
f84073d6fd Added a comment 2013-09-30 16:23:38 +00:00
http://joeyh.name/
2ba975bf3d Added a comment 2013-09-30 16:13:20 +00:00
http://cstork.org/
8fd2717462 Added a comment: News page stopped listing latest releases? 2013-09-30 16:08:18 +00:00
Remy
f010b89f82 Added a comment: Thank you very much 2013-09-30 08:49:33 +00:00
http://olivier.mehani.name/
738b0cd466 Added a comment 2013-09-30 01:31:26 +00:00
http://olivier.mehani.name/
2534af1488 Added a comment 2013-09-30 01:29:50 +00:00
http://olivier.mehani.name/
2a539a9bfc removed 2013-09-30 01:13:32 +00:00
http://olivier.mehani.name/
c6ee93d83d Added a comment 2013-09-30 01:12:43 +00:00
Joey Hess
3f0ea53fc8 finally sorted out the OSX gpg mess 2013-09-29 16:30:49 -04:00
Joey Hess
c7ed2a24d5 dup 2013-09-29 15:16:13 -04:00
http://joeyh.name/
4a806492f3 Added a comment 2013-09-29 19:14:00 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmTlfbCC37CAjhQrS107ZWRVA_sF4s3gLU
b5287ef707 2013-09-29 08:27:17 +00:00
http://joeyh.name/
2d092b9169 Added a comment 2013-09-28 19:34:42 +00:00
Joey Hess
12f6b9693a Send a git-annex user-agent when downloading urls.
Overridable with --user-agent option.

Not yet done for S3 or WebDAV due to limitations of libraries used --
nether allows a user-agent header to be specified.

This commit sponsored by Michael Zehrer.
2013-09-28 14:35:21 -04:00
Joey Hess
55362462ae close 2013-09-28 11:30:01 -04:00
Joey Hess
4eef13f68a Merge branch 'master' of ssh://git-annex.branchable.com 2013-09-28 11:28:46 -04:00
Joey Hess
bd431408b5 analysis 2013-09-28 11:27:52 -04:00
Joey Hess
1ba3165135 fixed upstream 2013-09-28 10:57:15 -04:00
http://cstork.org/
7d3b13487d 2013-09-28 12:59:57 +00:00
Remy
ebc1ff27c7 2013-09-27 22:38:21 +00:00
Remy
135b6e70e5 2013-09-27 22:35:45 +00:00
Joey Hess
d6883dcd7f forwarded 2013-09-27 17:18:28 -04:00
volfyd
55a790635d 2013-09-27 19:18:57 +00:00
https://www.google.com/accounts/o8/id?id=AItOawl9sYlePmv1xK-VvjBdN-5doOa_Xw-jH4U
b71adf6ba6 Added a comment 2013-09-26 09:08:11 +00:00
https://www.google.com/accounts/o8/id?id=AItOawknwkXgi8SnK4QT32ANl3GMKvFLyQGeHqo
a227a5db07 Added a comment 2013-09-25 21:19:23 +00:00
Joey Hess
98fc7e8a19 add, import, assistant: Better preserve the mtime of symlinks, when when adding content that gets deduplicated.
Note that this turned out to remove a syscall, not add any expense.
Otherwise, I would not have done it.
2013-09-25 16:07:11 -04:00
Joey Hess
5ff9224b10 Merge branch 'master' of ssh://git-annex.branchable.com 2013-09-25 15:30:45 -04:00
Joey Hess
c45f5fbdb3 indirect: Better behavior when a file in direct mode is not owned by the user running the conversion. 2013-09-25 15:29:56 -04:00
http://joeyh.name/
b10a44b4ca Added a comment 2013-09-25 18:57:25 +00:00
http://joeyh.name/
d39d65594f Added a comment 2013-09-25 18:36:39 +00:00
http://joeyh.name/
3368ded592 Added a comment 2013-09-25 18:27:24 +00:00
http://joeyh.name/
256ac32458 Added a comment 2013-09-25 18:21:25 +00:00
http://joeyh.name/
6871f41e77 Added a comment 2013-09-25 18:18:49 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmegJFSUlkCanL5EButSxQcRGfo9hPbMEg
037fe31f9c 2013-09-24 08:58:18 +00:00
https://www.google.com/accounts/o8/id?id=AItOawl9sYlePmv1xK-VvjBdN-5doOa_Xw-jH4U
71fbcd4db1 2013-09-23 23:47:22 +00:00
https://www.google.com/accounts/o8/id?id=AItOawknwkXgi8SnK4QT32ANl3GMKvFLyQGeHqo
f16f304d65 2013-09-23 18:26:40 +00:00
http://joeyh.name/
baaeb3f89e Added a comment 2013-09-22 14:15:28 +00:00
John
86c9480418 Added a comment: runshell typo prevents execution 2013-09-22 00:24:11 +00:00
https://id.koumbit.net/anarcat
434dc22881 raise this question again, and sign so I can find it again :) 2013-09-21 15:23:22 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnxlx1UrzVhdy6_gFjzmF42x6QXxBUxg00
96d9639683 Added a comment: size of repo 2013-09-21 09:32:08 +00:00
Joey Hess
a5998619c7 Merge branch 'master' of ssh://git-annex.branchable.com 2013-09-19 17:08:15 -04:00
Joey Hess
006cf7976f more completely solve catKey memory leak
Done using a mode witness, which ensures it's fixed everywhere.

Fixing catFileKey was a bear, because git cat-file does not provide a
nice way to query for the mode of a file and there is no other efficient
way to do it. Oh, for libgit2..

Note that I am looking at tree objects from HEAD, rather than the index.
Because I cat-file cannot show a tree object for the index.
So this fix is technically incomplete. The only cases where it matters
are:

1. A new large file has been directly staged in git, but not committed.
2. A file that was committed to HEAD as a symlink has been staged
   directly in the index.

This could be fixed a lot better using libgit2.
2013-09-19 16:41:21 -04:00
http://joeyh.name/
cf756ff7b3 Added a comment 2013-09-19 19:07:04 +00:00
http://joeyh.name/
5d4a568478 Added a comment 2013-09-19 18:59:42 +00:00
http://joeyh.name/
7e317bcf03 Added a comment 2013-09-19 18:53:14 +00:00
Joey Hess
7e40153629 Merge branch 'master' of ssh://git-annex.branchable.com 2013-09-19 13:33:22 -04:00
Joey Hess
94fd1eb3d5 guard against runshell loop 2013-09-19 13:33:00 -04:00
http://joeyh.name/
6e82873004 Added a comment 2013-09-19 17:31:46 +00:00
http://joeyh.name/
015bf79399 Added a comment 2013-09-19 17:12:39 +00:00
http://churchkey.org/author/ian/
452d67a5fd Added a comment: Same problem, different user 2013-09-18 22:20:11 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmWg4VvDTer9f49Y3z-R0AH16P4d1ygotA
5d46492ee3 Added a comment: Update 2013-09-18 11:17:34 +00:00
https://id.koumbit.net/anarcat
14ea6a3ffa tentative patch 2013-09-16 18:10:06 +00:00
https://id.koumbit.net/anarcat
b56f0dc450 ouch 2013-09-16 17:56:44 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnsuhFUIfWNT-Q-C02FDaSQqceFDge5M9w
287c7682e5 Added a comment 2013-09-16 09:00:34 +00:00
http://olivier.mehani.name/
6cc54df4cc Added a comment 2013-09-16 01:27:14 +00:00
http://olivier.mehani.name/
7880dbcb81 2013-09-16 00:34:10 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnsuhFUIfWNT-Q-C02FDaSQqceFDge5M9w
d4c95a5c2b Added a comment 2013-09-15 23:10:38 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnsuhFUIfWNT-Q-C02FDaSQqceFDge5M9w
2c0675a06e Added a comment 2013-09-15 23:08:49 +00:00
Joey Hess
5c71dc1087 addurl: Fix quvi audodetection, broken in last release. 2013-09-15 16:37:03 -04:00
https://id.koumbit.net/anarcat
3adcbf1d05 there's a workaround 2013-09-14 21:31:11 +00:00
https://id.koumbit.net/anarcat
9b865502e3 hum, seems like youtube just stopped working for some reason 2013-09-14 21:25:07 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnsuhFUIfWNT-Q-C02FDaSQqceFDge5M9w
657cff00db Added a comment 2013-09-14 08:49:23 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnSenxKyE_2Z6Wb-EBMO8FciyRywjx1ZiQ
c56500b848 Added a comment 2013-09-13 21:58:31 +00:00
Joey Hess
aa23b6cf1a Merge branch 'master' of ssh://git-annex.branchable.com 2013-09-13 15:58:06 -04:00
Joey Hess
65ce244a04 moreinfo 2013-09-13 15:33:13 -04:00
Joey Hess
32411cec7a retitle 2013-09-13 15:31:54 -04:00
Joey Hess
91f603ce60 moreinfo 2013-09-13 15:29:51 -04:00
http://joeyh.name/
95829bd927 Added a comment 2013-09-13 19:29:25 +00:00
http://joeyh.name/
bc477edcd1 Added a comment 2013-09-13 19:27:51 +00:00
Joey Hess
f325f8a384 move to todo 2013-09-13 15:25:53 -04:00
Joey Hess
a5d3fd4f7a Merge branch 'master' of ssh://git-annex.branchable.com 2013-09-13 15:24:22 -04:00
Joey Hess
870ea0a0f0 typo 2013-09-13 15:22:59 -04:00
Joey Hess
3d9be3874d moreinfo 2013-09-13 15:21:15 -04:00
http://joeyh.name/
6940006c2d Added a comment 2013-09-13 19:18:26 +00:00